Sebastian Brudziński

Looks like this needs an IT

Looks like this needs an IT

Any reason we only do this for regular requisitions, and not emergency?

Any reason we only do this for regular requisitions, and not emergency?

Update logback.xml

Bring back logging to level INFO

    • -1
    • +1
    /deployment/perftest_env/config/log/logback.xml
OLMIS-7219 Add profilers to order creation logic

Let's not change behavior for this endpoint

Let's not change behavior for this endpoint

there's no "requisition" concept in fulfillment - let's stick to external id

there's no "requisition" concept in fulfillment - let's stick to external id

9.0.0 - major version needs to be updated in case of breaking changes

9.0.0 - major version needs to be updated in case of breaking changes

Actually, let's not change this behavior for POST /orders - it should still return 400 if the order already exists

Actually, let's not change this behavior for POST /orders - it should still return 400 if the order already exists

Do we need this check? What happens if I try to find by null value?

Do we need this check? What happens if I try to find by null value?

Merge pull request #17 from OpenLMIS/SELV3-238

SELV3-238 - Create extension point for Order Code in Fulfillment service

So I just remembered that for the Stock Management module we added a contract test that verifiess the extension point works - https://github.com/OpenLMIS/openlmis-contract-tests/blob/master/docker-...

So I just remembered that for the Stock Management module we added a contract test that verifiess the extension point works - https://github.com/OpenLMIS/openlmis-contract-tests/blob/master/docker-compose.stockmanagementextension.yml
We do not have the same for the fulfillment service as far as I know, so this part is not necessary and should be removed.

The indentation is incorrect

The indentation is incorrect

Can you explain this addition? What do we want to build here? It looks like it's related to the contract tests, the service name is fulfillmentextension (what is that?) and the version used is from...

Can you explain this addition? What do we want to build here? It looks like it's related to the contract tests, the service name is fulfillmentextension (what is that?) and the version used is from stockmanagement

Looks like this should be implemented separately in SELV - core shouldn't contain implementation-specific code (or parts of it)

Looks like this should be implemented separately in SELV - core shouldn't contain implementation-specific code (or parts of it)

Can you explain briefly how those changes help fix the problem and what was identified as a root cause?

Can you explain briefly how those changes help fix the problem and what was identified as a root cause?

My understanding is that with the "keep" option the volume will already exist. What happens when we attempt to create a column that already exists? Does it just skip the creation or does it throw a...

My understanding is that with the "keep" option the volume will already exist. What happens when we attempt to create a column that already exists? Does it just skip the creation or does it throw an error?

Correct, I think this should achieve what we want (edit: maybe it's worth verifying this with one repo only for starters, and then replicating to others if all works as expected)

Correct, I think this should achieve what we want (edit: maybe it's worth verifying this with one repo only for starters, and then replicating to others if all works as expected)

I think we don't want to run this step during releases, but we still want to have it for developer branches (i.e. run it for branches other than master). Thoughts Klaudia Pałkowska Paulina Buzderew...

I think we don't want to run this step during releases, but we still want to have it for developer branches (i.e. run it for branches other than master). Thoughts Klaudia Pałkowska Paulina Buzderewicz?

Looks good to me! I only noticed one typo - left a comment

Looks good to me! I only noticed one typo - left a comment

extensions

extensions