Sebastian Brudziński

About
  • First commit 14 June 2016
  • Latest commit 20 May 2021
Last Week All Time
Commits: 0 756

Reviews

1 active review

Counts may include data that you cannot access.

Line History

Line history chart not available

Line history chart not available

 

Commit Activity

Commits By Day In Week
52 week commits volume
Commits By Day In Week
Commits by day
Commits By Day In Week
Commits by hour
Commits By Hour In Day
Commit calendar
 

Committer Mappings

Sebastian Brudziński is mapped to 45 committers over 33 repositories
Username sbrudzinski is mapped to:
Friday 05 Nov 2021
4:25 pm

Sebastian Brudziński

4:24 pm

Sebastian Brudziński

3:15 pm

Sebastian Brudziński

I'd suggest locking to a specific version. i.e. if we know that v0.17 works as expected let's exactly use version 0.17

I'd suggest locking to a specific version. i.e. if we know that v0.17 works as expected let's exactly use version 0.17

Thursday 10 Jun 2021
8:20 am

Sebastian Brudziński

Wednesday 09 Jun 2021
8:29 am

Sebastian Brudziński

Looks like this needs an IT

Looks like this needs an IT

8:28 am

Sebastian Brudziński

Any reason we only do this for regular requisitions, and not emergency?

Any reason we only do this for regular requisitions, and not emergency?

Thursday 20 May 2021
2:30 pm

Sebastian Brudziński

Update logback.xml

Bring back logging to level INFO

Options
    • -1
    • +1
    /deployment/perftest_env/config/log/logback.xml
7:49 am

Sebastian Brudziński

7:46 am

Sebastian Brudziński

Friday 02 Apr 2021
12:10 pm

Sebastian Brudziński

Thursday 01 Apr 2021
1:35 pm

Sebastian Brudziński

OLMIS-7219 Add profilers to order creation logic

Options
    • -11
    • +21
    /src/main/java/org/openlmis/fulfillment/web/OrderController.java
9:19 am

Sebastian Brudziński

Let's not change behavior for this endpoint

Let's not change behavior for this endpoint

9:18 am

Sebastian Brudziński

there's no "requisition" concept in fulfillment - let's stick to external id

there's no "requisition" concept in fulfillment - let's stick to external id

9:17 am

Sebastian Brudziński

9.0.0 - major version needs to be updated in case of breaking changes

9.0.0 - major version needs to be updated in case of breaking changes

9:16 am

Sebastian Brudziński

Actually, let's not change this behavior for POST /orders - it should still return 400 if the order already exists

Actually, let's not change this behavior for POST /orders - it should still return 400 if the order already exists

9:15 am

Sebastian Brudziński

Do we need this check? What happens if I try to find by null value?

Do we need this check? What happens if I try to find by null value?

Tuesday 23 Mar 2021
2:23 pm

Sebastian Brudziński

Merge pull request #17 from OpenLMIS/SELV3-238

SELV3-238 - Create extension point for Order Code in Fulfillment service

Options
    • -0
    • +1
    /CHANGELOG.md
    • -2
    • +4
    /src/main/java/org/openlmis/fulfillment/service/OrderService.java
12:10 pm

Sebastian Brudziński

Thursday 18 Mar 2021
2:01 pm

Sebastian Brudziński

So I just remembered that for the Stock Management module we added a contract test that verifiess the extension point works - https://github.com/OpenLMIS/openlmis-contract-tests/blob/master/docker-...

So I just remembered that for the Stock Management module we added a contract test that verifiess the extension point works - https://github.com/OpenLMIS/openlmis-contract-tests/blob/master/docker-compose.stockmanagementextension.yml
We do not have the same for the fulfillment service as far as I know, so this part is not necessary and should be removed.

Wednesday 17 Mar 2021
9:27 am

Sebastian Brudziński

The indentation is incorrect

The indentation is incorrect

9:25 am

Sebastian Brudziński

Can you explain this addition? What do we want to build here? It looks like it's related to the contract tests, the service name is fulfillmentextension (what is that?) and the version used is from...

Can you explain this addition? What do we want to build here? It looks like it's related to the contract tests, the service name is fulfillmentextension (what is that?) and the version used is from stockmanagement

Monday 15 Mar 2021
10:19 am

Sebastian Brudziński

Looks like this should be implemented separately in SELV - core shouldn't contain implementation-specific code (or parts of it)

Looks like this should be implemented separately in SELV - core shouldn't contain implementation-specific code (or parts of it)

Wednesday 10 Mar 2021
1:23 pm

Sebastian Brudziński

Can you explain briefly how those changes help fix the problem and what was identified as a root cause?

Can you explain briefly how those changes help fix the problem and what was identified as a root cause?

1:22 pm

Sebastian Brudziński

My understanding is that with the "keep" option the volume will already exist. What happens when we attempt to create a column that already exists? Does it just skip the creation or does it throw a...

My understanding is that with the "keep" option the volume will already exist. What happens when we attempt to create a column that already exists? Does it just skip the creation or does it throw an error?

1:20 pm

Sebastian Brudziński

Wednesday 17 Feb 2021
11:26 am

Sebastian Brudziński

Tuesday 16 Feb 2021
4:39 pm

Sebastian Brudziński

Monday 23 Nov 2020
9:51 am

Sebastian Brudziński

Wednesday 18 Nov 2020
2:43 pm

Sebastian Brudziński

Correct, I think this should achieve what we want (edit: maybe it's worth verifying this with one repo only for starters, and then replicating to others if all works as expected)

Correct, I think this should achieve what we want (edit: maybe it's worth verifying this with one repo only for starters, and then replicating to others if all works as expected)

2:10 pm

Sebastian Brudziński

I think we don't want to run this step during releases, but we still want to have it for developer branches (i.e. run it for branches other than master). Thoughts Klaudia Pałkowska Paulina Buzderew...

I think we don't want to run this step during releases, but we still want to have it for developer branches (i.e. run it for branches other than master). Thoughts Klaudia Pałkowska Paulina Buzderewicz?