Sebastian Brudziński

I'd even change it to WARN

I'd even change it to WARN

Ultimately we need covid-ui here, but I understand the image is not ready yet

Ultimately we need covid-ui here, but I understand the image is not ready yet

Remove the ftp container

Remove the ftp container

We should be using the stable versions

We should be using the stable versions

Do we need that heavy logging in all of the services?

Do we need that heavy logging in all of the services?

Looks good, but the CHANGELOG is missing. This changes the logic of populating the modified date so it should be explained there

Looks good, but the CHANGELOG is missing. This changes the logic of populating the modified date so it should be explained there

Why? We explicitly created calculated stock on hands to avoid this

Why? We explicitly created calculated stock on hands to avoid this

Unnecessary implementation detail, but we can keep it

Unnecessary implementation detail, but we can keep it

Why do we still need manual recalculations?

Why do we still need manual recalculations?

Why aren't we using the calculated stocks on hand for this?

Why aren't we using the calculated stocks on hand for this?

small h

small h

We shouldn't be recalculating this - the current SoH should be calculated at this point since we use calculated SoHs. Also recalculating SoHs should be long gone from the Stock Mgmt module by now.

We shouldn't be recalculating this - the current SoH should be calculated at this point since we use calculated SoHs. Also recalculating SoHs should be long gone from the Stock Mgmt module by now.

We could use constants from MediaType for some of the above

We could use constants from MediaType for some of the above

Can we use traits so that the header definitions don't need to be repeated for each of the endpoits? (This might not be possible with the RAML version we use, but it's worth checking)

Can we use traits so that the header definitions don't need to be repeated for each of the endpoits? (This might not be possible with the RAML version we use, but it's worth checking)

Flyway is already mentioned in the first bullet point

Flyway is already mentioned in the first bullet point

have

have