Sebastian Brudziński

AO-77 Add support for new mapping - To object from file by...
AO-77 Add support for new mapping - To object from file by...
AO-77 Add test for new mapping type

We should verify with the requisition service, but it doesn't mean we shouldn't add to all of them. Thanks for doing so - I'd suggest adding the same to the template service, as it's expected that ...

We should verify with the requisition service, but it doesn't mean we shouldn't add to all of them. Thanks for doing so - I'd suggest adding the same to the template service, as it's expected that all services have this switched on.

Two questions: *Why was it only added to the requisition service? *It seems that for GET requests we will now be doing double compression (on the application server and on reverse proxy); any way...

Two questions:

  • Why was it only added to the requisition service?
  • It seems that for GET requests we will now be doing double compression (on the application server and on reverse proxy); any way to avoid that?
AO-77 Add support for seeding StockMgmt resources
AO-77 Add support for seeding StockMgmt resources
The * needs to go as well

The * needs to go as well

Why was this copied and pasted here from bug fixes?

Why was this copied and pasted here from bug fixes?

AO-77 Add support for new mapping - To object from file by...

Retrieve the requisitionGroup from the database, before you assert anything. This test will pass even if you delete the line that saves to the database, which makes no sense.

Retrieve the requisitionGroup from the database, before you assert anything. This test will pass even if you delete the line that saves to the database, which makes no sense.

On the other hand, even though you got 200 response, nothing was modified. I'd say it's not breaking.

On the other hand, even though you got 200 response, nothing was modified. I'd say it's not breaking.

AO-77 Add support for seeding StockMgmt resources

    • -0
    • +33
    /src/main/java/org/openlmis/upload/ValidDestinationService.java
    • -0
    • +34
    /src/main/java/org/openlmis/upload/ValidReasonService.java
    • -0
    • +33
    /src/main/java/org/openlmis/upload/ValidSourceService.java
Revert "OLMIS-5743 Clean workspace after each build"

This reverts commit b4d39ec46384f42a8c1b5b149fdcb94acc6e6f32.

OLMIS-5743 Clean workspace after each build

Moreover, why does this use "Containing"? If I create a role named "a", I won't be able to add any new role that also contains "a"

Moreover, why does this use "Containing"? If I create a role named "a", I won't be able to add any new role that also contains "a"

FEOLMIS-3541
We wanted the global view reports right to still grant access to ALL the reports

We wanted the global view reports right to still grant access to ALL the reports

Any reason we removed the auto-generated comment for reviewers?

Any reason we removed the auto-generated comment for reviewers?

The code looks good to me, but are we allowing to view all reports if I have one "VIew reports" global right?

The code looks good to me, but are we allowing to view all reports if I have one "VIew reports" global right?

View Consumption Report sounds fine.

View Consumption Report sounds fine.

Why are they called "manage reports", instead of just "view", like the generic "View reports" right.

Why are they called "manage reports", instead of just "view", like the generic "View reports" right.