Paweł Nawrocki

About
  • First commit 11 July 2016
  • Latest commit 28 July 2017
Last Week All Time
Commits: 0 722

Reviews

0 active reviews

Counts may include data that you cannot access.

Line History

Line history chart not available

Line history chart not available

 

Commit Activity

Commits By Day In Week
52 week commits volume
Commits By Day In Week
Commits by day
Commits By Day In Week
Commits by hour
Commits By Hour In Day
Commit calendar
 

Committer Mappings

Paweł Nawrocki is mapped to 57 committers over 35 repositories
Username pnawrocki is mapped to:
Monday 31 Jul 2017
9:53 pm

Paweł Nawrocki

3:31 pm

Paweł Nawrocki

3:31 pm

Paweł Nawrocki

looks good

looks good

3:30 pm

Paweł Nawrocki

LGTM

LGTM

3:29 pm

Paweł Nawrocki

2:21 pm

Paweł Nawrocki

Please make those class fields.

Please make those class fields.

2:20 pm

Paweł Nawrocki

Why is this test not in the same package as it's tested class?

Why is this test not in the same package as it's tested class?

1:21 pm

Paweł Nawrocki

1:00 pm

Paweł Nawrocki

Fixed

Fixed

12:07 pm

Paweł Nawrocki

OLMIS-2622: Display error and success messages for upload cce
OLMIS-2622: Display error and success messages for upload cce
10:32 am

Paweł Nawrocki

10:15 am

Paweł Nawrocki

10:15 am

Paweł Nawrocki

Looks good

Looks good

10:14 am

Paweł Nawrocki

9:32 am

Paweł Nawrocki

That would not run the validation for all line items matching physical inventory.

That would not run the validation for all line items matching physical inventory.

8:09 am

Paweł Nawrocki

OLMIS-2711: Fix for stockmanagement PI validations
OLMIS-2711: Fix for stockmanagement PI validations
Saturday 29 Jul 2017
1:35 pm

Paweł Nawrocki

Well, we can also have "day(s)", which I think is fair enough.

Well, we can also have "day(s)", which I think is fair enough.

Friday 28 Jul 2017
7:03 pm

Paweł Nawrocki

Once this is resolved, please commit the same to report service.

Once this is resolved, please commit the same to report service.

7:02 pm

Paweł Nawrocki

Does UI assume this being GET as default? If not, we should make it required, else we'd better document that somewhere (RAML?)

Does UI assume this being GET as default? If not, we should make it required, else we'd better document that somewhere (RAML?)

6:58 pm

Paweł Nawrocki

We could also add $ref

We could also add $ref

6:57 pm

Paweł Nawrocki

"InventoryItemDtoDto" - also could use link

"InventoryItemDtoDto" - also could use link

6:54 pm

Paweł Nawrocki

The "days" part would fit better into the messages_en into email body.

The "days" part would fit better into the messages_en into email body.

6:50 pm

Paweł Nawrocki

:copparrot:

:copparrot:

6:47 pm

Paweł Nawrocki

So, we're taking (SELECT): *each facility - it's code, name, and type *program names: each from active supported programs for the facility *assigned roles: each role having proper right (requisit...

So, we're taking (SELECT):

  • each facility - it's code, name, and type
  • program names: each from active supported programs for the facility
  • assigned roles: each role having proper right (requisition_view, requisition_delete, etc.) and supervisory node for the facility (recursive search for parent nodes) OR assigned user's home facility being the facility itself
  • supervisory nodes: parent nodes for facility (no recursive search)


Conditions (WHERE):

  • program assignment is active
  • count of users having assigned a role with required right for supervisory node containing the facility (also, searching parents and including home facilities) is equal to 0 (no assignments)
1:45 pm

Paweł Nawrocki

1:37 pm

Paweł Nawrocki

OLMIS-2760: Additional tests for service layer, fixed permission service tests

Options
    • -1
    • +1
    /src/main/java/org/openlmis/report/service/JasperTemplateService.java
    • -5
    • +65
    /src/test/java/org/openlmis/report/service/JasperTemplateServiceTest.java
    • -15
    • +1
    /src/test/java/org/openlmis/report/service/PermissionServiceTest.java
12:47 pm

Paweł Nawrocki

This might be an important part from reviewer's perspective

This might be an important part from reviewer's perspective

12:45 pm

Paweł Nawrocki

OLMIS-2760: Added report to report service, added report service to ui config
OLMIS-2760: Added report to report service, added report service to ui config
12:43 pm

Paweł Nawrocki

Paweł Albecki review updated

Paweł Albecki review updated

12:41 pm

Paweł Nawrocki

Added report service to REPORTING_SERVICES configuration

Options
    • -1
    • +2
    /config.json