Paweł Muchowski

Josh Zamor That's I meant in my comment we didn't get this error for packSize, because it is used in packsToOrder method. Can you tell me what is the purpose of this method?

6:54 pm

Paweł Muchowski

More
edab24d
changed 3 files
master, AO-379 and 41 more in openlmis-referencedata FEOLMIS-496

OLMIS-1242 FEOLMIS-496 Update calculation logic in OrderableProduct

- -3
- +16
/src/main/java/org/openlmis/referencedata/domain/OrderableProduct.java
- History
- Source
- Diff
/src/main/.../domain/OrderableProduct.java
- -1
- +3
/src/test/java/org/openlmis/referencedata/domain/GlobalProductTest.java
- History
- Source
- Diff
/src/test/.../domain/GlobalProductTest.java
- -1
- +3
/src/test/java/org/openlmis/referencedata/domain/TradeItemTest.java
- History
- Source
- Diff
/src/test/java/.../domain/TradeItemTest.java

12:12 pm

Paweł Muchowski

More
Re: FEOLMIS-496
replied to Paweł Gesek

It is used in packsToOrder method. I will add getters for those fields

11:19 am

Paweł Muchowski

More
Re: FEOLMIS-496
replied to Paweł Gesek

packSize don't have getter/setter methods, so I don't added it for those fields also

10:11 am

Paweł Muchowski

More
FEOLMIS-498
resumed reviewing

4:28 pm

Paweł Muchowski

More
79cd168
changed 1 file
master, OLMIS-1244 and 37 more in openlmis-requisition FEOLMIS-496

OLMIS-1242: Hide Packs To Ship field

- -14
- +14
/demo-data/requisition.columns_maps.json
- History
- Source
- Diff
/demo-data/requisition.columns_maps.json

2:45 pm

Paweł Muchowski

More
FEOLMIS-496
added Josh Zamor

2:44 pm

Paweł Muchowski

More
FEOLMIS-496
started review

OLMIS-1242: Add packRoundingThreshold and roundToZero fields to OrderableProduct

2:51 pm

Paweł Muchowski

More
f2a117c
changed 9 files
master, OLMIS-1244 and 37 more in openlmis-requisition FEOLMIS-496

OLMIS-1242: Add Packs to Ship calculation

- -1
- +34
/demo-data/requisition.columns_maps.json
- History
- Source
- Diff
/demo-data/requisition.columns_maps.json
- -1
- +4
/src/integration-test/java/org/openlmis/requisition/web/BaseWebIntegrationTest.java
- History
- Source
- Diff
/src/.../BaseWebIntegrationTest.java
- -0
- +5
/src/main/java/org/openlmis/requisition/domain/RequisitionLineItem.java
- History
- Source
- Diff
/src/main/.../domain/RequisitionLineItem.java
- -0
- +3
/src/main/java/org/openlmis/requisition/dto/OrderableProductDto.java
- History
- Source
- Diff
/src/main/.../dto/OrderableProductDto.java
- -0
- +50
/src/main/java/org/openlmis/requisition/service/RequisitionLineCalculationService.java
- History
- Source
- Diff
/src/.../RequisitionLineCalculationService.java
- -0
- +11
/src/main/java/org/openlmis/requisition/web/RequisitionController.java
- History
- Source
- Diff
/src/main/.../web/RequisitionController.java
- -0
- +2
/src/main/resources/bootstrap.sql
- History
- Source
- Diff
/src/main/resources/bootstrap.sql
- -0
- +122
/src/test/java/org/openlmis/requisition/service/RequisitionLineCalculationServiceTest.java
- History
- Source
- Diff
/src/.../RequisitionLineCalculationServiceTest.java
- -0
- +5
/src/test/java/org/openlmis/requisition/web/RequisitionControllerTest.java
- History
- Source
- Diff
/src/test/.../RequisitionControllerTest.java

5:13 pm

Paweł Muchowski

More
a8df255
changed 14 files
master, AO-379 and 41 more in openlmis-referencedata FEOLMIS-496

OLMIS-1242: Add packRoundingThreshold and roundToZero fields to OrderableProduct

- -0
- +20
/demo-data/referencedata.orderable_products.json
- History
- Source
- Diff
/demo-data/referencedata.orderable_products.json
- -1
- +1
/src/integration-test/java/org/openlmis/referencedata/repository/FacilityTypeApprovedProductRepositoryTest.java
- History
- Source
- Diff
/src/.../FacilityTypeApprovedProductRepositoryTest.java
- -1
- +1
/src/integration-test/java/org/openlmis/referencedata/repository/OrderableProductIntegrationTest.java
- History
- Source
- Diff
/src/.../OrderableProductIntegrationTest.java
- -2
- +2
/src/integration-test/java/org/openlmis/referencedata/repository/TradeItemRepositoryIntegrationTest.java
- History
- Source
- Diff
/src/.../TradeItemRepositoryIntegrationTest.java
- -1
- +1
/src/integration-test/java/org/openlmis/referencedata/web/FacilityTypeApprovedProductControllerIntegrationTest.java
- History
- Source
- Diff
/src/.../FacilityTypeApprovedProductControllerIntegrationTest.java
- -4
- +12
/src/main/java/org/openlmis/referencedata/domain/GlobalProduct.java
- History
- Source
- Diff
/src/main/java/.../domain/GlobalProduct.java
- -2
- +11
/src/main/java/org/openlmis/referencedata/domain/OrderableProduct.java
- History
- Source
- Diff
/src/main/.../domain/OrderableProduct.java
- -4
- +12
/src/main/java/org/openlmis/referencedata/domain/TradeItem.java
- History
- Source
- Diff
/src/main/java/.../domain/TradeItem.java
- -1
- +7
/src/main/resources/api-definition.yaml
- History
- Source
- Diff
/src/main/resources/api-definition.yaml
- -4
- +5
/src/test/java/org/openlmis/referencedata/domain/GlobalProductTest.java
- History
- Source
- Diff
/src/test/.../domain/GlobalProductTest.java
- -1
- +2
/src/test/java/org/openlmis/referencedata/domain/OrderableProductTest.java
- History
- Source
- Diff
/src/test/.../OrderableProductTest.java
- -1
- +1
/src/test/java/org/openlmis/referencedata/domain/ProgramProductBuilderTest.java
- History
- Source
- Diff
/src/test/.../ProgramProductBuilderTest.java
- -1
- +2
/src/test/java/org/openlmis/referencedata/domain/ProgramProductTest.java
- History
- Source
- Diff
/src/test/.../domain/ProgramProductTest.java
- -4
- +4
/src/test/java/org/openlmis/referencedata/domain/TradeItemTest.java
- History
- Source
- Diff
/src/test/java/.../domain/TradeItemTest.java

10:26 am

Paweł Muchowski

More
FEOLMIS-442
Closed

12:52 pm

Paweł Muchowski

I think this should be done when we will add some new export types in another ticket

12:40 pm

Paweł Muchowski

There was some issue with beginning balance set to null when it's not displayed, you will need to ask Paweł Gesek about this

2:37 pm

Paweł Muchowski

More
FEOLMIS-442
started review

OLMIS-1164: Rename the orders endpoint that exports CSV

Paweł Muchowski

About

Reviews

0 active reviews

Line History

Commit Activity

52 week commits volume

Commits by day

Commits by hour

Commit calendar

Committer Mappings

Paweł Muchowski is mapped to 14 committers over 14 repositories