Paweł Albecki

About
  • First commit 08 March 2017
  • Latest commit 11 May 2018
Last Week All Time
Commits: 0 1,733

Reviews

0 active reviews

Counts may include data that you cannot access.

Line History

Line history chart not available

Line history chart not available

 

Commit Activity

Commits By Day In Week
52 week commits volume
Commits By Day In Week
Commits by day
Commits By Day In Week
Commits by hour
Commits By Hour In Day
Commit calendar
 

Committer Mappings

Paweł Albecki is mapped to 34 committers over 34 repositories
Username palbecki is mapped to:
Tuesday 15 May 2018
6:38 am

Paweł Albecki

Monday 14 May 2018
6:50 am

Paweł Albecki

6:50 am

Paweł Albecki

Friday 11 May 2018
3:38 pm

Paweł Albecki

OLMIS-4706: clarify edge case

Options
    • -1
    • +1
    /src/main/resources/api-definition.yaml
3:18 pm

Paweł Albecki

OLMIS-4689: Fix Total Cost is not updated filled correctly
OLMIS-4689: Fix Total Cost is not updated filled correctly
3:14 pm

Paweł Albecki

OLMIS-4689: Fix Total Cost is not updated filled correctly

Options
    • -0
    • +1
    /CHANGELOG.md
    • -3
    • +8
    /src/requisition-calculations/calculation.factory.js
    • -1
    • +72
    /src/requisition-calculations/calculation.factory.spec.js
2:19 pm

Paweł Albecki

1:04 pm

Paweł Albecki

we shouldn't have need for testing logic in IT. If there are edge cases in IT that means we have in web layer business logic. We should test only API responses in controller ITs.

we shouldn't have need for testing logic in IT. If there are edge cases in IT that means we have in web layer business logic. We should test only API responses in controller ITs.

1:02 pm

Paweł Albecki

It should be in domain layer, in skip method or somethign like "canSkip"

It should be in domain layer, in skip method or somethign like "canSkip"

12:56 pm

Paweł Albecki

can you rename it to ApproveProductsAggregator or something? So responsibility of this class is clear

can you rename it to ApproveProductsAggregator or something? So responsibility of this class is clear

12:46 pm

Paweł Albecki

12:42 pm

Paweł Albecki

this should be handled in auth service probably? offlineNavigationInterceptor doesn't work for this case because route (full-supply that is a child) has isOffline flag set to true....

this should be handled in auth service probably? offlineNavigationInterceptor doesn't work for this case because route (full-supply that is a child) has isOffline flag set to true....

12:40 pm

Paweł Albecki

OLMIS-4509: fix redirect to 404 when proceed requisition while offline
OLMIS-4509: fix redirect to 404 when proceed requisition while offline
12:34 pm

Paweł Albecki

OLMIS-4509: fix redirect to 404 when proceed requisition while offline

Options
    • -0
    • +3
    /CHANGELOG.md
    • -2
    • +2
    /src/requisition-view/requisition-view.routes.js
10:59 am

Paweł Albecki

No, just curious

No, just curious

9:49 am

Paweł Albecki

9:48 am

Paweł Albecki

What are the objectives? Why code was moved? I think review title is misleading? It was not moved to controller layer but other service

What are the objectives? Why code was moved? I think review title is misleading? It was not moved to controller layer but other service

9:00 am

Paweł Albecki

We return null when there is no stock cards

We return null when there is no stock cards

Thursday 10 May 2018
3:51 pm

Paweł Albecki

2:50 pm

Paweł Albecki

OLMIS-4706: Design API for retrieving Stock out Days
OLMIS-4706: Design API for retrieving Stock out Days
2:48 pm

Paweł Albecki

OLMIS-4706: Design API for retrieving Stock out Days

Options
    • -0
    • +55
    /src/main/resources/api-definition.yaml
    • -0
    • +18
    /src/main/resources/schemas/stockOutDays.json
    • -0
    • +25
    /src/main/resources/schemas/stockOutDaysPage.json
10:50 am

Paweł Albecki

Maybe the following Whens should be changed to And?

Maybe the following Whens should be changed to And?

Wednesday 09 May 2018
2:28 pm

Paweł Albecki

12:49 pm

Paweł Albecki

12:49 pm

Paweł Albecki

right, we test this endpoint in Auth performance

right, we test this endpoint in Auth performance

11:38 am

Paweł Albecki

Can't we move it to separate file?

Can't we move it to separate file?

11:36 am

Paweł Albecki

+1

+1

Tuesday 08 May 2018
9:34 am

Paweł Albecki

Monday 07 May 2018
10:16 am

Paweł Albecki

Friday 04 May 2018
4:53 pm

Paweł Albecki

Needed to make ProgramOrderables a list because HashSet silently ignore duplicated programs in orderable but instead we should throw an error as ticket states

Needed to make ProgramOrderables a list because
HashSet silently ignore duplicated programs in
orderable but instead we should throw an error as ticket states