Nikodem Graczewski

About
  • This user has not yet committed.

Reviews

0 active reviews

Counts may include data that you cannot access.
Thursday 01 Aug 2019
7:37 am

Nikodem Graczewski

Wednesday 31 Jul 2019
12:25 pm

Nikodem Graczewski

Tuesday 30 Jul 2019
12:28 pm

Nikodem Graczewski

Add unit tests.

Add unit tests.

12:25 pm

Nikodem Graczewski

Any reason why are we using stateTrackerService instead of $state.go if we always want to go to the same state?

Any reason why are we using stateTrackerService instead of $state.go if we always want to go to the same state?

12:24 pm

Nikodem Graczewski

What is the purpose of this?

What is the purpose of this?

12:24 pm

Nikodem Graczewski

Add unit tests.

Add unit tests.

12:21 pm

Nikodem Graczewski

Fix typo in the filename.

Fix typo in the filename.

12:20 pm

Nikodem Graczewski

Nevermind, just fix the condition.

Nevermind, just fix the condition.

12:17 pm

Nikodem Graczewski

Could we move this to the controller?

Could we move this to the controller?

12:17 pm

Nikodem Graczewski

This will always be false.

This will always be false.

12:11 pm

Nikodem Graczewski

Use FunctionDecorator.withConfirmation once Klaudia Pałkowska has added it.

Use FunctionDecorator.withConfirmation once Klaudia Pałkowska has added it.

12:06 pm

Nikodem Graczewski

programOrderables

programOrderables

12:06 pm

Nikodem Graczewski

programOrderables

programOrderables

12:05 pm

Nikodem Graczewski

program orderables

program orderables

12:05 pm

Nikodem Graczewski

Same as above (but with resolve) and add an expect for the permissionService being called with correct parameters.

Same as above (but with resolve) and add an expect for the permissionService being called with correct parameters.

12:04 pm

Nikodem Graczewski

Simplify to this.permissionService.hasPermissionWithAnyProgramAndAnyFacility.andReturn(this.$q.reject());

Simplify to this.permissionService.hasPermissionWithAnyProgramAndAnyFacility.andReturn(this.$q.reject());

12:01 pm

Nikodem Graczewski

programOrderables*

programOrderables*

12:01 pm

Nikodem Graczewski

Can't we just move it to the controller?

Can't we just move it to the controller?

10:00 am

Nikodem Graczewski

10:00 am

Nikodem Graczewski

Missing unit tests.

Missing unit tests.

9:59 am

Nikodem Graczewski

MIssing JSDocs.

MIssing JSDocs.

9:58 am

Nikodem Graczewski

Nevermind.

Nevermind.

9:54 am

Nikodem Graczewski

Is this required if we only have single accessRight?

Is this required if we only have single accessRight?

9:54 am

Nikodem Graczewski

Missing JSDoc.

Missing JSDoc.

9:52 am

Nikodem Graczewski

FTAP or facility type approved products

FTAP or facility type approved products

9:51 am

Nikodem Graczewski

Could we add a "withConfirm" method to the FunctionDecorator?

Could we add a "withConfirm" method to the FunctionDecorator?

9:51 am

Nikodem Graczewski

Any reason why this is in a separate file? Are we reusing it somewhere?

Any reason why this is in a separate file? Are we reusing it somewhere?

9:47 am

Nikodem Graczewski

Could we make the save function accept an object and use .extend instead of updating the object by hand? This would be something like: .extend({}, result.content[0], vm.facilityTypeApprovedProduct)

Could we make the save function accept an object and use .extend instead of updating the object by hand? This would be something like:
.extend({}, result.content[0], vm.facilityTypeApprovedProduct)

9:44 am

Nikodem Graczewski

This could be a call to the goToFtapsList instead.

This could be a call to the goToFtapsList instead.

9:44 am

Nikodem Graczewski

This will not always return to the Ftaps list. Was there a requirement that we go back to the previous state instead of ftap list?

This will not always return to the Ftaps list. Was there a requirement that we go back to the previous state instead of ftap list?