Nikodem Graczewski

OLMIS-5837: Made View Requisitions screen accessible to partner users
OLMIS-5837: Made View Requisitions screen accessible to partner users
OLMIS-5837: Refactored requisition-search.routes.spec.js
OLMIS-5837: Refactored requisition-search.routes.spec.js
OLMIS-5837: Refactored permission.service.spec.js
OLMIS-5837: Refactored permission.service.spec.js
I was unable to make this core proof to such changes... https://review.openlmis.org/static/ogdo0b/2static/images/wiki/icons/emoticons/sad.gif

I was unable to make this core proof to such changes...

OLMIS-5837: Added the ability to check for right based on role assignment instead of permission...
OLMIS-5837: Added the ability to check for right based on role assignment instead of permission...
OLMIS-5837: Made View Requisitions screen accessible to partner users

OLMIS-5837: Added withRequisitionGroup to the SupervisoryNodeDataBuilder

Revert "OLMIS-5837: Extended the OpenlmisArrayDecorator with a pushAll, mapTo, filterOutUndefined and asArray methods"

This reverts commit dd51b0a007e610cbfe0ecfbb33148bda181ee7de.

OLMIS-5837: Extended the OpenlmisArrayDecorator with a pushAll, mapTo, filterOutUndefined and asArray methods

OLMIS-5976: Added missing dependency to the openlmis-main-state module

OLMIS-5837: Fixed a bug within permissionService resulting in invalid checks by role

Changelog for this already exists.

Changelog for this already exists.

OLMIS-5976: Moved the state resolve from home to the main state
OLMIS-5976: Moved the state resolve from home to the main state
OLMIS-5976: Moved the state resolve from home to the main state

But it feels inconsistent with the lines below doing a simple null check https://review.openlmis.org/static/ogdo0b/2static/images/wiki/icons/emoticons/sad.gif

But it feels inconsistent with the lines below doing a simple null check

OLMIS-5837: Refactored requisition-search.routes.spec.js

OLMIS-5837: Added the ability to check for right based on role assignment instead of permission strings

    • -0
    • +45
    /src/referencedata-role/role-resource.js
    • -0
    • +41
    /src/referencedata-role/role-resource.spec.js
OLMIS-5837: Refactored openlmis-permissions.run.spec.js

I know, but what benefit does using Objects.nonNull gives us over null != item.getSupervisoryNodeId() and null != item.getProgramId()?

I know, but what benefit does using Objects.nonNull gives us over null != item.getSupervisoryNodeId() and null != item.getProgramId()?