Nikodem Graczewski

Add unit tests.

Add unit tests.

Any reason why are we using stateTrackerService instead of $state.go if we always want to go to the same state?

Any reason why are we using stateTrackerService instead of $state.go if we always want to go to the same state?

What is the purpose of this?

What is the purpose of this?

Add unit tests.

Add unit tests.

Fix typo in the filename.

Fix typo in the filename.

Nevermind, just fix the condition.

Nevermind, just fix the condition.

Could we move this to the controller?

Could we move this to the controller?

This will always be false.

This will always be false.

Use FunctionDecorator.withConfirmation once Klaudia Pałkowska has added it.

Use FunctionDecorator.withConfirmation once Klaudia PaƂkowska has added it.

programOrderables

programOrderables

programOrderables

programOrderables

program orderables

program orderables

Same as above (but with resolve) and add an expect for the permissionService being called with correct parameters.

Same as above (but with resolve) and add an expect for the permissionService being called with correct parameters.

Simplify to this.permissionService.hasPermissionWithAnyProgramAndAnyFacility.andReturn(this.$q.reject());

Simplify to this.permissionService.hasPermissionWithAnyProgramAndAnyFacility.andReturn(this.$q.reject());

programOrderables*

programOrderables*

Can't we just move it to the controller?

Can't we just move it to the controller?

Missing unit tests.

Missing unit tests.

MIssing JSDocs.

MIssing JSDocs.

Nevermind.

Nevermind.

Is this required if we only have single accessRight?

Is this required if we only have single accessRight?

Missing JSDoc.

Missing JSDoc.

FTAP or facility type approved products

FTAP or facility type approved products

Could we add a "withConfirm" method to the FunctionDecorator?

Could we add a "withConfirm" method to the FunctionDecorator?

Any reason why this is in a separate file? Are we reusing it somewhere?

Any reason why this is in a separate file? Are we reusing it somewhere?

Could we make the save function accept an object and use .extend instead of updating the object by hand? This would be something like: .extend({}, result.content[0], vm.facilityTypeApprovedProduct)

Could we make the save function accept an object and use .extend instead of updating the object by hand? This would be something like:
.extend({}, result.content[0], vm.facilityTypeApprovedProduct)

This could be a call to the goToFtapsList instead.

This could be a call to the goToFtapsList instead.

This will not always return to the Ftaps list. Was there a requirement that we go back to the previous state instead of ftap list?

This will not always return to the Ftaps list. Was there a requirement that we go back to the previous state instead of ftap list?