Mateusz Kwiatkowski

About
  • First commit 21 November 2016
  • Latest commit 17 March 2020
Last Week All Time
Commits: 0 4,882

Reviews

0 active reviews

Counts may include data that you cannot access.

Line History

Line history chart not available

Line history chart not available

 

Commit Activity

Commits By Day In Week
52 week commits volume
Commits By Day In Week
Commits by day
Commits By Day In Week
Commits by hour
Commits By Hour In Day
Commit calendar
 

Committer Mappings

Mateusz Kwiatkowski is mapped to 38 committers over 38 repositories
Username mkwiatkowski is mapped to:
Friday 07 Feb 2020
1:08 pm

Mateusz Kwiatkowski

Tuesday 28 Jan 2020
4:41 pm

Mateusz Kwiatkowski

1:23 pm

Mateusz Kwiatkowski

Wednesday 22 Jan 2020
3:02 pm

Mateusz Kwiatkowski

I see that if a statement is located in StockCardSummariesService so it should be tested in this class as it should be done while writing unit tests. If you are testing it below it should be moved ...

I see that if a statement is located in StockCardSummariesService so it should be tested in this class as it should be done while writing unit tests. If you are testing it below it should be moved to another test method.

2:58 pm

Mateusz Kwiatkowski

I think it should have tests in the repository test class where you would test this method with different data and parameters. I don't see such tests. Sonar only says if code line is used while exe...

I think it should have tests in the repository test class where you would test this method with different data and parameters. I don't see such tests. Sonar only says if code line is used while executing tests, not if it is tested properly.

10:14 am

Mateusz Kwiatkowski

10:13 am

Mateusz Kwiatkowski

I'm not sure why there is no separate test to verify if empty startDate is handled properly

I'm not sure why there is no separate test to verify if empty startDate is handled properly

10:13 am

Mateusz Kwiatkowski

This requires some tests

This requires some tests

Thursday 03 Oct 2019
11:05 am

Mateusz Kwiatkowski

Wednesday 02 Oct 2019
1:40 pm

Mateusz Kwiatkowski

We are submitting physical inventory for day 1 with quantity 50, current SoH for day 1 is 10, after recalculation, it should be changed to 50. From those 2 numbers, we can calculate that the differ...

We are submitting physical inventory for day 1 with quantity 50, current SoH for day 1 is 10, after recalculation, it should be changed to 50. From those 2 numbers, we can calculate that the difference between old SoH and submitted physical inventory is +40. Then we need to update all following days with the difference calculated, so previously day 2 had SoH 20, now it is 60, day 3 had SoH 30, now it has 70.

Monday 16 Sep 2019
7:14 am

Mateusz Kwiatkowski

Friday 13 Sep 2019
2:30 pm

Mateusz Kwiatkowski

OLMIS-6483: fixed date filed name in migration script
OLMIS-6483: fixed date filed name in migration script
6:09 am

Mateusz Kwiatkowski

Thursday 12 Sep 2019
3:04 pm

Mateusz Kwiatkowski

OLMIS-6483: added calculating soh fact table for physical inventory
OLMIS-6483: added calculating soh fact table for physical inventory
8:58 am

Mateusz Kwiatkowski

8:54 am

Mateusz Kwiatkowski

OLMIS-6483: fixed updating calculated SOH with debit reasons
OLMIS-6483: fixed updating calculated SOH with debit reasons
Wednesday 11 Sep 2019
2:57 pm

Mateusz Kwiatkowski

Friday 23 Aug 2019
10:56 am

Mateusz Kwiatkowski

10:48 am

Mateusz Kwiatkowski

OLMIS-6530: Fixed problem with clearing freshly initiated requisition form after printing it
OLMIS-6530: Fixed problem with clearing freshly initiated requisition form after printing it
7:45 am

Mateusz Kwiatkowski

7:35 am

Mateusz Kwiatkowski

changed notification service version to 4.1.2-SNAPSHOT
changed notification service version to 4.1.2-SNAPSHOT
Tuesday 11 Jun 2019
10:36 am

Mateusz Kwiatkowski

Tuesday 16 Apr 2019
8:24 am

Mateusz Kwiatkowski

Monday 15 Apr 2019
8:43 am

Mateusz Kwiatkowski

Friday 12 Apr 2019
1:20 pm

Mateusz Kwiatkowski

1:20 pm

Mateusz Kwiatkowski

Thursday 11 Apr 2019
5:11 pm

Mateusz Kwiatkowski

OLMIS-6193: fixed translating stockout notifications
OLMIS-6193: fixed translating stockout notifications
Wednesday 10 Apr 2019
5:38 pm

Mateusz Kwiatkowski

As I mentioned on Slack while doing using a @Async new thread is losing context by default. We are getting locale info from LocaleContextHolder while translating messages so this was causing missin...

As I mentioned on Slack while doing using a @Async new thread is losing context by default. We are getting locale info from LocaleContextHolder while translating messages so this was causing missing translations for email notifications. Here is a GitHub issue regarding this problem: https://github.com/spring-projects/spring-boot/issues/14079
I think we are safe to use "dispatcherServlet.setThreadContextInheritable(true);" but Javadoc says:
/**

  • Set whether to expose the LocaleContext and RequestAttributes as inheritable
  • for child threads (using an
    Unknown macro: {@link java.lang.InheritableThreadLocal}

    ).

  • <p>Default is "false", to avoid side effects on spawned background threads.
  • Switch this to "true" to enable inheritance for custom child threads which
  • are spawned during request processing and only used for this request
  • (that is, ending after their initial task, without reuse of the thread).
  • <p><b>WARNING:</b> Do not use inheritance for child threads if you are
  • accessing a thread pool which is configured to potentially add new threads
  • on demand (e.g. a JDK
    Unknown macro: {@link java.util.concurrent.ThreadPoolExecutor}

    ),

  • since this will expose the inherited context to such a pooled thread.
    */
    Alternatively, we could retrieve locale before starting a new thread and passing it there, but it would require more work.
    I would be nice if we could agree on a solution quickly as it is blocking release and I still need to include it in patch release for Angola. Also, I would need to include those changes in other services that are sending notifications asynchronously.
5:30 pm

Mateusz Kwiatkowski

OLMIS-6193: added inheriting context to dispatcher servlet
OLMIS-6193: added inheriting context to dispatcher servlet
Friday 05 Apr 2019
9:40 am

Mateusz Kwiatkowski