Mateusz Kwiatkowski

OLMIS-5036: brought back performance requirements for tags endpoint

    • -1
    • +1
    /performance/tests/stockCardLineItemReasonTag.yml
what about maybe throwing an exception?

what about maybe throwing an exception?

OLMIS-5036: changed performance requirements for orderable endpoints

OLMIS-5036: disabled performance tests for shipments

    • -144
    • +144
    /performance/tests/shipment.yml
OLMIS-5036: lowered performance requirements for some tests

    • -1
    • +1
    /performance/tests/stockCardLineItemReason.yml
    • -1
    • +1
    /performance/tests/stockCardLineItemReasonTag.yml
    • -1
    • +1
    /performance/tests/stockCardRangeSummaries.yml
OLMIS-5036: lowered performance requirements for couple tests

Nice, can we have a simple test to verify it was fixed?

Nice, can we have a simple test to verify it was fixed?

updated reference-ui version for perftest

and why this is not a new String()?

and why this is not a new String()?

Good point, I forgot about removing products on this screen, resolving

Good point, I forgot about removing products on this screen, resolving

OLMIS-5036: fixed indentation in docker-compose.yml for perftest

If it fixes something we should have test to cover that if possible.

If it fixes something we should have test to cover that if possible.

Is this fixing anything? I see that functionality should not change after your changes.

Is this fixing anything? I see that functionality should not change after your changes.

Should this constructor have doc?

Should this constructor have doc?

how about some doc?

how about some doc?

1. I don't think this parameter is Integer type. rather a String type 2. this should be @param 3. add @return below with type Array 4. fix indentation as in other jsdocs so descriptions and paramet...

1. I don't think this parameter is Integer type. rather a String type
2. this should be @param
3. add @return below with type Array
4. fix indentation as in other jsdocs so descriptions and parameter names are aligned

I think that maybe you should do filtering (grouping) on entering the screen (i.e. in routes file) so you don't have to use memoize here

I think that maybe you should do filtering (grouping) on entering the screen (i.e. in routes file) so you don't have to use memoize here

please you remove '_' from this parameter name

please you remove '_' from this parameter name

OLMIS-4570: added functional test for initiating regular requisition
OLMIS-4570: added functional test for initiating regular requisition
OLMIS-4570: added functional test for initiating regular requisition

    • -0
    • +38
    /src/pages/requisition/initiate.requisition.page.js
I was thinking you were going to use feature flag here?

I was thinking you were going to use feature flag here?

I think this src value should be taken from some variable in controller or from some service or maybe constant?

I think this src value should be taken from some variable in controller or from some service or maybe constant?

is this required?

is this required?

then we use builders for regular classes and then exporting it to dto, alternatively we could have a method in builder class that builds dto object

then we use builders for regular classes and then exporting it to dto, alternatively we could have a method in builder class that builds dto object

is this changed in changelog?

is this changed in changelog?

is this changed in changelog?

is this changed in changelog?

is this changed in changelog?

is this changed in changelog?

what about ref-distro?

what about ref-distro?

was this changed in changelog?

was this changed in changelog?