Łukasz Lewczyński

what about line 51 in RequisitionTemplateService? From what I see we hide order related columns and we should probably don't do that for emergency requisitions

what about line 51 in RequisitionTemplateService? From what I see we hide order related columns and we should probably don't do that for emergency requisitions

Hey, I just see you and this is crazy but there is no changelog, so add one maybe https://review.openlmis.org/static/ogdo0b/2static/images/wiki/icons/emoticons/wink.gif

Hey, I just see you and this is crazy but there is no changelog, so add one maybe

I am not sure if message is correct. I mean it is exactly the same as one above

I am not sure if message is correct. I mean it is exactly the same as one above

changelog maybe?

changelog maybe?

what about zero?

what about zero?

OLMIS-5158: handle null value for important flag

OLMIS-5158: important messages ignore emailVerified flag
OLMIS-5158: important messages ignore emailVerified flag
OLMIS-5158: important messages ignore emailVerified flag

do we really need to execute method twice?

do we really need to execute method twice?

OLMIS-5144: added tests

I assume there is no changelog entry because this column has been added after 3.3?

I assume there is no changelog entry because this column has been added after 3.3?

OLMIS-5144: Fixed bug with formatting money values
OLMIS-5144: Fixed bug with formatting money values
OLMIS-5144: Fixed bug with formatting money values

I checked and it works. I did not know that we can use inner join in this way. I always thought that after ON we need to create a statement that would use at least one field from each table https:/...

I checked and it works. I did not know that we can use inner join in this way. I always thought that after ON we need to create a statement that would use at least one field from each table

OLMIS-5148: Adjusted the migration

I don't think there is a way to join those two columns also because I need to add the column to all templates I need the Cartesian product

I don't think there is a way to join those two columns also because I need to add the column to all templates I need the Cartesian product

cross join and join by comma are basically the same thing. Should I change it to the cross join?

cross join and join by comma are basically the same thing. Should I change it to the cross join?

OLMIS-5148: Extended migration to add column to all req templates
OLMIS-5148: Extended migration to add column to all req templates
OLMIS-5148: Extended migration to add column to all req templates

OLMIS-5141: fixed issue with changing null email to empty strings