Klaudia Pałkowska

Searching through the database by the indexed column is faster than without index.

Searching through the database by the indexed column is faster than without index.

OLMIS-6576: Updated migration to add indexes on orderableId and remove them at the end
OLMIS-6576: Updated migration to add indexes on orderableId and remove them at the end
Done.

Done.

Should I do this?

Should I do this?

Referencedata was the only service which has used wire mock in the version 2.22.0. In 1.58 the problem doesn't occur. The only thing that we could do is to move the wire mock to the testCompile sec...

Referencedata was the only service which has used wire mock in the version 2.22.0. In 1.58 the problem doesn't occur. The only thing that we could do is to move the wire mock to the testCompile section in dependencies (in fulfillment, stockmanagement, and report).

OLMIS-6564: Fixed responses compression in the referencedata service
OLMIS-6564: Fixed responses compression in the referencedata service
OLMIS-6569: Added json ignore to availableNonFullSupplyProductsIdentities
OLMIS-6569: Added json ignore to availableNonFullSupplyProductsIdentities
We can just ignore this error by: @SuppressWarnings("PMD.TooManyMethods");

We can just ignore this error by: @SuppressWarnings("PMD.TooManyMethods");

Please remove one of those changelogs (or merge them somehow).

Please remove one of those changelogs (or merge them somehow).

OLMIS-6438: Fixed issue with pagination on orderables screen
OLMIS-6438: Fixed issue with pagination on orderables screen
Could we merge those calls? I think we don't need the second one, we can simply return supervisory node object from the line 329.

Could we merge those calls? I think we don't need the second one, we can simply return supervisory node object from the line 329.

'3333' https://review.openlmis.org/static/ogdo0b/2static/images/wiki/icons/emoticons/wink.gif

'3333'

What do you think about renaming this to 'getByVersionIdentities'?

What do you think about renaming this to 'getByVersionIdentities'?

Could we rename this to 'promises'? I think it describes better what exactly the array contains.

Could we rename this to 'promises'? I think it describes better what exactly the array contains.

I'm not sure if it should be primary (blue) button or not.

I'm not sure if it should be primary (blue) button or not.

OLMIS-6438: Fixed searching for orderables on modal and in API console
OLMIS-6438: Fixed searching for orderables on modal and in API console
OLMIS-6222: Fixed issues with saving unpack kits
OLMIS-6222: Fixed issues with saving unpack kits
OLMIS-6488: Removed overriding OrderableResource
OLMIS-6488: Removed overriding OrderableResource
LGTM https://review.openlmis.org/static/ogdo0b/2static/images/wiki/icons/emoticons/smile.gif

LGTM