Klaudia Pałkowska

OLMIS-6691: Fixed issue with disappering products in emergency requisition
OLMIS-6691: Fixed issue with disappering products in emergency requisition
I think we don't need custom params and paginationId anymore.

I think we don't need custom params and paginationId anymore.

Whoops, copy-paste

Whoops, copy-paste

OLMIS-6684: Updated changelog entry
OLMIS-6684: Updated changelog entry
Please move it to the section for the current release.

Please move it to the section for the current release.

Please update changelog entry to be more general like "Added check whether the property exists before sorting array by given property.".

Please update changelog entry to be more general like "Added check whether the property exists before sorting array by given property.".

You could extract checks for column names to the first method, and then use this method + other two checks in the second method and use it in the if statement. Or something like that https://review...

You could extract checks for column names to the first method, and then use this method + other two checks in the second method and use it in the if statement. Or something like that

It looks like it isn't. Moreover, the whole findOrderablesWithLatestModifiedDate method is unnecessary.

It looks like it isn't. Moreover, the whole findOrderablesWithLatestModifiedDate method is unnecessary.

OLMIS-6566: Updated orderable search query
OLMIS-6566: Updated orderable search query
Please take a look at Sonar. It shows some issues and causes build failures.

Please take a look at Sonar. It shows some issues and causes build failures.

Why we need getQueryOrderableSearchParams method? Can't we just pass searchParams here as a parameter?

Why we need getQueryOrderableSearchParams method? Can't we just pass searchParams here as a parameter?

We shouldn't return date with hardcoded zone.

We shouldn't return date with hardcoded zone.

Please remove the comments.

Please remove the comments.

It was refactored to JPQL so I think we can use existing constants.

It was refactored to JPQL so I think we can use existing constants.

I think we wanted to get rid of native queries here. We can use JPQL like in other queries.

I think we wanted to get rid of native queries here. We can use JPQL like in other queries.

It should return ZonedDateTime.

It should return ZonedDateTime.