Wes Brown

About
  • This user has not yet committed.

Reviews

1 active review

Counts may include data that you cannot access.
Tuesday 21 May 2019
8:13 pm

Wes Brown

Are there other location types that we may need to consider? If so, would we want this description to be more general?

Are there other location types that we may need to consider? If so, would we want this description to be more general?

Friday 17 May 2019
8:45 pm

Wes Brown

Geographic

Geographic

8:45 pm

Wes Brown

Is it likely that an ERP system might be the source of truth for this kind of data, rather than OLMIS? I am thinking of a country that wants to use OpenLMIS primarily for the requisition process bu...

Is it likely that an ERP system might be the source of truth for this kind of data, rather than OLMIS? I am thinking of a country that wants to use OpenLMIS primarily for the requisition process but leverage an existing ERP system for inventory-related processes.

8:43 pm

Wes Brown

Would OpenLMIS be the source of truth for cce or would a monitoring system like NexLeaf?

Would OpenLMIS be the source of truth for cce or would a monitoring system like NexLeaf?

8:39 pm

Wes Brown

Is bearer tokens the only method that we want to support?

Is bearer tokens the only method that we want to support?

8:39 pm

Wes Brown

Also, if you add something about smart endpoints/dump pipes, including some detail about what that means in practice would be helpful as well.

Also, if you add something about smart endpoints/dump pipes, including some detail about what that means in practice would be helpful as well.

Friday 10 May 2019
9:02 am

Wes Brown

9:00 am

Wes Brown

9:00 am

Wes Brown

Given that this was due 9 weeks ago and the associated issue is already marked as Done, I'm going to close this review.

Given that this was due 9 weeks ago and the associated issue is already marked as Done, I'm going to close this review.

Monday 22 Oct 2018
7:12 am

Wes Brown

Wednesday 17 Oct 2018
8:33 pm

Wes Brown

Tuesday 16 Oct 2018
1:56 pm

Wes Brown

Tuesday 09 Oct 2018
11:01 am

Wes Brown

Thursday 04 Oct 2018
4:16 pm

Wes Brown

4:15 pm

Wes Brown

Thanks for the detailed explanation! I can understand why you chose composition over inheritance but wonder if it would be helpful to actually use both; define the ExtraDataEntity as you already do...

Thanks for the detailed explanation! I can understand why you chose composition over inheritance but wonder if it would be helpful to actually use both; define the ExtraDataEntity as you already do and then also define the BaseExtraDataEntity (or whatever) with the field and import/export logic already defined for the majority of the classes to use (except Orderable).

I am just looking for ways to reduce the duplication of the field and import/export logic in each domain class and this seems to provide that. I'm open to thoughts about whether this is worth the effort though.

Wednesday 03 Oct 2018
2:59 pm

Wes Brown

2:55 pm

Wes Brown

2:54 pm

Wes Brown

2:54 pm

Wes Brown

Is there a reason why this isn't being designed as a sub-class of `BaseEntity`? It seems more natural (from an Object Oriented design perspective) for domain objects to be inherit from a base class...

Is there a reason why this isn't being designed as a sub-class of `BaseEntity`? It seems more natural (from an Object Oriented design perspective) for domain objects to be inherit from a base class which contains the appropriate fields. In this case, I would expect that the concrete domain classes that include extra data would simply use this class as the base class.

Tuesday 02 Oct 2018
4:02 pm

Wes Brown

This extraData field is continuing to get used but the logic (limited as it is) is being copied by each domain/dto object. I think that a BaseEntity and BaseDto subclass should be created with the ...

This extraData field is continuing to get used but the logic (limited as it is) is being copied by each domain/dto object. I think that a BaseEntity and BaseDto subclass should be created with the extraData field and associated logic (import, export, etc) that domain/dto objects could inherit from instead of BaseEntity/BaseDto.

3:45 pm

Wes Brown

The properties defined in this interface don't seem to have anything specific to do with a FHIR resource and so the name of this interface seems misleading. This interface just represents an extens...

The properties defined in this interface don't seem to have anything specific to do with a FHIR resource and so the name of this interface seems misleading. This interface just represents an extensible (extendable?) entity, which is required for a FHIR resource but not specific to one.

3:39 pm

Wes Brown

This `extraData` design is in use in a few domain classes with identical annotations. Can this be abstracted into a base class that domain objects can inherit and not have to repeat the definition ...

This `extraData` design is in use in a few domain classes with identical annotations. Can this be abstracted into a base class that domain objects can inherit and not have to repeat the definition each time? Likewise, the importer and exporter interfaces could be extended to include this field.

Wednesday 26 Sep 2018
8:19 am

Wes Brown

Tuesday 25 Sep 2018
5:47 pm

Wes Brown

1:27 pm

Wes Brown

1:27 pm

Wes Brown

Are you expecting to reuse this method? It doesn't look like you are currently using it anywhere other than the synchronize method and I'm not sure there is value in moving this small code block to...

Are you expecting to reuse this method? It doesn't look like you are currently using it anywhere other than the synchronize method and I'm not sure there is value in moving this small code block to its own method.

1:23 pm

Wes Brown

1:22 pm

Wes Brown

I thought that we were going to look at sharing some of the common settings/configurations in the jenkins files. It seems unfortunate to have to update this for every service when the setting is th...

I thought that we were going to look at sharing some of the common settings/configurations in the jenkins files. It seems unfortunate to have to update this for every service when the setting is the same across them all.

Tuesday 28 Aug 2018
4:35 pm

Wes Brown

Monday 27 Aug 2018
11:45 pm

Wes Brown

Given this, I'm not going to dig too far into this.

Given this, I'm not going to dig too far into this.