Elly Makuba

About
  • This user has not yet committed.

Reviews

0 active reviews

Counts may include data that you cannot access.
Thursday 15 Jul 2021
5:37 am

Elly Makuba

Wednesday 14 Jul 2021
12:55 pm

Elly Makuba

I have made changes to handle a null initiator, plus I added a unit test case for that scenario.

I have made changes to handle a null initiator, plus I added a unit test case for that scenario.

Tuesday 13 Jul 2021
9:00 am

Elly Makuba

added content to unskipped requisition line items email
added content to unskipped requisition line items email
Thursday 24 Jun 2021
4:16 pm

Elly Makuba

Saturday 22 May 2021
7:48 am

Elly Makuba

added email notification for unskipped requisition line items
added email notification for unskipped requisition line items
7:01 am

Elly Makuba

6:55 am

Elly Makuba

6:54 am

Elly Makuba

Tuesday 11 May 2021
6:44 am

Elly Makuba

There are three object involved when updating a requisition, two requition domain objects and one requisition dto. The newRequisitionLineItem method in RequisitionLineItem class is building a new d...

There are three object involved when updating a requisition, two requition domain objects and one requisition dto. The newRequisitionLineItem method in RequisitionLineItem class is building a new domain object then populating it with values from the DTO. The design uses the newly created object to update an existing requisition retrieved from the db. There is one challenge though, creating a new requisition defaults the skipped value to false in newRequisitionLineItem method and if I don't check the status here before passing the dto value then it means an existing requisition can always be unskipped even after approval.

Friday 07 May 2021
7:17 pm

Elly Makuba

where do you suggest I put this?

where do you suggest I put this?

Wednesday 05 May 2021
1:21 pm

Elly Makuba

I have added this ; (!requisition.isApproved()) { if (requisitionLineItem.getSkipped() != null){ this.skipped = requisitionLineItem.getSkipped(); } else{ this.skipped = false; } } in Requisition...

I have added this ;
(!requisition.isApproved()) {
if (requisitionLineItem.getSkipped() != null)

Unknown macro: { this.skipped = requisitionLineItem.getSkipped(); }

else

Unknown macro: { this.skipped = false; }

}

in RequisitionLineItem class to only allow unskipping before approval status, that works for authorized status.

1:17 pm

Elly Makuba

I have corrected this, the shouldNotSetSkippedIfRequisitionStatusIsApproved mehtod is now working as expected.

I have corrected this, the shouldNotSetSkippedIfRequisitionStatusIsApproved mehtod is now working as expected.

Monday 03 May 2021
6:03 am

Elly Makuba

Only when AUTHORIZED, once approved there can never be changes.

Only when AUTHORIZED, once approved there can never be changes.

Monday 26 Apr 2021
10:17 am

Elly Makuba

Yes I made it configurable through an environment variable then added an end-point in RequisitionController class to fetch that value. The client will request the environment variable from the serv...

Yes I made it configurable through an environment variable then added an end-point in RequisitionController class to fetch that value. The client will request the environment variable from the server, when set to false the approver will not be able to unskip line items.

Friday 23 Apr 2021
12:50 pm

Elly Makuba

12:50 pm

Elly Makuba

12:27 pm

Elly Makuba

API changes to enable approver unskip requisition line items
API changes to enable approver unskip requisition line items
12:11 pm

Elly Makuba

UI changes to enable approver unskip requisition line items
UI changes to enable approver unskip requisition line items
Tuesday 30 Mar 2021
4:48 am

Elly Makuba

4:47 am

Elly Makuba

Monday 29 Mar 2021
4:38 pm

Elly Makuba

Noted.

Noted.

11:25 am

Elly Makuba

added file_columns table configs for tz-upgrade
added file_columns table configs for tz-upgrade
Thursday 25 Mar 2021
5:44 am

Elly Makuba

I have removed the two db migration scripts affecting file_columns table

I have removed the two db migration scripts affecting file_columns table

Thursday 18 Mar 2021
4:45 am

Elly Makuba

Noted.

Noted.

Tuesday 16 Mar 2021
5:51 am

Elly Makuba

I have not modified existing db script's content directly, but i have added new scripts that update the existing ones. In other words if you don't run my latest scripts then there will be no change...

I have not modified existing db script's content directly, but i have added new scripts that update the existing ones. In other words if you don't run my latest scripts then there will be no change to your db schema. I don't expect my changes to break an existing implementation, though if you include them in an upgrade you will have more columns in the generated csv and those columns will be ordered differently from the previous version.

Friday 12 Mar 2021
12:57 pm

Elly Makuba

I have removed price property from orderlineitem and included it in extradata property.

I have removed price property from orderlineitem and included it in extradata property.

Thursday 11 Mar 2021
2:06 pm

Elly Makuba

Wednesday 10 Mar 2021
6:47 am

Elly Makuba

I have added unit tests for the additional logic

I have added unit tests for the additional logic

6:02 am

Elly Makuba

There is this table file_columns containing configuration columns to be exported to csv.The current version of openlmis-fulfillment has a historic bootstrap migration script inserting columns in th...

There is this table file_columns containing configuration columns to be exported to csv.The current version of openlmis-fulfillment has a historic bootstrap migration script inserting columns in this table, but not in the sequence expected by elmis. So in one script i'm updating the position (order) these columns should appear and in another script i'm inserting additional columns to file_columns table.

Tuesday 09 Mar 2021
8:45 am

Elly Makuba

added extradata property to order class
added extradata property to order class