Chongsun Ahn

About
  • This user has not yet committed.

Reviews

3 active reviews

Counts may include data that you cannot access.
Monday 31 Oct 2022
1:14 pm

Chongsun Ahn

Monday 28 Mar 2022
8:07 am

Chongsun Ahn

Friday 18 Mar 2022
7:42 am

Chongsun Ahn

7:40 am

Chongsun Ahn

Tuesday 15 Mar 2022
8:58 pm

Chongsun Ahn

We seem to be missing a bunch of tests here.

We seem to be missing a bunch of tests here.

8:55 pm

Chongsun Ahn

If you have added the test, please add the code changes to this review, so I can review.

If you have added the test, please add the code changes to this review, so I can review.

8:55 pm

Chongsun Ahn

If you have added the test, please add the code changes to this review.

If you have added the test, please add the code changes to this review.

Tuesday 22 Feb 2022
9:30 pm

Chongsun Ahn

This name is not helpful to determine what this method does exactly.

This name is not helpful to determine what this method does exactly.

9:26 pm

Chongsun Ahn

It would be preferable to log things, rather than print out to system.

It would be preferable to log things, rather than print out to system.

Wednesday 09 Feb 2022
7:05 pm

Chongsun Ahn

Can you explain why these APIs are necessary? Why do we not just use the existing APIs?

Can you explain why these APIs are necessary? Why do we not just use the existing APIs?

Thursday 09 Dec 2021
10:01 pm

Chongsun Ahn

Wednesday 08 Dec 2021
6:45 am

Chongsun Ahn

Tuesday 07 Dec 2021
12:11 am

Chongsun Ahn

12:10 am

Chongsun Ahn

Where are the 404 Not Found tests for GET and DELETE /id?

Where are the 404 Not Found tests for GET and DELETE /id?

12:09 am

Chongsun Ahn

Why is program named first in this class name?

Why is program named first in this class name?

12:08 am

Chongsun Ahn

Are we sure we want to do this?

Are we sure we want to do this?

12:03 am

Chongsun Ahn

This seems very inefficient to make an API call for one orderable each time.

This seems very inefficient to make an API call for one orderable each time.

Monday 06 Dec 2021
11:51 pm

Chongsun Ahn

Where is the PUT 400 Bad Request test?

Where is the PUT 400 Bad Request test?

11:45 pm

Chongsun Ahn

Are we sure we want to allow this?

Are we sure we want to allow this?

11:45 pm

Chongsun Ahn

11:43 pm

Chongsun Ahn

So, there is no additional logic besides just creating the association between equipment and orderable?

So, there is no additional logic besides just creating the association between equipment and orderable?

11:39 pm

Chongsun Ahn

11:39 pm

Chongsun Ahn

We will create new tickets to address any issues with the transforms.

We will create new tickets to address any issues with the transforms.

11:38 pm

Chongsun Ahn

11:37 pm

Chongsun Ahn

11:34 pm

Chongsun Ahn

I don't see a GET /id test.

I don't see a GET /id test.

Monday 27 Sep 2021
9:11 am

Chongsun Ahn

8:50 am

Chongsun Ahn

Friday 24 Sep 2021
4:14 pm

Chongsun Ahn

Thursday 23 Sep 2021
4:51 pm

Chongsun Ahn