Chongsun Ahn

I would prefer to lowercase device, so it doesn't get confused with FHIR's Device.

I would prefer to lowercase device, so it doesn't get confused with FHIR's Device.

a part

a part

comes from

comes from

Datetimes

Datetimes

Would you be able to add something in here about smart endpoints and dumb pipes? I think it would be helpful.

Would you be able to add something in here about smart endpoints and dumb pipes? I think it would be helpful.

Done.

Done.

OLMIS-6186 Set cron trigger to use config time zone
OLMIS-6186 Set cron trigger to use config time zone
Done.

Done.

Done.

Done.

What about chained function calls, like moment.tz().format()?

What about chained function calls, like moment.tz().format()?

Can you point to some other code as an example? I had a hard enough time trying to get this test to work properly.

Can you point to some other code as an example? I had a hard enough time trying to get this test to work properly.

OLMIS-5913 Set selected facility from stateParams
OLMIS-5913 Set selected facility from stateParams
https://openlmis.atlassian.net/browse/OLMIS-6170

https://openlmis.atlassian.net/browse/OLMIS-6170

If we want to do this work, let's put it in another ticket, so this ticket doesn't drag on and not finish by the end of this sprint.

If we want to do this work, let's put it in another ticket, so this ticket doesn't drag on and not finish by the end of this sprint.

Also changed the currency filter in ui-components to use the new localeService.

Also changed the currency filter in ui-components to use the new localeService.

Done.

Done.

Reduced the duplication.

Reduced the duplication.

Done. Hopefully this is correct. Otherwise, I'm not sure how to go about implementing this.

Done. Hopefully this is correct. Otherwise, I'm not sure how to go about implementing this.

Then how do we catch in the locale cache code to call getLocaleSettingsFromConfig? Is there a good code example that shows this? I basically copied this from currency service.

Then how do we catch in the locale cache code to call getLocaleSettingsFromConfig? Is there a good code example that shows this? I basically copied this from currency service.

The whole datepicker format is confusing to me as well. Does it need to be different from the date format? And where is the documentation about its meaning, vs. the date formats?

The whole datepicker format is confusing to me as well. Does it need to be different from the date format? And where is the documentation about its meaning, vs. the date formats?

It may be a non-issue, as it looks like anything that would use datepicker would probably use business dates, which does not represent an instant in time, and so timezone would not be important. Ad...

It may be a non-issue, as it looks like anything that would use datepicker would probably use business dates, which does not represent an instant in time, and so timezone would not be important. Additionally, the datepicker directive does use the openlmis date filter.

Yes but the datepicker format is a separate setting, and not in the reference data. I suppose we could add it, but it wasn't done in the other tickets, so this ticket just followed what was done.

Yes but the datepicker format is a separate setting, and not in the reference data. I suppose we could add it, but it wasn't done in the other tickets, so this ticket just followed what was done.

Alright, I'll try to do the extra checking in the localeService.

Alright, I'll try to do the extra checking in the localeService.

Basically the changes here are just to get the filters to use settings from reference data, and then the defaults if those aren't found (and to support timezone in the filters). Since datepicker is...

Basically the changes here are just to get the filters to use settings from reference data, and then the defaults if those aren't found (and to support timezone in the filters). Since datepicker isn't a filter and it doesn't have a corresponding reference data setting, it doesn't seem to apply to the work here. It looks like datepicker format uses a different date format already, even before this ticket.

Update it how? It will already use dateFormat and timeZoneId from the locale settings if they are set, and there is no locale setting for a datepicker format from reference data.

Update it how? It will already use dateFormat and timeZoneId from the locale settings if they are set, and there is no locale setting for a datepicker format from reference data.

You don't think it's necessary to make an extra check here that locale settings are set with date format and timezone?

You don't think it's necessary to make an extra check here that locale settings are set with date format and timezone?