Chongsun Ahn

So this doesn't give the same result? SELECT t.id, a.id, a.definition, c.count + 1, a.indicator, false, a.label, a.name, NULL, 0, a.name, NULL FROM requisition.requisition_templates AS t INNER ...

So this doesn't give the same result?

SELECT
	t.id, a.id, a.definition, c.count + 1, a.indicator, false, a.label, a.name, NULL, 0, a.name, NULL
FROM
	requisition.requisition_templates AS t
	INNER JOIN (SELECT requisitiontemplateid, count(*) FROM requisition.columns_maps GROUP BY requisitiontemplateid) AS c ON c.requisitiontemplateid = t.id
	INNER JOIN requisition.available_requisition_columns AS a ON a.name = 'additionalQuantityRequired'


If not, feel free to resolve.

No, I mean we are creating a cross join, but I would prefer if it was made into an inner join with the 'additionalQuantityRequired' as part of the ON clause. I think it makes it more clear how they...

No, I mean we are creating a cross join, but I would prefer if it was made into an inner join with the 'additionalQuantityRequired' as part of the ON clause. I think it makes it more clear how they are being joined.

What kind of join is it when you join by comma? Isn't it a cross join, and not the way we want to join the tables?

What kind of join is it when you join by comma? Isn't it a cross join, and not the way we want to join the tables?

OLMIS-4982 Hide order columns from template when getting report-only requisition
OLMIS-4982 Hide order columns from template when getting report-only requisition
Well, hopefully you have analyzed the tests to make sure they are testing what the scenario says, and that the scenarios make sense to test as contract tests.

Well, hopefully you have analyzed the tests to make sure they are testing what the scenario says, and that the scenarios make sense to test as contract tests.

Typo: another

Typo: another

Sorry, we don't need to copy all CSV files. I meant that for any files that we have in the demo data image, we need to include all the "regular" demo data rows, as well as the "performance" data rows.

Sorry, we don't need to copy all CSV files. I meant that for any files that we have in the demo data image, we need to include all the "regular" demo data rows, as well as the "performance" data rows.

OLMIS-4871 Rename performance-data folder to demo-data
OLMIS-4871 Rename performance-data folder to demo-data
See my comment in the ticket. We need to include all data in the demo data CSV files; not just the "performance" data.

See my comment in the ticket. We need to include all data in the demo data CSV files; not just the "performance" data.

OLMIS-5084 Fix demo data image issues
OLMIS-5084 Fix demo data image issues
We could; I'm a bit hesitant to put or depend on too much logic in the DTOs, as I want them to be focused on storing data. But it should be fine as long as it stays in requisition; I wouldn't want ...

We could; I'm a bit hesitant to put or depend on too much logic in the DTOs, as I want them to be focused on storing data. But it should be fine as long as it stays in requisition; I wouldn't want it to be present in any other service.

Is it possible to use the job that uses the Jenkinsfile?

Is it possible to use the job that uses the Jenkinsfile?

This review can be closed w/o Josh reviewing.

This review can be closed w/o Josh reviewing.