Chongsun Ahn

OLMIS-5798 Add to changelog
OLMIS-5798 Add to changelog
Created, https://openlmis.atlassian.net/browse/OLMIS-5722. Resolving.

Created, https://openlmis.atlassian.net/browse/OLMIS-5722. Resolving.

What do we need to do to resolve this comment?

What do we need to do to resolve this comment?

Done.

Done.

Removed.

Removed.

This class is to help build supply partner objects.

This class is to help build supply partner objects.

We need name and code. What do we think is the best course of action for this? Create a new ticket to refactor? Or what kind of work should we do in this ticket?

We need name and code. What do we think is the best course of action for this? Create a new ticket to refactor? Or what kind of work should we do in this ticket?

Is there an example of this somewhere?

Is there an example of this somewhere?

Added.

Added.

Done.

Done.

Done.

Done.

The question I have is, do we have some sort of service where I can retrieve facilities that will give me the facilities I want (retrieve by multiple ids), either from the cache if it's cached, or ...

The question I have is, do we have some sort of service where I can retrieve facilities that will give me the facilities I want (retrieve by multiple ids), either from the cache if it's cached, or from the server, if it's not? Is there a pattern for this? That way, the UI can just use that and not have to think about where to get it from.

I'm sure there are some facility services/factories in the UI, but aren't they based on an old pattern? Basically I'm wondering how we would go about doing this.

I agree, making this expanding logic generic would be helpful. However, I would propose we have a separate ticket for it that establishes a pattern, as it might be a good amount of refactor work, a...

I agree, making this expanding logic generic would be helpful. However, I would propose we have a separate ticket for it that establishes a pattern, as it might be a good amount of refactor work, and I don't want to hold up this ticket for that.

OLMIS-5623 Add initial UI files
OLMIS-5623 Add initial UI files
I dealt with the unresolved issues in another ticket. I'm going to resolve and close this review for now. Please check in the review for 5623.

I dealt with the unresolved issues in another ticket. I'm going to resolve and close this review for now. Please check in the review for 5623.

I dealt with this in another ticket.

I dealt with this in another ticket.

I dealt with this in another ticket.

I dealt with this in another ticket.

I would prefer there be a separate user for the 'regular' requisition workflow. It would be better for demoing since there would be separate users in actual usage in Zambia.

I would prefer there be a separate user for the 'regular' requisition workflow. It would be better for demoing since there would be separate users in actual usage in Zambia.

Added.

Added.

Removed.

Removed.

Fixed.

Fixed.

Fixed.

Fixed.

Not sure what you mean. What should this be?

Not sure what you mean. What should this be?

Pagination I would assume.

Pagination I would assume.