Ben Leibert

About
  • First commit 11 May 2016
  • Latest commit 16 August 2019
Last Week All Time
Commits: 0 164

Reviews

0 active reviews

Counts may include data that you cannot access.

Line History

Line history chart not available

Line history chart not available

 

Commit Activity

Commits By Day In Week
52 week commits volume
Commits By Day In Week
Commits by day
Commits By Day In Week
Commits by hour
Commits By Hour In Day
Commit calendar
 

Committer Mappings

Ben Leibert is mapped to 25 committers over 25 repositories
Username ben.leibert is mapped to:
Friday 16 Aug 2019
8:25 pm

Ben Leibert

Updated dev image version

Options
    • -1
    • +1
    /docker-compose.builder.yml
    • -1
    • +1
    /docker-compose.yml
8:25 pm

Ben Leibert

Updated dev image version

Options
    • -1
    • +1
    /docker-compose.builder.yml
    • -1
    • +1
    /docker-compose.yml
Thursday 22 Mar 2018
11:48 pm

Ben Leibert

Add Superset slices to OpenLMIS

Embed locally served superset slices into OpenLMIS as a proof of concept.

Options
    • -0
    • +26
    /src/superset-reports/superset-reports.html
    • -0
    • +31
    /src/superset-reports/superset.reports.module.js
    • -0
    • +35
    /src/superset-reports/superset.reports.routes.js
Tuesday 20 Mar 2018
7:00 pm

Ben Leibert

5:03 am

Ben Leibert

5:03 am

Ben Leibert

5:03 am

Ben Leibert

Thank you very much, Chongsun Ahn. I added Mateusz Kwiatkowski to the review just incase we was able to get to it first. I don't think it needs two review, though, and will thus try marking this on...

Thank you very much, Chongsun Ahn. I added Mateusz Kwiatkowski to the review just incase we was able to get to it first. I don't think it needs two review, though, and will thus try marking this one as done.

12:57 am

Ben Leibert

Monday 19 Mar 2018
11:07 pm

Ben Leibert

OLMIS-3174: Remove obsolete reasonNotWorkingOrNotInUse values
OLMIS-3174: Remove obsolete reasonNotWorkingOrNotInUse values
11:04 pm

Ben Leibert

rtmAlerts.viewHistory was already part of this file.

rtmAlerts.viewHistory was already part of this file.

10:58 pm

Ben Leibert

OLMIS-3174: Remove unnecessary labels.

Options
    • -3
    • +0
    /src/cce-inventory-item-status/messages_en.json
    • -2
    • +2
    /src/cce-inventory-item-status/status-update-modal.controller.spec.js
10:58 pm

Ben Leibert

OLMIS-3174: Remove unnecessary labels.

Options
    • -3
    • +0
    /src/cce-inventory-item-status/messages_en.json
    • -2
    • +2
    /src/cce-inventory-item-status/status-update-modal.controller.spec.js
10:01 pm

Ben Leibert

Update the enum as per the requirements in OLMIS-3174.

Update the enum as per the requirements in OLMIS-3174.

10:01 pm

Ben Leibert

Update the enum as per the requirements in OLMIS-3174.

Update the enum as per the requirements in OLMIS-3174.

9:06 pm

Ben Leibert

OLMIS-3174: Remove obsolete reasonNotWorkingOrNotInUse values

Options
    • -11
    • +2
    /src/cce-inventory-item-status/reason-for-not-working.constant.js
    • -1
    • +1
    /src/cce-inventory-item-status/status-update-modal.controller.spec.js
    • -1
    • +1
    /src/cce-inventory-item/inventory-item-data-builder.spec.js
9:06 pm

Ben Leibert

OLMIS-3174: Remove obsolete reasonNotWorkingOrNotInUse values

Options
    • -11
    • +2
    /src/cce-inventory-item-status/reason-for-not-working.constant.js
    • -1
    • +1
    /src/cce-inventory-item-status/status-update-modal.controller.spec.js
    • -1
    • +1
    /src/cce-inventory-item/inventory-item-data-builder.spec.js
9:06 pm

Ben Leibert

OLMIS-3174: Remove obsolete reasonNotWorkingOrNotInUse values

Options
    • -65
    • +65
    /demo-data/cce.cce_inventory_items.json
    • -3
    • +0
    /src/main/java/org/openlmis/cce/domain/ReasonNotWorkingOrNotInUse.java
    • -1
    • +0
    /src/main/java/org/openlmis/cce/service/notifier/NonfunctionalCceNotifier.java
    • -3
    • +0
    /src/main/resources/schemas/inventoryItem.json
    • -1
    • +1
    /src/test/java/org/openlmis/cce/InventoryItemDataBuilder.java
    • -1
    • +0
    /src/test/java/org/openlmis/cce/service/notifier/NonfunctionalCceNotifierTest.java
9:06 pm

Ben Leibert

OLMIS-3174: Remove obsolete reasonNotWorkingOrNotInUse values

Options
    • -65
    • +65
    /demo-data/cce.cce_inventory_items.json
    • -3
    • +0
    /src/main/java/org/openlmis/cce/domain/ReasonNotWorkingOrNotInUse.java
    • -1
    • +0
    /src/main/java/org/openlmis/cce/service/notifier/NonfunctionalCceNotifier.java
    • -3
    • +0
    /src/main/resources/schemas/inventoryItem.json
    • -1
    • +1
    /src/test/java/org/openlmis/cce/InventoryItemDataBuilder.java
    • -1
    • +0
    /src/test/java/org/openlmis/cce/service/notifier/NonfunctionalCceNotifierTest.java
Saturday 10 Mar 2018
2:44 am

Ben Leibert

OLMIS-3543: Print the user's full name rather than login moniker.

Options
    • -1
    • +1
    /src/main/java/org/openlmis/fulfillment/service/JasperReportsViewService.java
Friday 09 Mar 2018
6:30 pm

Ben Leibert

Ah, I'd forgotten about that feature! I just added comments and appreciate your reminder - thank you.

Ah, I'd forgotten about that feature! I just added comments and appreciate your reminder - thank you.

6:29 pm

Ben Leibert

The use/need for AuthenticationHelper is described in the next comment within this review.

The use/need for AuthenticationHelper is described in the next comment within this review.

6:27 pm

Ben Leibert

The report originally displayed a redundant line comprised of several columns. The extra line was deemed unnecessary and each of the deletions following this comment corresponds to the removal of o...

The report originally displayed a redundant line comprised of several columns. The extra line was deemed unnecessary and each of the deletions following this comment corresponds to the removal of one of its columns.

6:26 pm

Ben Leibert

Display the name of the logged in user (which is passed in as a parameter).

Display the name of the logged in user (which is passed in as a parameter).

6:25 pm

Ben Leibert

Determine the name of the user currently logged in and add this to the set of parameters eventually used to render our report.

Determine the name of the user currently logged in and add this to the set of parameters eventually used to render our report.

6:09 pm

Ben Leibert

OLMIS-3543: Fix "printed by" lines
OLMIS-3543: Fix "printed by" lines
Wednesday 07 Mar 2018
7:03 pm

Ben Leibert

8:46 am

Ben Leibert

OLMIS-3174: Update the FUNCTIONAL_STATUS and REASON_FOR_NOT_WORKING enums

Options
    • -13
    • +13
    /src/cce-inventory-item-details/inventory-item-details.controller.spec.js
    • -10
    • +10
    /src/cce-inventory-item-status/functional-status.constant.js
    • -0
    • +2
    /src/cce-inventory-item-status/messages_en.json
    • -9
    • +7
    /src/cce-inventory-item-status/reason-for-not-working.constant.js
    • -5
    • +6
    /src/cce-inventory-item-status/status-update-modal.controller.js
    • -18
    • +16
    /src/cce-inventory-item-status/status-update-modal.controller.spec.js
    • -2
    • +2
    /src/cce-inventory-item-status/status-update-modal.html
    • -4
    • +3
    /src/cce-inventory-item-status/status.scss
    • -1
    • +1
    /src/facility-cce-status/facility-cce-status.scss
8:46 am

Ben Leibert

OLMIS-3174: Update the FUNCTIONAL_STATUS and REASON_FOR_NOT_WORKING enums

Options
    • -13
    • +13
    /src/cce-inventory-item-details/inventory-item-details.controller.spec.js
    • -10
    • +10
    /src/cce-inventory-item-status/functional-status.constant.js
    • -0
    • +2
    /src/cce-inventory-item-status/messages_en.json
    • -9
    • +7
    /src/cce-inventory-item-status/reason-for-not-working.constant.js
    • -5
    • +6
    /src/cce-inventory-item-status/status-update-modal.controller.js
    • -18
    • +16
    /src/cce-inventory-item-status/status-update-modal.controller.spec.js
    • -2
    • +2
    /src/cce-inventory-item-status/status-update-modal.html
    • -4
    • +3
    /src/cce-inventory-item-status/status.scss
    • -1
    • +1
    /src/facility-cce-status/facility-cce-status.scss
8:45 am

Ben Leibert

OLMIS-3174: Update the FunctionalStatus and ReasonNotWorkingOrNotInUse enums

Options
    • -4
    • +4
    /demo-data/README.md
    • -126
    • +126
    /demo-data/cce.cce_inventory_items.json
    • -2
    • +2
    /src/integration-test/java/org/openlmis/cce/repository/InventoryItemRepositoryIntegrationTest.java
    • -1
    • +1
    /src/integration-test/java/org/openlmis/cce/web/InventoryItemControllerIntegrationTest.java
    • -2
    • +2
    /src/main/java/org/openlmis/cce/domain/FunctionalStatus.java
    • -0
    • +2
    /src/main/java/org/openlmis/cce/domain/ReasonNotWorkingOrNotInUse.java
    • -1
    • +1
    /src/main/java/org/openlmis/cce/service/InventoryStatusProcessor.java
    • -0
    • +1
    /src/main/java/org/openlmis/cce/service/notifier/NonfunctionalCceNotifier.java
    • -2
    • +2
    /src/main/java/org/openlmis/cce/web/validator/InventoryItemValidator.java
    • -2
    • +2
    /src/main/resources/api-definition.yaml
    • -2
    • +2
    /src/main/resources/db/performance-data/schemas/inventoryItems.schema.json
    • -1
    • +1
    /src/main/resources/messages_en.properties
    • -3
    • +5
    /src/main/resources/schemas/inventoryItem.json
    • -3
    • +3
    /src/test/java/org/openlmis/cce/InventoryItemDataBuilder.java
    • -3
    • +3
    /src/test/java/org/openlmis/cce/domain/InventoryItemTest.java
  16. … 3 more files in changeset.
8:45 am

Ben Leibert

OLMIS-3174: Update the FunctionalStatus and ReasonNotWorkingOrNotInUse enums

Options
    • -4
    • +4
    /demo-data/README.md
    • -126
    • +126
    /demo-data/cce.cce_inventory_items.json
    • -2
    • +2
    /src/integration-test/java/org/openlmis/cce/repository/InventoryItemRepositoryIntegrationTest.java
    • -1
    • +1
    /src/integration-test/java/org/openlmis/cce/web/InventoryItemControllerIntegrationTest.java
    • -2
    • +2
    /src/main/java/org/openlmis/cce/domain/FunctionalStatus.java
    • -0
    • +2
    /src/main/java/org/openlmis/cce/domain/ReasonNotWorkingOrNotInUse.java
    • -1
    • +1
    /src/main/java/org/openlmis/cce/service/InventoryStatusProcessor.java
    • -0
    • +1
    /src/main/java/org/openlmis/cce/service/notifier/NonfunctionalCceNotifier.java
    • -2
    • +2
    /src/main/java/org/openlmis/cce/web/validator/InventoryItemValidator.java
    • -2
    • +2
    /src/main/resources/api-definition.yaml
    • -2
    • +2
    /src/main/resources/db/performance-data/schemas/inventoryItems.schema.json
    • -1
    • +1
    /src/main/resources/messages_en.properties
    • -3
    • +5
    /src/main/resources/schemas/inventoryItem.json
    • -3
    • +3
    /src/test/java/org/openlmis/cce/InventoryItemDataBuilder.java
    • -3
    • +3
    /src/test/java/org/openlmis/cce/domain/InventoryItemTest.java
  16. … 3 more files in changeset.