Adugna Worku

About
  • First commit 31 May 2018
  • Latest commit 16 April 2019
Last Week All Time
Commits: 0 61

Reviews

0 active reviews

Counts may include data that you cannot access.

Line History

Line history chart not available

Line history chart not available

 

Commit Activity

Commits By Day In Week
52 week commits volume
Commits By Day In Week
Commits by day
Commits By Day In Week
Commits by hour
Commits By Hour In Day
Commit calendar
 

Committer Mappings

Adugna Worku is mapped to 12 committers over 12 repositories
Username adugna is mapped to:
Tuesday 16 Apr 2019
8:51 am

Adugna Worku

Revert "Improved a test spec for product view"

This reverts commit db49249f7fccfc48f71e925bdbdbe862d6973778.

Options
    • -2
    • +1
    /src/admin-product-view/admin-product-view.module.js
    • -43
    • +34
    /src/admin-product-view/admin-product-view.routes.spec.js
    • -2
    • +2
    /src/admin-product-view/messages_en.json
    • -10
    • +10
    /src/admin-product-view/product-view.controller.js
    • -6
    • +8
    /src/admin-product-view/product-view.controller.spec.js
    • -3
    • +3
    /src/admin-product-view/product-view.html
8:23 am

Adugna Worku

Improved a test spec for product view

Options
    • -1
    • +2
    /src/admin-product-view/admin-product-view.module.js
    • -34
    • +43
    /src/admin-product-view/admin-product-view.routes.spec.js
    • -2
    • +2
    /src/admin-product-view/messages_en.json
    • -10
    • +10
    /src/admin-product-view/product-view.controller.js
    • -8
    • +6
    /src/admin-product-view/product-view.controller.spec.js
    • -3
    • +3
    /src/admin-product-view/product-view.html
Monday 15 Apr 2019
10:29 am

Adugna Worku

9:03 am

Adugna Worku

I would prefer the original way

I would prefer the original way

8:40 am

Adugna Worku

Nikodem Graczewski There is something tricky here. Array.prototype.flatMap() works on chrome version >=69 Unfortunately my virtual machine Chrome version is 66. And flatMap is not supported. That...

Nikodem Graczewski There is something tricky here.

Array.prototype.flatMap() works on chrome version >=69

Unfortunately my virtual machine Chrome version is 66. And flatMap is not supported. That was the reason i was saying its not working.

https://developer.mozilla.org/en-US/docs/Web/JavaScript/Reference/Global_Objects/Array/flatMap

So changing to flatMap won't that create a problem?

8:31 am

Adugna Worku

// Real lineItem JSON objectvar lineItems =[{"$errors":{"quantityInvalid":false,"occurredDateInvalid":false},"$previewSOH":99,"stockCard":{"id":"e4cd8e1a-8f3c-48d4-891c-fa5160832005","href":"https:...
// Real lineItem JSON object
var lineItems =[{"$errors":{"quantityInvalid":false,"occurredDateInvalid":false},"$previewSOH":99,"stockCard":{"id":"e4cd8e1a-8f3c-48d4-891c-fa5160832005","href":"https://uat.openlmis.org/api/stockCards/e4cd8e1a-8f3c-48d4-891c-fa5160832005"},"orderable":{"productCode":"C118","dispensable":{"dispensingUnit":"10 tab strip","displayUnit":"10 tab strip"},"fullProductName":"Stomachica","description":"Product description goes here.","netContent":1,"packRoundingThreshold":0,"roundToZero":false,"programs":[{"programId":"dce17f2e-af3e-40ad-8e00-3496adef44c3","orderableDisplayCategoryId":"15b8ef1f-a5d6-42dd-95bf-bb68a4504e82","orderableCategoryDisplayName":"Oral contraceptive","orderableCategoryDisplayOrder":6,"active":true,"fullSupply":true,"displayOrder":3,"dosesPerPatient":1,"pricePerPack":5.1}],"children":[{"orderable":{"id":"25665e10-cca7-44c0-b508-e95600d8fb99"},"quantity":10},{"orderable":{"id":"d4dbd20e-8ce2-480e-a019-4a90d115719c"},"quantity":20}],"identifiers":{},"extraData":{},"meta":{"lastUpdated":"2019-04-15T00:55:18.564Z[GMT]","versionId":"2"},"id":"0dc9c1ad-2266-4fb3-ad74-993c38b8c28a"},"lot":null,"stockOnHand":99,"processedDate":"2019-04-15T00:57:46.158Z","occurredDate":"2019-04-15","displayLotMessage":"Product has no lots","reason":{"name":"Unpack Kit","description":null,"reasonType":"DEBIT","reasonCategory":"AGGREGATION","isFreeTextAllowed":false,"tags":["consumed"],"id":"9b4b653a-f319-4a1b-bb80-8d6b4dd6cc12","creditReasonType":false,"debitReasonType":true,"adjustmentReasonCategory":false},"reasonFreeText":null,"quantity":2}];

lineItems.flatMap(function(lineItem) {
    return lineItem.orderable.children.map(function(constituent) {
        return _.extend({}, constituent, {
            reason: creditReason,
            occurredDate: lineItem.occurredDate,
            quantity: lineItem.quantity * constituent.quantity
        });
    })
});
8:26 am

Adugna Worku

OLMIS-6113 : Create UI for kit unpacking in stock management
OLMIS-6113 : Create UI for kit unpacking in stock management
1:08 am

Adugna Worku

This doesn't return object in a desired format. I will stick with the existing implementation

This doesn't return object in a desired format. I will stick with the existing implementation

12:59 am

Adugna Worku

Kits unpacking increased test coverage and solve sonar issue

Options
    • -9
    • +53
    /src/stock-adjustment-creation/adjustment-creation.controller.spec.js
    • -0
    • +28
    /src/stock-orderable-group/orderable-group.service.js
    • -0
    • +29
    /src/stock-orderable-group/orderable-group.service.spec.js
    • -1
    • +2
    /src/stock-unpack-kit-creation/unpack-kit-creation.module.js
    • -28
    • +23
    /src/stock-unpack-kit-creation/unpack-kit-creation.routes.js
    • -66
    • +60
    /src/stock-unpack-kit-creation/unpack-kit-creation.routes.spec.js
    • -43
    • +48
    /src/stock-unpack-kit/stock-kit-unpack.routes.spec.js
Friday 12 Apr 2019
1:12 pm

Adugna Worku

What do i update in reference-ui to be precise?

What do i update in reference-ui to be precise?

1:06 pm

Adugna Worku

OLMIS-6113: Added a review comments

Options
    • -23
    • +26
    /src/stock-adjustment-creation/adjustment-creation.controller.js
    • -2
    • +5
    /src/stock-constants/reason-categories.constant.js
    • -1
    • +7
    /src/stock-constants/reason-categories.constant.spec.js
    • -10
    • +9
    /src/stock-reason/stock-reasons.factory.js
    • -74
    • +73
    /src/stock-reason/stock-reasons.factory.spec.js
    • -5
    • +2
    /src/stock-unpack-kit-creation/messages_en.json
    • -3
    • +3
    /src/stock-unpack-kit-creation/unpack-kit-creation.routes.js
10:22 am

Adugna Worku

The message is correct but the key can't be changed this time, since Issue, Receive and Upack share similar keys for the message since they use the same html template

The message is correct but the key can't be changed this time, since Issue, Receive and Upack share similar keys for the message since they use the same html template

10:22 am

Adugna Worku

The message is correct but the key can't be changed this time, since Issue, Receive and Upack share similar keys for the message since they use the same html template

The message is correct but the key can't be changed this time, since Issue, Receive and Upack share similar keys for the message since they use the same html template

10:20 am

Adugna Worku

The message is correct but the key can't be changed this time, since Issue, Receive and Upack share similar keys for the message since they use the same html template

The message is correct but the key can't be changed this time, since Issue, Receive and Upack share similar keys for the message since they use the same html template

10:12 am

Adugna Worku

ditto

ditto

10:11 am

Adugna Worku

Issue, receive and unpack pages uses a single html view but separate message files. The prefix of the message key is up-to the page that will be rendered but the suffix is already hard coded in the...

Issue, receive and unpack pages uses a single html view but separate message files. The prefix of the message key is up-to the page that will be rendered but the suffix is already hard coded in the html file.

So in this case the message value is appropriate but the key is not. changing the key required all the message to be changed in the other modules also. So this implementation shall be refactored for the future but till then the html file is our guide.

Take a look at stock-adjustment/stock-adjustment.html

8:50 am

Adugna Worku

Sure

Sure

7:03 am

Adugna Worku

This piece of code will return a random reason No. when the unpack reason view loaded, take a look at unpack-kit-creation.routes.js line 78. Method returns ONLY two reasons of type AGGREGATION. T...

This piece of code will return a random reason


No. when the unpack reason view loaded, take a look at unpack-kit-creation.routes.js line 78. Method returns ONLY two reasons of type AGGREGATION. They are -
1. Kit Unpack (DEBIT)
2. Unpacked From Kit (CREDIT).

So we will use Unpacked From Kit (CREDIT) reason for the constituent line item

1:03 am

Adugna Worku

Thursday 11 Apr 2019
7:41 pm

Adugna Worku

Testing a nested child state with the $location.url(url) is not working and doesn't return the proper state object. Example:- lets say openlmis.stockmanagement.kitunpack is a parent state and open...

Testing a nested child state with the $location.url(url) is not working and doesn't return the proper state object.

Example:-
lets say openlmis.stockmanagement.kitunpack is a parent state and openlmis.stockmanagement.kitunpack.creation is a child state. Using $location.url(url) to change the view with the route URL for the parent state works well. $state object will be returned filled with proper values.

But following the same way for the child state, it yields an empty $state. I have researched before and also used $state.go(''state name') which doesn't work
and $state.current object will be empty. I could't find a reference spec in our repos. I will try to figure out how to test child state but please advice if there is any reference in our repos.

6:33 pm

Adugna Worku

I didn't understood well what you mean by "Facility Return" but we need the CREDIT type reason here. During unpacking, the Kit will be DEBITED from SOH and Kit constituents SOH amount will be CREDI...

I didn't understood well what you mean by "Facility Return" but we need the CREDIT type reason here. During unpacking, the Kit will be DEBITED from SOH and Kit constituents SOH amount will be CREDITED. Kit line item comes from the UI and constituent line item will be generated here with reason type CREDIT.

6:32 pm

Adugna Worku

I am not sure how we can use it here. But her we want to generate new Array objects by accessing a second level depth array of other object with our reducing anything. You can advise me on this.

I am not sure how we can use it here.

But her we want to generate new Array objects by accessing a second level depth array of other object with our reducing anything.

You can advise me on this.

6:12 pm

Adugna Worku

adjustment-creation.controller is shared by - Issue, Receive and Unpack pages. the current method will be executed when the operation is kit unpacking. N.B During unpacking, the user just add the ...

adjustment-creation.controller is shared by - Issue, Receive and Unpack pages. the current method will be executed when the operation is kit unpacking.

N.B During unpacking, the user just add the kit as a line item on the view (table) and since we know the corresponding constituents we generate them behind the scene among with a proper unpacked quantity for each constituent when we finally submit the data.

6:02 pm

Adugna Worku

vm.addedLineItem is an object Which is bound with the table in the view. If the data transformation, generating kit constituents, is done on this object unnecessary and confusing change will be dis...

vm.addedLineItem is an object Which is bound with the table in the view. If the data transformation, generating kit constituents, is done on this object unnecessary and confusing change will be displayed in the view.

Tuesday 09 Apr 2019
9:56 pm

Adugna Worku

Fix linting errors

Options
    • -0
    • +1
    /CHANGELOG.md
    • -1
    • +1
    /src/stock-reason/stock-reasons.factory.spec.js
    • -1
    • +1
    /src/stock-unpack-kit-creation/unpack-kit-creation.routes.spec.js
9:37 pm

Adugna Worku

OLMIS-6113 : Create UI for kit unpacking in stock management

Options
    • -2
    • +31
    /src/stock-adjustment-creation/adjustment-creation.controller.js
    • -0
    • +4
    /src/stock-adjustment/stock-adjustment-type.constant.js
    • -1
    • +24
    /src/stock-reason/stock-reasons.factory.js
    • -2
    • +49
    /src/stock-reason/stock-reasons.factory.spec.js
    • -0
    • +34
    /src/stock-unpack-kit-creation/messages_en.json
    • -0
    • +28
    /src/stock-unpack-kit-creation/unpack-kit-creation.module.js
    • -0
    • +91
    /src/stock-unpack-kit-creation/unpack-kit-creation.routes.js
    • -0
    • +168
    /src/stock-unpack-kit-creation/unpack-kit-creation.routes.spec.js
    • -0
    • +8
    /src/stock-unpack-kit/messages_en.json
    • -0
    • +31
    /src/stock-unpack-kit/stock-kit-unpack.module.js
    • -0
    • +55
    /src/stock-unpack-kit/stock-kit-unpack.routes.js
    • -0
    • +112
    /src/stock-unpack-kit/stock-kit-unpack.routes.spec.js
Tuesday 02 Apr 2019
12:45 pm

Adugna Worku

Do we have an example implementation in our repo? Pls point me if so not sure how to implement this.

Do we have an example implementation in our repo? Pls point me if so not sure how to implement this.

12:31 pm

Adugna Worku

OLMIS-6052 : Bug fix. Added pagination on kits section

Options
    • -3
    • +0
    /CHANGELOG.md
    • -1
    • +3
    /src/admin-product-view/admin-product-view.module.js
    • -12
    • +18
    /src/admin-product-view/admin-product-view.routes.js
    • -0
    • +135
    /src/admin-product-view/admin-product-view.routes.spec.js
    • -8
    • +8
    /src/admin-product-view/messages_en.json
    • -16
    • +26
    /src/admin-product-view/product-view.controller.js
    • -18
    • +11
    /src/admin-product-view/product-view.controller.spec.js
    • -16
    • +17
    /src/admin-product-view/product-view.html
Wednesday 27 Mar 2019
11:34 am

Adugna Worku

The reason is as i have illustrated below. Push adds the second argument (array) in to the first one as a single element. But when push.apply is used each element of the array we want to append wil...

The reason is as i have illustrated below. Push adds the second argument (array) in to the first one as a single element. But when push.apply is used each element of the array we want to append will be added individually. Performance wise its better that `Array.prototype.concat`
a = [a, b];
b = [c,d];

a.push(a, b); // [a, b, [c,d] ];
a.push.apply(a,b) // [a,b,c,d];

11:02 am

Adugna Worku

OLMIS-6052 : apply review comments

Options
    • -1
    • +5
    /CHANGELOG.md
    • -13
    • +15
    /src/admin-product-view/admin-product-view.routes.js
    • -6
    • +5
    /src/admin-product-view/messages_en.json
    • -54
    • +15
    /src/admin-product-view/product-view.controller.js
    • -4
    • +4
    /src/admin-product-view/product-view.controller.spec.js
    • -10
    • +10
    /src/admin-product-view/product-view.html