FEOLMIS OpenLMIS

10:03 pm

Chongsun Ahn

I think Nifi seems to normally take a while to finish starting. Seems like things are getting updated properly, as there would be errors in the process groups if things were not.

9:42 pm

Philip Garrison

More
Re: FEOLMIS-3952
replied to Chongsun Ahn

Let's see... if you run the pipeline (locally) from e70d5c2 and watch the logs for the nifi container, you should see it takes quite a while and maybe has error messages like "<something> cannot be...

Let's see... if you run the pipeline (locally) from e70d5c2 and watch the logs for the nifi container, you should see it takes quite a while and maybe has error messages like "<something> cannot be updated because it is not disabled"

9:14 pm

Chongsun Ahn

Yes, I was quite pleased to see that the Nifi docker image had it included. Interesting, how can I recreate the issue you were having in order to support some basic error paths?

Yes, I was quite pleased to see that the Nifi docker image had it included.

Interesting, how can I recreate the issue you were having in order to support some basic error paths?

9:09 pm

Philip Garrison

More
Re: FEOLMIS-3952
commented on review

Yes, I read through the script there; was happy to learn about xmlstarlet. When I accidentally uploaded all the templates without the containing process groups, it took super long to upload: lots o...

Yes, I read through the script there; was happy to learn about xmlstarlet.
When I accidentally uploaded all the templates without the containing process groups, it took super long to upload: lots of retrying due to maybe conflicting processors. Not sure if that's something we can avoid here, especially since it doesn't look like this script does any retrying.

8:58 pm

Chongsun Ahn

More
Re: FEOLMIS-3952
commented on review

The review is mainly for any code smells in the preload.sh script. If you don't see any issues there, I can close this review.

7:20 pm

Philip Garrison

More
FEOLMIS-3952
finished reviewing

7:18 pm

Philip Garrison

More
Re: FEOLMIS-3952
commented on review

Pipeline seems to be working, and it did successfully upload templates.

3:59 pm

Chongsun Ahn

More
FEOLMIS-3952
started review

OLMIS-6481 Load process groups from templates, not registry

2:24 pm

Sebastian Brudziński and Paulina Mironiuk

More
FEOLMIS-3950
finished reviewing

11:23 am

Sebastian Brudziński

More
Re: FEOLMIS-3950
commented on review

Let's not send another request just to verify the headers. We can re-use response from the previous call.

8:26 am

Sebastian Brudziński

More
Re: FEOLMIS-3950
commented on review

Let's not introduce another test just to verify the header. We can do the additional check in existing tests.

2:18 pm

Paweł Pinker

I debugged it and I can confirm that. I removed that line from those tests and I'm looking for new way to test it - either inside those methods or separately.

10:58 am