OpenLMIS

OpenLMIS

Activity on this page:

Line History

Line history chart not available

Line history chart not available

 

Stats

Commits this week: 5
Total Commits: 4,044
Last Commit: 01 Jan 70
Commits this week: 5

Commit Activity

Commits By Day In Week
52 week commits volume
Commits By Day In Week
Commits by day
Commits By Day In Week
Commits by hour
Commits By Hour In Day
Commit calendar
 
Thursday 14 Nov
10:05 am

Klaudia Pałkowska

10:04 am

Paweł Pinker , Sebastian Brudziński and Paulina Buzderewicz

10:02 am

Paweł Pinker

Wednesday 13 Nov
3:02 pm

Paweł Pinker

2:54 pm

Paulina Buzderewicz and Klaudia Pałkowska

2:45 pm

Paweł Pinker

All right. Did something in that manner. Thanks https://review.openlmis.org/static/ogdo0b/2static/images/wiki/icons/emoticons/smile.gif

All right. Did something in that manner. Thanks

1:34 pm

Paweł Pinker

OLMIS-6671: Introduced an additional method for better readibility

Options
    • -3
    • +7
    /src/main/java/org/openlmis/requisition/web/BatchRequisitionController.java
1:13 pm

Paulina Buzderewicz and Klaudia Pałkowska

12:38 pm

Klaudia Pałkowska

You could extract checks for column names to the first method, and then use this method + other two checks in the second method and use it in the if statement. Or something like that https://review...

You could extract checks for column names to the first method, and then use this method + other two checks in the second method and use it in the if statement. Or something like that

12:28 pm

Paulina Buzderewicz

12:18 pm

Paweł Pinker

Well... That's true, too. I was even looking into this matter before :/ I removed this unnecessary method.

Well... That's true, too. I was even looking into this matter before :/ I removed this unnecessary method.

12:16 pm

Paweł Pinker

Did some refactoring. I extracted this into separate private method, dividing as I left seemed logically - sourcetype & if a column is displayed and what is it's name (that should be treated as one...

Did some refactoring. I extracted this into separate private method, dividing as I left seemed logically - sourcetype & if a column is displayed and what is it's name (that should be treated as one thing I think). Could not extract it all into a separate method as Sonar wasn't allowing this.

11:37 am

Paweł Pinker

OLMIS-6671: Refactored the method in attempt to fix Sonar errors

Options
    • -3
    • +2
    /src/main/java/org/openlmis/requisition/web/BatchRequisitionController.java
10:22 am

Sebastian Brudziński

Why do we need a method that only calls another method? https://review.openlmis.org/static/ogdo0b/2static/images/wiki/icons/emoticons/smile.gif

Why do we need a method that only calls another method?

10:13 am

Paweł Pinker

True. The method was refactored.

True. The method was refactored.

10:09 am

Paweł Pinker

OLMIS-6671: Refactored methods

Options
    • -6
    • +9
    /src/main/java/org/openlmis/requisition/web/BatchRequisitionController.java
Tuesday 12 Nov
3:37 pm

Sebastian Brudziński

To improve readability we could: 1. merge this with an already existing if-statement 2. Extract this check to a separate private method

To improve readability we could:
1. merge this with an already existing if-statement
2. Extract this check to a separate private method

3:29 pm

Paweł Pinker , Klaudia Pałkowska and Sebastian Brudziński

3:25 pm

Sebastian Brudziński

Why do we need this step if we are returning null anyways?

Why do we need this step if we are returning null anyways?

3:24 pm

Paweł Pinker

3:24 pm

Paweł Pinker

OLMIS-6671: Refactoring for string literals to be on the left side of string comparisions
OLMIS-6671: Refactoring for string literals to be on the left side of string comparisions
2:20 pm

Klaudia Pałkowska

It looks like it isn't. Moreover, the whole findOrderablesWithLatestModifiedDate method is unnecessary.

It looks like it isn't. Moreover, the whole findOrderablesWithLatestModifiedDate method is unnecessary.

1:31 pm

Sebastian Brudziński

Is that still necessary?

Is that still necessary?

1:29 pm

Sebastian Brudziński

We should be using constants for all of the literals

We should be using constants for all of the literals

1:05 pm

Paulina Buzderewicz

Unfortunately according to the documentation, CriteriaBuilder API doesn't support equals with ignore case

Unfortunately according to the documentation, CriteriaBuilder API doesn't support equals with ignore case

12:54 pm

Paulina Buzderewicz

Yes, we can! https://review.openlmis.org/static/ogdo0b/2static/images/wiki/icons/emoticons/biggrin.gif

Yes, we can!

12:50 pm

Paweł Pinker

12:46 pm

Sebastian Brudziński

Can't we use the constant from the abstract class?

Can't we use the constant from the abstract class?

12:45 pm

Paulina Buzderewicz

This is needed for yet another partition in retrieving FTAPs (line 146)

This is needed for yet another partition in retrieving FTAPs (line 146)

12:39 pm

Sebastian Brudziński

We should extract all of those literals as constants

We should extract all of those literals as constants