OLMIS-1244 API for configuring Price Per Pack (T)

Activity

FEOLMIS-498 19

Keyboard shortcuts  
  • Summarize the review outcomes (optional)
     
    #permalink

    Details

    Warning: no files are visible, they have all been filtered.
    Participant Role Time Spent Comments Latest Comment
    Author 2h 39m 4 corrected
    Reviewer - Complete 33m 13 (2 defects) wait a minute? why is this static? The idea was to call o...
    Reviewer - 93% reviewed 28m    
    Total   3h 40m 19 (2 defects)  
    #permalink

    Objectives

    There are no specific objectives for this review.

    Branches in review

    #permalink

    Issues Raised From Comments

    Key Summary State Assignee
    #permalink

    General Comments

    There are no general comments on this review.
    /screen on UI.png Added
    Open in IDE #permalink
    /demo-data/referencedata.program_products.json Changed
    Open in IDE #permalink
    /src/main/.../domain/ProgramProduct.java Changed
    Open in IDE #permalink
    /demo-data/requisition.columns_maps.json Changed
    Open in IDE #permalink
    /src/main/.../domain/RequisitionLineItem.java Changed
    Open in IDE #permalink
    /src/main/.../requisition/dto/MoneyDto.java Changed
    Open in IDE #permalink
    /src/main/.../dto/OrderableProductDto.java Changed
    Open in IDE #permalink
    /src/main/.../dto/ProgramProductDto.java Changed 4
    /src/main/.../dto/ProgramProductDto.java Changed
    Open in IDE #permalink
    /src/main/.../dto/RequisitionLineItemDto.java Changed
    Open in IDE #permalink
    /src/.../service/RequisitionLineCalculationService.java Changed 8
    /src/.../service/RequisitionLineCalculationService.java Changed
    Open in IDE #permalink
    /src/main/.../utils/MoneyDtoDeSerializer.java Added 3
    Open in IDE #permalink
    /src/main/.../utils/MoneyDtoDeserializer.java
    Open in IDE #permalink
    /src/main/.../utils/MoneyDtoSerializer.java
    Open in IDE #permalink
    /src/main/resources/api-definition.yaml Changed
    Open in IDE #permalink
    /src/main/resources/bootstrap.sql Changed
    Open in IDE #permalink
    /src/.../domain/RequisitionLineItemTest.java Changed 1
    /src/.../domain/RequisitionLineItemTest.java Changed
    Open in IDE #permalink
    /src/test/.../dto/OrderableProductDtoTest.java Changed
    Open in IDE #permalink
    /src/.../service/RequisitionLineCalculationServiceTest.java Changed 3
    /src/.../service/RequisitionLineCalculationServiceTest.java Changed
    Open in IDE #permalink

    Review updated: Reload | Ignore | Collapse

    You cannot reload the review while writing a comment.

    Log time against