OLMIS-1242: Add packRoundingThreshold and roundToZero fields to OrderableProduct

Activity

FEOLMIS-496 14

Keyboard shortcuts  
  • Summarize the review outcomes (optional)
     
    #permalink

    Details

    Warning: no files are visible, they have all been filtered.
    Participant Role Time Spent Comments Latest Comment
    Author 46m 3 Josh Zamor That's I meant in my comment we didn't get thi...
    Reviewer - Complete 23m 5 We should copy these tests for the referencedata version.
    Reviewer - Complete 1h 2m 6 (1 defect) Thanks Pawel, this looks good.
    Total   2h 11m 14 (1 defect)  
    #permalink

    Objectives

    There are no specific objectives for this review.

    Branches in review

    #permalink

    Issues Raised From Comments

    Key Summary State Assignee
    #permalink

    General Comments

    Josh Zamor

    I left some comments on OrderableProduct and RequisitionLineItemCalculationSe...

    I left some comments on OrderableProduct and RequisitionLineItemCalculationService that should be addressed. Please send back when those are addressed.

    • Defect

    Josh Zamor

    Thanks Pawel, this looks good.

    Thanks Pawel, this looks good.

    /demo-data/referencedata.orderable_products.json Changed
    /src/.../repository/FacilityTypeApprovedProductRepositoryTest.java Changed
    /src/.../repository/OrderableProductIntegrationTest.java Changed
    /src/.../repository/TradeItemRepositoryIntegrationTest.java Changed
    /src/.../web/FacilityTypeApprovedProductControllerIntegrationTest.java Changed
    /src/main/.../domain/GlobalProduct.java Changed
    /src/main/.../domain/OrderableProduct.java Changed 8
    /src/main/.../domain/TradeItem.java Changed
    /src/main/resources/api-definition.yaml Changed
    /src/test/.../domain/GlobalProductTest.java Changed
    /src/test/.../domain/OrderableProductTest.java Changed
    /src/.../domain/ProgramProductBuilderTest.java Changed
    /src/test/.../domain/ProgramProductTest.java Changed
    /src/test/.../domain/TradeItemTest.java Changed
    /demo-data/requisition.columns_maps.json Changed
    /src/.../web/BaseWebIntegrationTest.java Changed
    /src/main/.../domain/RequisitionLineItem.java Changed
    /src/main/.../dto/OrderableProductDto.java Changed
    /src/main/.../dto/RequisitionLineItemDto.java Changed
    /src/.../service/RequisitionLineCalculationService.java Changed 3
    /src/main/.../web/RequisitionController.java Changed
    /src/main/resources/bootstrap.sql Changed
    /src/.../domain/RequisitionLineItemTest.java Changed
    /src/test/.../dto/OrderableProductDtoTest.java Added 1
    Open in IDE #permalink
    /src/.../service/RequisitionLineCalculationServiceTest.java Changed
    /src/.../web/RequisitionControllerTest.java Changed

    Review updated: Reload | Ignore | Collapse

    You cannot reload the review while writing a comment.

    Log time against