FEOLMIS-4587 OLMIS-7373 Add filtering by product code, name and lot code on Stock on Hand page

closed on 31 May 22

Author

Reviewers

OLMIS-7373 Add filtering by product code, name and lot code on Stock on Hand...

Activity

Details
Objectives
General Comments 0
Unresolved
Resolved
Number of files included: 33

openlmis-referencedata 0
- Folder src 0
  - Folder integration-test/java/org/openlmis/referencedata 0
    - Folder repository 0
      - File FacilityTypeApprovedProductRepositoryIntegrationTest.java 0 Remove
      - File OrderableRepositoryIntegrationTest.java 0 Remove
    - Folder web 0
      - File FacilityControllerIntegrationTest.java 0 Remove
      - File OrderableFulfillControllerIntegrationTest.java 0 Remove
  - Folder main 0
    - Folder java/org/openlmis/referencedata 0
      - Folder repository 0
        
        Folder custom 0
        
        Folder impl 0
        
        File FacilityTypeApprovedProductRepositoryImpl.java 0 Remove
        
        File FacilityTypeApprovedProductRepositoryImpl.java 0 Remove
        
        File OrderableRepositoryImpl.java 0 Remove
        
        File FacilityTypeApprovedProductRepositoryCustom.java 0 Remove
        
        File OrderableRepositoryCustom.java 0 Remove
        
        File OrderableRepository.java 0 Remove
      - Folder web 0
        
        File FacilityController.java 0 Remove
        
        File FacilityController.java 0 Remove
        
        File OrderableFulfillController.java 0 Remove
        
        File OrderableSearchParams.java 0 Remove
        
        File QueryOrderableSearchParams.java 0 Remove
    - Folder resources 0
      - File api-definition.yaml 0 Remove
openlmis-stockmanagement 0
- Folder src 0
  - Folder integration-test/java/org/openlmis/stockmanagement/web/stockcardsummariesv2 0
    - File StockCardSummariesV2ControllerIntegrationTest.java 0 Remove
  - Folder main 0
    - Folder java/org/openlmis/stockmanagement 0
      - Folder service 0
        
        Folder referencedata 0
        
        File ApprovedProductReferenceDataService.java 0 Remove
        
        File CalculatedStockOnHandService.java 0 Remove
        
        File StockCardSummariesService.java 0 Remove
        
        File StockCardSummariesV2SearchParams.java 0 Remove
      - Folder web 0
        
        File Pagination.java 0 Remove
    - Folder resources 0
      - File api-definition.yaml 0 Remove
  - Folder test/java/org/openlmis/stockmanagement 0
    - Folder service 0
      - File StockCardSummariesServiceTest.java 0 Remove
    - Folder testutils 0
      - File StockCardSummariesV2SearchParamsDataBuilder.java 0 Remove
      - File StockCardSummaryV2DtoDataBuilder.java 0 Remove
openlmis-stockmanagement-ui 0
- Folder src/stock-card-summary-list 0
  - File messages_en.json 0 Remove
  - File stock-card-summary-list.controller.js 0 Remove
  - File stock-card-summary-list.controller.spec.js 0 Remove
  - File stock-card-summary-list.html 0 Remove
  - File stock-card-summary-list.routes.js 0 Remove
- File CHANGELOG.md 0 Remove
- File npm-shrinkwrap.json 0 Remove

#permalink

Details

Warning: no files are visible, they have all been filtered.

Participant	Role	Time Spent	Comments
hdsldv	Author	9m
Paweł Muchowski	Reviewer - Complete	6m
Total		15m	0

Linked issues
- OLMIS-7373

#permalink

Objectives

There are no specific objectives for this review.

Branches in review

#permalink

Issues Raised From Comments

Key	Summary	State	Assignee

#permalink

General Comments

There are no general comments on this review.

Click to load diff

Notation	Description
[Crucible Review CR-1\|CR-1]	Creates a link to a Crucible review or FishEye artifact using the internal key reference for the item. Example: Crucible Review CR-1
[Atlassian Crucible\|http://atlassian.com/crucible]	Creates a link to an external resource, special characters that come after the URL and are not part of it must be separated with a space. External links are denoted with an arrow icon. Example: Atlassian Crucible
{cs:id=1\|rep=repository-key}	Render a link to the changeset Example: 1
bold	Makes text appear bold.
_italic_	Makes text appear in italics.
+underline+	Makes text appear underlined.
??citation??	Makes text appear in citation form.
-strikethrough-	Makes text appear ~~struck through~~.
^superscript^	Makes text appear in ^superscript.
~subscript~	Makes text appear in _subscript.
{{ monospaced }}	Placing double curly-brackets around text makes it appear `monospaced`.
{code} // Some comments here public String getFoo() { return foo; } {code}	The code macro displays a preformatted block for showing code with syntax highlighting. Example: // Some comments here public String getFoo() { return foo; }
bq. Block Quote	To make an entire paragraph into a block quotation, place "bq. " before it. Example: Block Quote
{quote} here is quoteable content to be quoted {quote}	Quote a block of text that's longer than one paragraph. Example: here is quoteable content to be quoted
{color:red} look ma, red text!{color}	Changes the color of a block of text. Example: look ma, red text!
* A list with bullets * Second item ** Indented item	Example: A list with bullets Second item Indented item
# A list with numbers # Second item ## Indented item	Example: A list with numbers Second item Indented item

FEOLMIS-4587

OLMIS-7373 Add filtering by product code, name and lot code on Stock on Hand...

FEOLMIS-4587 0

Details

Linked issues

Objectives

Branches in review

Issues Raised From Comments

General Comments

Log time

OLMIS-7373 Add filtering by product code, name and lot code on Stock on Hand...

FEOLMIS-4587 0

Summarize the review outcomes (optional)

Details

Linked issues

Objectives

Branches in review

Issues Raised From Comments

General Comments

Log time