FEOLMIS-4568 OLMIS-7534 Fix unique code validation for existing orderable

closed on 01 Mar 22

Author

Reviewers

OLMIS-7534 Fix unique code validation for existing orderable

Activity

Details
Objectives
General Comments 0
Unresolved
Resolved
Number of files included: 7

openlmis-referencedata 0
- Folder src 0
  - Folder integration-test/java/org/openlmis/referencedata/repository 0
    - File OrderableRepositoryIntegrationTest.java 0 Remove
  - Folder main/java/org/openlmis/referencedata 0
    - Folder repository 0
      - File OrderableRepository.java 0 Remove
      - File RepositoryConstants.java 0 Remove
    - Folder validate 0
      - File OrderableValidator.java 2 Remove
  - Folder test/java/org/openlmis/referencedata 0
    - Folder testbuilder 0
      - File OrderableDataBuilder.java 0 Remove
    - Folder validate 0
      - File OrderableValidatorTest.java 0 Remove
- File CHANGELOG.md 0 Remove

#permalink

Details

Warning: no files are visible, they have all been filtered.

Participant	Role	Time Spent	Comments	Latest Comment
hdsldv	Author	7m	1	replaced with equals
Nikola Laskowska	Reviewer - 0% reviewed
Paweł Muchowski	Reviewer - Complete	8m	1	why not use equals instead of compareTo?
Total		16m	2

Linked issues
- OLMIS-7534

#permalink

Objectives

There are no specific objectives for this review.

Branches in review

#permalink

Issues Raised From Comments

Key	Summary	State	Assignee

#permalink

General Comments

There are no general comments on this review.

Click to load diff

Notation	Description
[Crucible Review CR-1\|CR-1]	Creates a link to a Crucible review or FishEye artifact using the internal key reference for the item. Example: Crucible Review CR-1
[Atlassian Crucible\|http://atlassian.com/crucible]	Creates a link to an external resource, special characters that come after the URL and are not part of it must be separated with a space. External links are denoted with an arrow icon. Example: Atlassian Crucible
{cs:id=1\|rep=repository-key}	Render a link to the changeset Example: 1
bold	Makes text appear bold.
_italic_	Makes text appear in italics.
+underline+	Makes text appear underlined.
??citation??	Makes text appear in citation form.
-strikethrough-	Makes text appear ~~struck through~~.
^superscript^	Makes text appear in ^superscript.
~subscript~	Makes text appear in _subscript.
{{ monospaced }}	Placing double curly-brackets around text makes it appear `monospaced`.
{code} // Some comments here public String getFoo() { return foo; } {code}	The code macro displays a preformatted block for showing code with syntax highlighting. Example: // Some comments here public String getFoo() { return foo; }
bq. Block Quote	To make an entire paragraph into a block quotation, place "bq. " before it. Example: Block Quote
{quote} here is quoteable content to be quoted {quote}	Quote a block of text that's longer than one paragraph. Example: here is quoteable content to be quoted
{color:red} look ma, red text!{color}	Changes the color of a block of text. Example: look ma, red text!
* A list with bullets * Second item ** Indented item	Example: A list with bullets Second item Indented item
# A list with numbers # Second item ## Indented item	Example: A list with numbers Second item Indented item

FEOLMIS-4568

OLMIS-7534 Fix unique code validation for existing orderable

FEOLMIS-4568 2

Details

Linked issues

Objectives

Branches in review

Issues Raised From Comments

General Comments

Log time

OLMIS-7534 Fix unique code validation for existing orderable

FEOLMIS-4568 2

Summarize the review outcomes (optional)

Details

Linked issues

Objectives

Branches in review

Issues Raised From Comments

General Comments

Log time