This is a list of all comments for FEOLMIS-4509.

Review Summary: No summary


----------------------------------------
File: src/main/java/org/openlmis/stockmanagement/domain/card/StockCard.java
Revision Comment by hdsldv on 25 November 2021, 23:56 
https://review.openlmis.org/cru/FEOLMIS-4509#c22975

  I'm not sure, but I think snake_case is prefered naming
  convention in the project. Please confirm and if needed, write
  next flyway migration with column alteration

  Reply by Krzysztof Pasiek on 26 November 2021, 10:03
  > done

    Reply by Paweł Muchowski on 26 November 2021, 11:19
    > it should be is_active, not isactive

----------------------------------------
File: src/stock-card/stock-card.service.js
Revision Comment by Paweł Muchowski on 26 November 2021, 09:16 
https://review.openlmis.org/cru/FEOLMIS-4509#c22976

  I think this name should be changed, because it's always
  deactivating the card not updating the status

  Reply by Krzysztof Pasiek on 26 November 2021, 09:51
  > I will change it to deactivateStockCard

  Reply by Krzysztof Pasiek on 26 November 2021, 10:03
  > done


---

ID: FEOLMIS-4509 https://review.openlmis.org/cru/FEOLMIS-4509

Title: OLMIS-7430 Add logic to  filter all inactive and active items on physical inventory and stock on hand...
Statement of Objectives:


State: Closed

Summary: 

Author: Krzysztof Pasiek
Reviewers: (2 active, 0 completed*)
     hdsldv
     Paweł Muchowski