FEOLMIS-4509 OLMIS-7430 Add logic to filter all inactive and active items on physical inventory and stock on hand...

closed on 30 Nov 21

Author

Reviewers

OLMIS-7430 Add logic to filter all inactive and active items on physical...

Activity

Details
Objectives
General Comments 0
Unresolved
Resolved
Number of files included: 28

openlmis-stockmanagement 0
- Folder src/main 0
  - Folder java/org/openlmis/stockmanagement 0
    - Folder domain 0
      - Folder card 0
        
        File StockCard.java 3 Remove
      - Folder template 0
        
        File StockCardTemplate.java 0 Remove
    - Folder service 0
      - File CalculatedStockOnHandService.java 0 Remove
      - File StockCardService.java 0 Remove
  - Folder resources/db/migration 0
    - File 20210823145929429__add_isActive_to_stock_card_template.sql 0 Remove
- File CHANGELOG.md 0 Remove
openlmis-stockmanagement-ui 0
- Folder src 0
  - Folder stock-add-products-modal 0
    - File add-products-modal.controller.js 0 Remove
  - Folder stock-adjustment-creation 0
    - File adjustment-creation.controller.js 0 Remove
    - File adjustment-creation.controller.spec.js 0 Remove
  - Folder stock-card 0
    - File stock-card.service.js 3 Remove
    - File stock-card.service.spec.js 0 Remove
  - Folder stock-card-summary 0
    - File stock-card-summary-repository-impl.js 0 Remove
  - Folder stock-card-summary-list 0
    - File stock-card-summary-list.controller.js 0 Remove
    - File stock-card-summary-list.controller.spec.js 0 Remove
    - File stock-card-summary-list.html 0 Remove
    - File stock-card-summary-list.routes.js 0 Remove
  - Folder stock-event 0
    - File stock-event.factory.js 0 Remove
  - Folder stock-physical-inventory 0
    - File physical-inventory-line-item-data-builder.spec.js 0 Remove
    - File physical-inventory.factory.js 0 Remove
    - File physical-inventory.service.js 0 Remove
  - Folder stock-physical-inventory-draft 0
    - File messages_en.json 0 Remove
    - File physical-inventory-draft.controller.js 0 Remove
    - File physical-inventory-draft.controller.spec.js 0 Remove
    - File physical-inventory-draft.html 0 Remove
    - File physical-inventory-draft.module.js 0 Remove
  - Folder stock-physical-inventory-list 0
    - File physical-inventory-list.controller.js 0 Remove
    - File physical-inventory-list.controller.spec.js 0 Remove
- File CHANGELOG.md 0 Remove

#permalink

Details

Warning: no files are visible, they have all been filtered.

Participant	Role	Time Spent	Comments	Latest Comment
Krzysztof Pasiek	Author	21m	3	done
hdsldv	Reviewer - 100% reviewed	24m	1	I'm not sure, but I think snake_case is prefered naming c...
Paweł Muchowski	Reviewer - 96% reviewed	25m	2	it should be is_active, not isactive
Total		1h 11m	6

Linked issues
- OLMIS-7430

#permalink

Objectives

There are no specific objectives for this review.

Branches in review

#permalink

Issues Raised From Comments

Key	Summary	State	Assignee

#permalink

General Comments

There are no general comments on this review.

Click to load diff

Notation	Description
[Crucible Review CR-1\|CR-1]	Creates a link to a Crucible review or FishEye artifact using the internal key reference for the item. Example: Crucible Review CR-1
[Atlassian Crucible\|http://atlassian.com/crucible]	Creates a link to an external resource, special characters that come after the URL and are not part of it must be separated with a space. External links are denoted with an arrow icon. Example: Atlassian Crucible
{cs:id=1\|rep=repository-key}	Render a link to the changeset Example: 1
bold	Makes text appear bold.
_italic_	Makes text appear in italics.
+underline+	Makes text appear underlined.
??citation??	Makes text appear in citation form.
-strikethrough-	Makes text appear ~~struck through~~.
^superscript^	Makes text appear in ^superscript.
~subscript~	Makes text appear in _subscript.
{{ monospaced }}	Placing double curly-brackets around text makes it appear `monospaced`.
{code} // Some comments here public String getFoo() { return foo; } {code}	The code macro displays a preformatted block for showing code with syntax highlighting. Example: // Some comments here public String getFoo() { return foo; }
bq. Block Quote	To make an entire paragraph into a block quotation, place "bq. " before it. Example: Block Quote
{quote} here is quoteable content to be quoted {quote}	Quote a block of text that's longer than one paragraph. Example: here is quoteable content to be quoted
{color:red} look ma, red text!{color}	Changes the color of a block of text. Example: look ma, red text!
* A list with bullets * Second item ** Indented item	Example: A list with bullets Second item Indented item
# A list with numbers # Second item ## Indented item	Example: A list with numbers Second item Indented item

FEOLMIS-4509

OLMIS-7430 Add logic to filter all inactive and active items on physical...

FEOLMIS-4509 6

Details

Linked issues

Objectives

Branches in review

Issues Raised From Comments

General Comments

Log time

OLMIS-7430 Add logic to filter all inactive and active items on physical...

FEOLMIS-4509 6

Summarize the review outcomes (optional)

Details

Linked issues

Objectives

Branches in review

Issues Raised From Comments

General Comments

Log time