OLMIS-7305: Added sending stockEvent object to one-network-integration-service

Activity

FEOLMIS-4441 1

Keyboard shortcuts  
  • Summarize the review outcomes (optional)
     
    #permalink

    Details

    Warning: no files are visible, they have all been filtered.
    Participant Role Time Spent Comments Latest Comment
    Author 1m    
    Reviewer - Complete 8m 1 Please add unit tests
    Reviewer - 0% reviewed      
    Reviewer - 0% reviewed      
    Total   9m 1  
    #permalink

    Objectives

    There are no specific objectives for this review.

    Branches in review

    #permalink

    Issues Raised From Comments

    Key Summary State Assignee
    #permalink

    General Comments

    There are no general comments on this review.
    /src/main/.../events/StockEventEvent.java Changed
    Open in IDE #permalink
    /src/main/.../events/StockEventObserver.java Deleted
    Open in IDE #permalink
    /src/.../service/StockEventIntegrationDataException.java Added
    Open in IDE #permalink
    /src/.../service/StockEventIntegrationDataService.java Added
    Open in IDE #permalink
    /src/test/.../events/StockEventEventTest.java Changed
    Open in IDE #permalink
    /CHANGELOG.md Changed
    /README.md Changed
    Open in IDE #permalink
    /build.gradle Changed
    Open in IDE #permalink
    /src/.../referencedata/CanFulfillForMeEntryDto.java Added
    Open in IDE #permalink
    /src/.../referencedata/FacilityWrapper.java Added
    Open in IDE #permalink
    /src/.../referencedata/ObjectReferenceDto.java Added
    Open in IDE #permalink
    /src/.../referencedata/OrderableWrapper.java Added
    Open in IDE #permalink
    /src/.../referencedata/StockCardSummaries.java Added
    Open in IDE #permalink
    /src/.../referencedata/StockCardSummariesWrapper.java Added
    Open in IDE #permalink
    /src/main/.../referencedata/StockEvent.java Added
    Open in IDE #permalink
    /src/.../referencedata/StockEventLineItemDto.java Added
    Open in IDE #permalink
    /src/main/.../integration/dto/Facility.java Changed
    Open in IDE #permalink
    /src/main/.../dto/FacilityWrapper.java Deleted
    Open in IDE #permalink
    /src/main/.../dto/OrderableWrapper.java Deleted
    Open in IDE #permalink
    /src/main/.../integration/dto/SohForCsv.java Deleted
    Open in IDE #permalink
    /src/.../dto/StockCardSummariesWrapper.java Deleted
    Open in IDE #permalink
    /src/main/.../integration/dto/StockEvent.java Deleted
    Open in IDE #permalink
    /src/main/.../dto/StockEventLineItemDto.java Deleted
    Open in IDE #permalink
    /src/main/.../integration/dto/StockOnHand.java Added
    /src/main/.../dto/StockOnHandForCsv.java Added
    Open in IDE #permalink
    /src/.../referencedata/FacilityDataService.java Changed
    Open in IDE #permalink
    /src/.../referencedata/OrderableDataService.java Changed
    Open in IDE #permalink
    /src/.../referencedata/StockCardSummariesService.java Added
    Open in IDE #permalink
    /src/main/.../service/ProcessingService.java Changed
    /src/.../service/StockEventBufferService.java Added
    Open in IDE #permalink
    /src/main/.../web/StockEventController.java Added
    Open in IDE #permalink
    /src/main/.../schemas/stockEvent.json Added
    Open in IDE #permalink
    /src/.../schemas/stockEventLineItemDto.json Added
    Open in IDE #permalink
    /src/main/resources/api-definition.yaml Changed
    Open in IDE #permalink
    /src/.../referencedata/StockCardSummariesTest.java Added
    Open in IDE #permalink
    /src/test/.../dto/FacilityTest.java Changed
    Open in IDE #permalink
    /src/test/.../dto/StockEventTest.java Added
    Open in IDE #permalink
    /src/test/.../dto/StockOnHandTest.java Added
    Open in IDE #permalink
    /src/.../referencedata/FacilityDataServiceTest.java Changed
    Open in IDE #permalink
    /src/.../referencedata/OrderableDataServiceTest.java Changed
    Open in IDE #permalink
    /src/.../referencedata/StockCardSummariesServiceTest.java Added 1
    Open in IDE #permalink
    /src/.../service/StockEventBufferServiceTest.java Added
    Open in IDE #permalink
    /CHANGELOG.md Changed

    Review updated: Reload | Ignore | Collapse

    You cannot reload the review while writing a comment.

    Log time