FEOLMIS-4413 OLMIS-7304: Added sending orderable to one-network-integration-service

open for 22 months due 22 months ago

Author

Reviewers

OLMIS-7304: Added sending orderable to one-network-integration-service

Activity

Details
Objectives
General Comments 0
Unresolved
Resolved
Number of files included: 74

one-network-integration-ui 0
- Folder src 0
  - Folder admin-one-network-integration 0
    - File admin-one-network-integration.controller.js 0 Remove
    - File admin-one-network-integration.controller.spec.js 0 Remove
    - File admin-one-network-integration.html 0 Remove
    - File admin-one-network-integration.module.js 0 Remove
    - File admin-one-network-integration.routes.js 0 Remove
    - File admin-one-network-integration.routes.spec.js 0 Remove
    - File messages_en.json 0 Remove
  - Folder one-network-integration 0
    - File one-network-integration.module.js 0 Remove
    - File one-network-integration.service.js 0 Remove
    - File one-network-integration.service.spec.js 0 Remove
  - Folder one-network-integration-scheduler 0
    - File one-network-integration-scheduler.module.js 0 Remove
    - File one-network-integration-scheduler.service.js 0 Remove
    - File one-network-integration-scheduler.service.spec.js 0 Remove
one-network-referencedata-extension 0
- Folder src 0
  - Folder main/java/org/openlmis/referencedata 0
    - Folder events 0
      - File OrderableCreateEvent.java 0 Remove
      - File OrderableUpdateEvent.java 0 Remove
      - File ProductsObserver.java 0 Remove
    - Folder service 0
      - File OrderableIntegrationDataException.java 0 Remove
      - File OrderableIntegrationDataService.java 0 Remove
  - Folder test/java/org/openlmis/referencedata/events 0
    - File OrderableCreateEventTest.java 0 Remove
    - File OrderableUpdateEventTest.java 0 Remove
- File CHANGELOG.md 0 Remove
- File build.gradle 0 Remove
openlmis-one-network-integration-service 0
- Folder src 0
  - Folder main 0
    - Folder java/org/openlmis/onenetwork/integration 0
      - Folder configuration 0
        
        File IntegrationConfiguration.java 0 Remove
        
        File SchedulerConfiguration.java 0 Remove
      - Folder domain 0
        
        File Orderable.java 1 Remove
        
        File OrderableForCsv.java 0 Remove
        
        File OrderableWrapper.java 0 Remove
        
        File SchedulerStatus.java 0 Remove
      - Folder dto 0
        
        File IntegrationStatus.java 0 Remove
        
        File Orderable.java 0 Remove
        
        File OrderableForCsv.java 0 Remove
        
        File OrderableWrapper.java 0 Remove
        
        File SchedulerStatus.java 0 Remove
      - Folder exception 0
        
        File DataRetrievalException.java 0 Remove
      - Folder scheduler 0
        
        File ScheduledTasks.java 0 Remove
      - Folder service 0
        
        Folder csv 0
        
        File CsvService.java 0 Remove
        
        Folder referencedata 0
        
        File OrderableDataService.java 0 Remove
        
        File OrderableDto.java 0 Remove
        
        Folder request 0
        
        File RequestHeaders.java 0 Remove
        
        File RequestHelper.java 0 Remove
        
        File RequestParameters.java 0 Remove
        
        File AuthService.java 0 Remove
        
        File BasicQueue.java 4 Remove
        
        File BufferService.java 0 Remove
        
        File CsvService.java 0 Remove
        
        File OrderableBufferService.java 2 Remove
        
        File OrderableCsvService.java 0 Remove
        
        File OrderableQueue.java 1 Remove
        
        File OrderableQueueService.java 0 Remove
        
        File ProcessingService.java 2 Remove
        
        File Scheduler.java 0 Remove
      - Folder sftp 0
        
        File SftpClient.java 0 Remove
        
        File SftpService.java 1 Remove
      - Folder web 0
        
        File IntegrationController.java 2 Remove
        
        File OrderableController.java 6 Remove
        
        File SchedulerController.java 7 Remove
      - File Application.java 0 Remove
    - Folder resources 0
      - Folder schemas 0
        
        File integrationStatus.json 0 Remove
        
        File orderable.json 0 Remove
        
        File schedulerStatus.json 0 Remove
      - File api-definition.yaml 0 Remove
      - File application.properties 0 Remove
  - Folder test/java/org/openlmis/onenetwork/integration 0
    - Folder domain 0
      - File OrderableTest.java 0 Remove
    - Folder dto 0
      - File OrderableTest.java 0 Remove
    - Folder service 0
      - Folder csv 0
        
        File CsvServiceTest.java 0 Remove
      - Folder referencedata 0
        
        File OrderableDataServiceTest.java 0 Remove
      - File OrderableBufferServiceTest.java 0 Remove
      - File OrderableQueueServiceTest.java 0 Remove
      - File OrderableQueueTest.java 0 Remove
    - Folder sftp 0
      - File SftpServiceTest.java 0 Remove
    - Folder util 0
      - File MessageTest.java 0 Remove
- File CHANGELOG.md 0 Remove
- File README.md 0 Remove
- File build.gradle 0 Remove

#permalink

Details

Warning: no files are visible, they have all been filtered.

Participant	Role	Time Spent	Comments	Latest Comment
Aleksandra Sołtys	Author	2h 6m	3	Yes, you're right
Paweł Muchowski	Reviewer - Complete	2h 4m	23	I think you can rename this to processBufferedData
Total		4h 11m	26

#permalink

Objectives

There are no specific objectives for this review.

Branches in review

#permalink

Issues Raised From Comments

Key	Summary	State	Assignee

#permalink

General Comments

There are no general comments on this review.

Click to load diff

/src/one-network-integration-scheduler/one-network-integration-scheduler.module.js Deleted

Click to load diff

/src/one-network-integration-scheduler/one-network-integration-scheduler.service.js Deleted

Click to load diff

/src/one-network-integration-scheduler/one-network-integration-scheduler.service.spec.js Deleted

Click to load diff

/src/main/.../events/ProductsObserver.java Deleted

Click to load diff

/src/.../configuration/SchedulerConfiguration.java Deleted

Click to load diff

/src/main/.../domain/OrderableForCsv.java Deleted

Click to load diff

/src/main/.../domain/OrderableWrapper.java Deleted

Click to load diff

/src/main/.../domain/SchedulerStatus.java Deleted

Click to load diff

/src/main/.../referencedata/OrderableDto.java Deleted

Click to load diff

/src/main/.../service/OrderableCsvService.java Deleted

Click to load diff

/src/main/.../service/OrderableQueue.java Deleted 1 (0)

Click to load diff

/src/.../service/OrderableQueueService.java Deleted

Click to load diff

/src/main/.../web/SchedulerController.java Deleted 7 (0)

Click to load diff

/src/main/.../schemas/schedulerStatus.json Deleted

Click to load diff

/src/.../service/OrderableQueueServiceTest.java Deleted

Click to load diff

/src/test/.../service/OrderableQueueTest.java Deleted

Click to load diff

Notation	Description
[Crucible Review CR-1\|CR-1]	Creates a link to a Crucible review or FishEye artifact using the internal key reference for the item. Example: Crucible Review CR-1
[Atlassian Crucible\|http://atlassian.com/crucible]	Creates a link to an external resource, special characters that come after the URL and are not part of it must be separated with a space. External links are denoted with an arrow icon. Example: Atlassian Crucible
{cs:id=1\|rep=repository-key}	Render a link to the changeset Example: 1
bold	Makes text appear bold.
_italic_	Makes text appear in italics.
+underline+	Makes text appear underlined.
??citation??	Makes text appear in citation form.
-strikethrough-	Makes text appear ~~struck through~~.
^superscript^	Makes text appear in ^superscript.
~subscript~	Makes text appear in _subscript.
{{ monospaced }}	Placing double curly-brackets around text makes it appear `monospaced`.
{code} // Some comments here public String getFoo() { return foo; } {code}	The code macro displays a preformatted block for showing code with syntax highlighting. Example: // Some comments here public String getFoo() { return foo; }
bq. Block Quote	To make an entire paragraph into a block quotation, place "bq. " before it. Example: Block Quote
{quote} here is quoteable content to be quoted {quote}	Quote a block of text that's longer than one paragraph. Example: here is quoteable content to be quoted
{color:red} look ma, red text!{color}	Changes the color of a block of text. Example: look ma, red text!
* A list with bullets * Second item ** Indented item	Example: A list with bullets Second item Indented item
# A list with numbers # Second item ## Indented item	Example: A list with numbers Second item Indented item

FEOLMIS-4413

OLMIS-7304: Added sending orderable to one-network-integration-service

FEOLMIS-4413 26

Details

Objectives

Branches in review

Issues Raised From Comments

General Comments

Log time

OLMIS-7304: Added sending orderable to one-network-integration-service

FEOLMIS-4413 26

Summarize the review outcomes (optional)

Details

Objectives

Branches in review

Issues Raised From Comments

General Comments

Log time