TZUP-117 Create backend to extract number of users who logged in OpenLMIS

Activity

FEOLMIS-4371 17

Keyboard shortcuts  
  • Summarize the review outcomes (optional)
     
    #permalink

    Details

    Warning: no files are visible, they have all been filtered.
    Participant Role Time Spent Comments Latest Comment
    Author 58m 9 `Noted, you are right
    Reviewer - Complete 27m 1 The main pin point of this analytic export was to get use...
    Reviewer - Complete 19m 7 I assume you researched this a bit further. Is there any ...
    Total   1h 45m 17  
    #permalink

    Objectives

    There are no specific objectives for this review.

    Branches in review

    #permalink

    Issues Raised From Comments

    Key Summary State Assignee
    #permalink

    General Comments

    hassan

    The main pin point of this analytic export was to get users by username, In O...

    The main pin point of this analytic export was to get users by username, In OpenLMIS v2 username field is not mandatory hence we may get wrong data in Google analytics because GA uses username as variable (primary key) to identify a user. We need to verify if openLMIS V3 username field is unique or set user ID
    in GA and get these metrics by ID instead of getting by username. Does that make sense?

    Ian

    I am not sure if I understand your point, but if the question is that on Open...

    I am not sure if I understand your point, but if the question is that on OpenLMIS v3 username is unique then the answer is YES

    Ian

    I had a discussion with Wes Brown about this, he suggested we can add user id...

    I had a discussion with Wes Brown about this, he suggested we can add user identification information to be shared with GA, but since we are implementing this on the Core, this feature should be able to be turned on/off and by default should be off...I will create another ticket for this

    /src/.../web/GoogleAnalyticsControllerIntegrationTest.java Added
    Open in IDE #permalink
    /src/main/.../dto/referencedata/UserDto.java Changed
    Open in IDE #permalink
    /src/main/java/.../common/dto/VisitorDto.java Added
    Open in IDE #permalink
    /src/main/.../common/i18n/MessageKeys.java Changed
    Open in IDE #permalink
    /src/.../referencedata/UserReferenceDataService.java Changed
    Open in IDE #permalink
    /src/.../service/GoogleAnalyticsService.java Added 10
    /src/main/.../service/PermissionService.java Changed
    Open in IDE #permalink
    /src/main/.../util/CustomSortDeserializer.java Changed
    Open in IDE #permalink
    /src/.../web/GoogleAnalyticsController.java Added
    Open in IDE #permalink
    /src/main/resources/schemas/userDto.json Added
    Open in IDE #permalink
    /src/main/.../schemas/visitorDto.json Added
    Open in IDE #permalink
    /src/main/.../schemas/visitorDtoPage.json Added
    Open in IDE #permalink
    /src/main/resources/api-definition.yaml Changed
    Open in IDE #permalink
    /src/main/resources/application.properties Changed 4
    /src/.../web/GoogleAnalyticsControllerTest.java Added
    Open in IDE #permalink
    /build.gradle Changed
    Open in IDE #permalink

    Review updated: Reload | Ignore | Collapse

    You cannot reload the review while writing a comment.

    Log time