TZUP-117 Create backend to extract number of users who logged in OpenLMIS

Activity

FEOLMIS-4366 7

Keyboard shortcuts  
  • Summarize the review outcomes (optional)
     
    #permalink

    Details

    Warning: no files are visible, they have all been filtered.
    Participant Role Time Spent Comments Latest Comment
    Author 32m 3 I will close this review and open another one
    Reviewer - 0% reviewed 0m    
    Reviewer - Complete 23m 4 Ian The report that you are picking up seems to fully ass...
    Total   55m 7  
    #permalink

    Objectives

    There are no specific objectives for this review.

    Branches in review

    #permalink

    Issues Raised From Comments

    Key Summary State Assignee
    #permalink

    General Comments

    Ian

    Using user-session information from GA to create API that will be used to cre...

    Using user-session information from GA to create API that will be used to create the report

    Elias

    Ian Is this feature specific to Tanzania? or is it something that is needed i...

    Ian Is this feature specific to Tanzania? or is it something that is needed in the OpenLMIS report?
    If it is Tanzania Specific, may be committing it in the generic https://gitlab.com/openlmis/tz-openlmis-commons tanzania repository makes sense?

    Chongsun Ahn Josh Zamor Thoughts?

      Elias marked as Unresolved 21 Jun

    Ian

    You make a very good point, when we started the plan was to implement this in...

    You make a very good point, when we started the plan was to implement this in the Core project but later on, Wes suggested we should first focus on the TZ requirment, so I accept that maybe this should be moved to TZ common repository

    Ian

    I will close this review and open another one

    I will close this review and open another one

    /src/.../web/GoogleAnalyticsControllerIntegrationTest.java Added
    Open in IDE #permalink
    /src/main/.../referencedata/UserDto.java Changed
    Open in IDE #permalink
    /src/main/java/.../report/dto/BaseDto.java Added
    Open in IDE #permalink
    /src/main/java/.../report/dto/PageDto.java Added
    Open in IDE #permalink
    /src/main/java/.../report/dto/VisitorDto.java Added
    Open in IDE #permalink
    /src/main/.../report/i18n/MessageKeys.java Changed
    Open in IDE #permalink
    /src/.../referencedata/UserReferenceDataService.java Changed
    Open in IDE #permalink
    /src/.../service/BaseCommunicationService.java Changed
    Open in IDE #permalink
    /src/.../service/GoogleAnalyticsService.java Added 2
    Open in IDE #permalink
    /src/.../utils/CustomSortDeserializer.java Added
    Open in IDE #permalink
    /src/.../utils/DynamicPageTypeReference.java Changed
    Open in IDE #permalink
    /src/.../web/GoogleAnalyticsController.java Added
    Open in IDE #permalink
    /src/main/.../schemas/visitorDto.json Added
    Open in IDE #permalink
    /src/main/.../schemas/visitorDtoPage.json Added
    Open in IDE #permalink
    /src/main/resources/api-definition.yaml Changed
    Open in IDE #permalink
    /src/main/resources/application.properties Changed
    Open in IDE #permalink
    /src/main/resources/ga.json Added 1
    Open in IDE #permalink
    /src/main/resources/messages_en.properties Changed
    Open in IDE #permalink
    /src/.../web/GoogleAnalyticsControllerTest.java Added
    Open in IDE #permalink
    /dependency.gradle Changed
    Open in IDE #permalink

    Review updated: Reload | Ignore | Collapse

    You cannot reload the review while writing a comment.

    Log time