TZUP-163 Creation of the Health Commodities Quantification Exports

Activity

FEOLMIS-4345 21

Keyboard shortcuts  
  • Summarize the review outcomes (optional)
     
    #permalink

    Details

    Warning: no files are visible, they have all been filtered.
    Participant Role Time Spent Comments Latest Comment
    Author 1h 49m 5 I have renamed this string to FACILITY_CONSUMPTION_REPORT...
    Reviewer - Complete 17m 1 Hi Boniface Chacha i'm able to see if permission rights t...
    Reviewer - Complete 9m    
    Reviewer - Complete 1h 48m 15 This string should be FACILITY_CONSUMPTION_REPORT_VIEW.
    Total   4h 4m 21  
    #permalink

    Objectives

    Added two endpoints for generating Quantification Exports at the facility and district level. The generated exports are in the CSV format.

    facility endpoint - /facilityLevelQuantification
    district endpoint - /districtLevelQuantification

    Branches in review

    #permalink

    Issues Raised From Comments

    Key Summary State Assignee
    #permalink

    General Comments

    hassan

    Hi Boniface Chacha i'm able to see if permission rights to view the report ha...

    Hi Boniface Chacha
    i'm able to see if permission rights to view the report has been added? i.e FACILITY_CONSUMPTION_REPORT_VIEW and DISTRICT_CONSUMPTION_REPORT_VIEW

    Chongsun Ahn

    I don't see that some of my initial comments have been resolved.

    I don't see that some of my initial comments have been resolved.

    Boniface Chacha

    Chongsun Ahn I have edited the QuantificationControllerIntegrationTest and ap...

    Chongsun Ahn I have edited the QuantificationControllerIntegrationTest and api-definition.yaml to include tests for 400 and 401

    Boniface Chacha

    Chongsun Ahn I have separated the tests for BadRequest and UnAuthorised. Also...

    Chongsun Ahn I have separated the tests for BadRequest and UnAuthorised. Also, I have changed the name for the extract file to reflect the levels

    Boniface Chacha

    hassan I have added permissions management service and its respective DTO and...

    hassan I have added permissions management service and its respective DTO and also Implemented permission check for the quantifications APIs

    /src/.../web/QuantificationControllerIntegrationTest.java Added 4
    Open in IDE #permalink
    /src/.../referencedata/BasicFacilityDto.java Added
    Open in IDE #permalink
    /src/.../referencedata/BasicProgramDto.java Added
    Open in IDE #permalink
    /src/.../referencedata/PermissionStringDto.java Added
    Open in IDE #permalink
    /src/main/.../referencedata/ProgramDto.java Added
    Open in IDE #permalink
    /src/main/.../dto/referencedata/RightDto.java Added
    Open in IDE #permalink
    /src/main/.../dto/referencedata/RightType.java Added
    Open in IDE #permalink
    /src/.../referencedata/RoleAssignmentDto.java Added
    Open in IDE #permalink
    /src/main/.../dto/referencedata/RoleDto.java Added
    Open in IDE #permalink
    /src/main/.../dto/referencedata/UserDto.java Added
    Open in IDE #permalink
    /src/.../requisition/BasicProcessingPeriodDto.java Added
    Open in IDE #permalink
    /src/.../requisition/BasicRequisitionDto.java Added
    Open in IDE #permalink
    /src/.../requisition/ProcessingPeriodDto.java Added
    Open in IDE #permalink
    /src/.../requisition/ProcessingScheduleDto.java Added
    Open in IDE #permalink
    /src/main/.../requisition/RequisitionDto.java Changed
    Open in IDE #permalink
    /src/.../requisition/RequisitionStatus.java Added
    Open in IDE #permalink
    /src/.../exception/AuthenticationMessageException.java Added
    Open in IDE #permalink
    /src/.../exception/PermissionMessageException.java Added
    Open in IDE #permalink
    /src/main/.../common/i18n/MessageKeys.java Changed
    Open in IDE #permalink
    /src/main/.../i18n/PermissionMessageKeys.java Added
    Open in IDE #permalink
    /src/.../referencedata/UserReferenceDataService.java Added
    Open in IDE #permalink
    /src/.../requisition/BaseRequisitionService.java Changed
    Open in IDE #permalink
    /src/.../requisition/QuantificationService.java Added 1
    Open in IDE #permalink
    /src/.../requisition/RequisitionService.java Changed
    Open in IDE #permalink
    /src/main/.../service/PermissionService.java Added 2
    Open in IDE #permalink
    /src/main/.../service/PermissionStrings.java Added
    Open in IDE #permalink
    /src/main/.../service/RequestHeaders.java Changed
    Open in IDE #permalink
    /src/main/.../service/RequestParameters.java Changed
    Open in IDE #permalink
    /src/main/.../service/ServiceResponse.java Changed
    Open in IDE #permalink
    /src/main/.../util/AuthenticationHelper.java Added
    Open in IDE #permalink
    /src/main/.../util/CustomSortSerializer.java Added
    Open in IDE #permalink
    /src/.../web/QuantificationController.java Added 3
    Open in IDE #permalink
    /src/main/resources/api-definition.yaml Changed 6
    Open in IDE #permalink

    Review updated: Reload | Ignore | Collapse

    You cannot reload the review while writing a comment.

    Log time