FEOLMIS-4335 OLMIS-7248: Fix product creation in Products view - Closed

closed on 27 Apr 21

Author

Reviewers

OLMIS-7248: Fix product creation in Products view

Activity

Details
Objectives
General Comments 1
Unresolved
Resolved
Number of files included: 3

openlmis-referencedata 0
- Folder src 0
  - Folder main/java/org/openlmis/referencedata/validate 0
    - File OrderableValidator.java 0 Remove
  - Folder test/java/org/openlmis/referencedata/validate 0
    - File OrderableValidatorTest.java 0 Remove
- File CHANGELOG.md 0 Remove

#permalink

Details

Warning: no files are visible, they have all been filtered.

Participant	Role	Time Spent	Comments	Latest Comment
Paweł Muchowski	Author	10m
Aleksandra Sołtys	Reviewer - Complete	4m	1	Could you add a test for this?
Total		14m	1

#permalink

Objectives

There are no specific objectives for this review.

Branches in review

Issues Raised From Comments

Key	Summary	State	Assignee

#permalink

General Comments

Aleksandra Sołtys

Could you add a test for this?

Could you add a test for this?

27 Apr 21

Click to load diff

Click to load diff

Click to load diff

Atlassian Fisheye analysis with Crucible code review. (Version:4.8.5 Build:20201208124951 2020-12-08 12:52) - Administration - Page generated 2023-05-29 08:15 +0000

Crucible (Server) Unlimited Users: Open Source License License registered to OpenLMIS.

Version 4.8.12 is available. Note: you will need to extend the maintenance on your license to take advantage of this upgrade.

Review updated: Reload | Ignore | Collapse

You cannot reload the review while writing a comment.

Notation	Description
[Crucible Review CR-1\|CR-1]	Creates a link to a Crucible review or FishEye artifact using the internal key reference for the item. Example: Crucible Review CR-1
[Atlassian Crucible\|http://atlassian.com/crucible]	Creates a link to an external resource, special characters that come after the URL and are not part of it must be separated with a space. External links are denoted with an arrow icon. Example: Atlassian Crucible
{cs:id=1\|rep=repository-key}	Render a link to the changeset Example: 1
bold	Makes text appear bold.
_italic_	Makes text appear in italics.
+underline+	Makes text appear underlined.
??citation??	Makes text appear in citation form.
-strikethrough-	Makes text appear ~~struck through~~.
^superscript^	Makes text appear in ^superscript.
~subscript~	Makes text appear in _subscript.
{{ monospaced }}	Placing double curly-brackets around text makes it appear `monospaced`.
{code} // Some comments here public String getFoo() { return foo; } {code}	The code macro displays a preformatted block for showing code with syntax highlighting. Example: // Some comments here public String getFoo() { return foo; }
bq. Block Quote	To make an entire paragraph into a block quotation, place "bq. " before it. Example: Block Quote
{quote} here is quoteable content to be quoted {quote}	Quote a block of text that's longer than one paragraph. Example: here is quoteable content to be quoted
{color:red} look ma, red text!{color}	Changes the color of a block of text. Example: look ma, red text!
* A list with bullets * Second item ** Indented item	Example: A list with bullets Second item Indented item
# A list with numbers # Second item ## Indented item	Example: A list with numbers Second item Indented item

Full notation guide

Log time