TZUP-77 : Create Drop Down Menu to List Equipment Types

Activity

FEOLMIS-4333 4

Keyboard shortcuts  
  • Summarize the review outcomes (optional)
     
    #permalink

    Details

    Warning: no files are visible, they have all been filtered.
    Participant Role Time Spent Comments Latest Comment
    Author 30m 1 This makes sense
    Reviewer - 8% reviewed 0m    
    Reviewer - 0% reviewed      
    Reviewer - Complete 10m 3 This should be pluralized, equipment_types
    Total   40m 4  
    #permalink

    Objectives

    Added APIs to manage equipment types for LEM feature

    Branches in review

    #permalink

    Issues Raised From Comments

    Key Summary State Assignee
    #permalink

    General Comments

    Chongsun Ahn

    Generally looks good. See my other comment.

    Generally looks good. See my other comment.

    /src/.../repository/EquipmentTypeRepositoryIntegrationTest.java Added
    Open in IDE #permalink
    /src/.../web/BaseWebIntegrationTest.java Changed
    Open in IDE #permalink
    /src/.../web/EquipmentTypeControllerIntegrationTest.java Added
    Open in IDE #permalink
    /src/main/.../domain/EquipmentType.java Added
    Open in IDE #permalink
    /src/main/.../dto/EquipmentTypeDto.java Added
    Open in IDE #permalink
    /src/main/.../equipment/i18n/MessageKeys.java Changed
    Open in IDE #permalink
    /src/.../repository/EquipmentTypeRepository.java Added
    Open in IDE #permalink
    /src/main/.../web/BaseController.java Changed
    Open in IDE #permalink
    /src/main/.../web/EquipmentTypeController.java Added
    Open in IDE #permalink
    /src/.../migration/20210423104548818__create_equipment_type_table.sql Added 3
    Open in IDE #permalink
    /src/main/.../schemas/equipmentType.json Added
    Open in IDE #permalink
    /src/main/.../schemas/equipmentTypePage.json Added
    Open in IDE #permalink
    /src/main/resources/api-definition.yaml Changed
    Open in IDE #permalink
    /src/.../util/EquipmentTyeDataBuilder.java Added
    Open in IDE #permalink
    /src/.../web/EquipmentTypeControllerTest.java Added
    Open in IDE #permalink

    Review updated: Reload | Ignore | Collapse

    You cannot reload the review while writing a comment.

    Log time