API changes to enable approver unskip requisition line items

Activity

FEOLMIS-4332 15

Keyboard shortcuts  
  • Summarize the review outcomes (optional)
     
    #permalink

    Details

    Warning: no files are visible, they have all been filtered.
    Participant Role Time Spent Comments Latest Comment
    Author 3h 2m 6 There are three object involved when updating a requisiti...
    Reviewer - 81% reviewed 27m 6 Probably create a new resource, like /requisitionSettings...
    Reviewer - 61% reviewed 3m    
    Reviewer - 61% reviewed 19m 3 LGTM
    Total   3h 51m 15  
    #permalink

    Objectives

    API additions to enable approver unskip skipped requisition line items

    Branches in review

    #permalink

    Issues Raised From Comments

    Key Summary State Assignee
    #permalink

    General Comments

    Ian

    Don't we need to be able to turn this feature off for countries that don't wa...

    Don't we need to be able to turn this feature off for countries that don't want to use it?

    Elly Makuba

    Yes I made it configurable through an environment variable then added an end-...

    Yes I made it configurable through an environment variable then added an end-point in RequisitionController class to fetch that value. The client will request the environment variable from the server, when set to false the approver will not be able to unskip line items.

    Ian

    Okay

    Okay

    Ian

    LGTM

    LGTM

    Chongsun Ahn

    It's not clear when skipped line items can be unskipped. When AUTHORIZED and ...

    It's not clear when skipped line items can be unskipped. When AUTHORIZED and APPROVED? Or just AUTHORIZED?

    Elly Makuba

    Only when AUTHORIZED, once approved there can never be changes.

    Only when AUTHORIZED, once approved there can never be changes.

    Chongsun Ahn

    Then why does the RequisitionBuilderTest seems to set skipped when status is ...

    Then why does the RequisitionBuilderTest seems to set skipped when status is approved?

    Elly Makuba

    I have corrected this, the shouldNotSetSkippedIfRequisitionStatusIsApproved m...

    I have corrected this, the shouldNotSetSkippedIfRequisitionStatusIsApproved mehtod is now working as expected.

    Chongsun Ahn

    I am also wondering where the logic is to allow something can be unskipped if...

    I am also wondering where the logic is to allow something can be unskipped if status is authorized?

    Elly Makuba

    I have added this ; (!requisition.isApproved()) { if (requisitionLineItem.get...

    I have added this ;
    (!requisition.isApproved()) {
    if (requisitionLineItem.getSkipped() != null)

    Unknown macro: { this.skipped = requisitionLineItem.getSkipped(); }

    else

    Unknown macro: { this.skipped = false; }

    }

    in RequisitionLineItem class to only allow unskipping before approval status, that works for authorized status.

    /src/main/.../requisition/Requisition.java Changed
    Open in IDE #permalink
    /src/.../requisition/RequisitionBuilder.java Changed
    Open in IDE #permalink
    /src/.../requisition/RequisitionLineItem.java Changed 2
    Open in IDE #permalink
    /src/.../service/ConfigurationSettingService.java Changed
    Open in IDE #permalink
    /src/main/.../web/ConfigurationController.java Added
    Open in IDE #permalink
    /src/main/.../web/RequisitionController.java Changed 3
    Open in IDE #permalink
    /src/main/resources/messages_en.properties Changed
    Open in IDE #permalink
    /src/.../requisition/RequisitionLineItemTest.java Changed
    Open in IDE #permalink
    /src/.../domain/RequisitionBuilderTest.java Changed
    Open in IDE #permalink
    /CHANGELOG.md Changed
    Open in IDE #permalink

    Review updated: Reload | Ignore | Collapse

    You cannot reload the review while writing a comment.

    Log time