OLMIS-1229: Improve validation and beginning balance update

Activity

FEOLMIS-431 6

Keyboard shortcuts  
  • Summarize the review outcomes (optional)
     
    #permalink

    Details

    Warning: no files are visible, they have all been filtered.
    Participant Role Time Spent Comments Latest Comment
    Author 23m 1 There was some issue with beginning balance set to null w...
    Reviewer - 100% reviewed 10m 2 I'm closing this - we can live without this refactor
    Reviewer - 100% reviewed 7m 2 Paweł Gesek It seems like those changes are on branch. Sh...
    Total   39m 6  
    #permalink

    Objectives

    There are no specific objectives for this review.

    Branches in review

    #permalink

    Issues Raised From Comments

    Key Summary State Assignee
    #permalink

    General Comments

    Łukasz Lewczyński

    Paweł Gesek It seems like those changes are on branch. Should they be merged ...

    Paweł Gesek It seems like those changes are on branch. Should they be merged into master? The ticket is closed so do we need those changes?

    Sebastian Brudziński

    Paweł Gesek I'm not sure what's the status of this review, since the ticket i...

    Paweł Gesek I'm not sure what's the status of this review, since the ticket it's linked to is invalid (the changes here do not match the ticket at all). Is there anything left to do here?

    Paweł Gesek

    I'm closing this - we can live without this refactor

    I'm closing this - we can live without this refactor

    /src/main/.../domain/Requisition.java Changed
    Open in IDE #permalink
    /src/main/.../domain/RequisitionLineItem.java Changed 3
    Open in IDE #permalink
    /src/.../validate/DraftRequisitionValidator.java Changed
    Open in IDE #permalink
    /src/.../validate/RequisitionValidator.java Changed
    Open in IDE #permalink
    /src/.../domain/RequisitionLineItemTest.java Changed
    Open in IDE #permalink
    /src/.../validate/DraftRequisitionValidatorTest.java Changed
    Open in IDE #permalink
    /src/.../validate/RequisitionValidatorTest.java Changed
    Open in IDE #permalink

    Review updated: Reload | Ignore | Collapse

    You cannot reload the review while writing a comment.

    Log time against