This is a list of all comments for FEOLMIS-4298.

Review Summary: No summary


----------------------------------------
File: src/offline-events/events.service.js
Revision Comment by Aleksandra Sołtys on 03 March 2021, 07:47 
https://review.openlmis.org/cru/FEOLMIS-4298#c22378

  Do you think you can extract something from the functions
  getOfflineEvents or combineResponses to make them a little
  smaller?

  Reply by Paulina Buzderewicz on 03 March 2021, 09:02
  > I have managed to extract some parts of code

Revision Comment by Aleksandra Sołtys on 03 March 2021, 07:15 
https://review.openlmis.org/cru/FEOLMIS-4298#c22376

  This function is only used by getOfflineEvents but should also
  be used by pending-offline-events.service.decorator

  Reply by Paulina Buzderewicz on 03 March 2021, 08:05
  > Hmm.. but from what I see, in the
  > pending-offline-events.service.decorator we use only the
  > getOfflineEvents function

    Reply by Aleksandra Sołtys on 03 March 2021, 08:21
    > Yes, but pending-offline-events.service.decorator should
    > use getUserEventsFromStorage because we don't need there
    > all the information that the getOfflineEvents returns

      Reply by Paulina Buzderewicz on 03 March 2021, 09:39
      > Oh, I see :)

Revision Comment by Aleksandra Sołtys on 03 March 2021, 07:18 
https://review.openlmis.org/cru/FEOLMIS-4298#c22377

  The description of this function and the
  getUserEventsFromStorage are the same. However, this function
  returns more information

  Reply by Paulina Buzderewicz on 03 March 2021, 09:03
  > Updated


---

ID: FEOLMIS-4298 https://review.openlmis.org/cru/FEOLMIS-4298

Title: OLMIS-7198: Added tests for event searching
Statement of Objectives:


State: Closed

Summary: 

Author: Klaudia Pałkowska
Reviewers: (1 active, 1 completed*)
     Aleksandra Sołtys   (*)
     Paulina Buzderewicz