FEOLMIS-4243 TZUP-156 : Backend to store reason for R&R been rejected

closed on 28 Feb

Author

Reviewers

TZUP-156 : Backend to store reason for R&R been rejected

Activity

Details
Objectives
General Comments 2
Unresolved
Resolved
Number of files included: 17

openlmis-requisition 0
- Folder src 0
  - Folder integration-test/java/org/openlmis/requisition/web 0
    - File RequisitionControllerIntegrationTest.java 0 Remove
  - Folder main 0
    - Folder java/org/openlmis/requisition 0
      - Folder domain 0
        
        Folder requisition 0
        
        File StatusChange.java 0 Remove
        
        File Rejection.java 0 Remove
      - Folder dto 0
        
        File RejectionDto.java 1 Remove
        
        File StatusChangeDto.java 0 Remove
      - Folder i18n 0
        
        File MessageKeys.java 0 Remove
      - Folder repository 0
        
        File RejectionRepository.java 0 Remove
      - Folder service 0
        
        File RequisitionService.java 7 Remove
      - Folder web 0
        
        File RequisitionController.java 1 Remove
    - Folder resources 0
      - Folder db/migration 0
        
        File 20201117130741211__schema_for_requisition_rejection_table.sql 0 Remove
      - Folder schemas 0
        
        File rejectionDto.json 0 Remove
      - File api-definition.yaml 0 Remove
      - File messages_en.properties 0 Remove
  - Folder test/java/org/openlmis/requisition 0
    - Folder service 0
      - File RequisitionServiceTest.java 0 Remove
    - Folder testutils 0
      - File RejectionDataBuilder.java 0 Remove
    - Folder web 0
      - File RequisitionControllerTest.java 0 Remove
- File CHANGELOG.md 0 Remove

#permalink

Details

Warning: no files are visible, they have all been filtered.

Participant	Role	Time Spent	Comments	Latest Comment
Ian	Author	57m	4	Done
Elias	Reviewer - Complete	18m	1	Is a CHANGELOG entry created for this code?
Chongsun Ahn	Reviewer - Complete	21m	6	Instead of just checking it is not null, shouldn't we be ...
Total		1h 36m	11

#permalink

Objectives

There are no specific objectives for this review.

Branches in review

#permalink

Issues Raised From Comments

Key	Summary	State	Assignee

#permalink

General Comments

Elias

Is a CHANGELOG entry created for this code?

03 Feb

Elias

Resolved

22 Feb

Ian

Done

22 Feb

Click to load diff

Notation	Description
[Crucible Review CR-1\|CR-1]	Creates a link to a Crucible review or FishEye artifact using the internal key reference for the item. Example: Crucible Review CR-1
[Atlassian Crucible\|http://atlassian.com/crucible]	Creates a link to an external resource, special characters that come after the URL and are not part of it must be separated with a space. External links are denoted with an arrow icon. Example: Atlassian Crucible
{cs:id=1\|rep=repository-key}	Render a link to the changeset Example: 1
bold	Makes text appear bold.
_italic_	Makes text appear in italics.
+underline+	Makes text appear underlined.
??citation??	Makes text appear in citation form.
-strikethrough-	Makes text appear ~~struck through~~.
^superscript^	Makes text appear in ^superscript.
~subscript~	Makes text appear in _subscript.
{{ monospaced }}	Placing double curly-brackets around text makes it appear `monospaced`.
{code} // Some comments here public String getFoo() { return foo; } {code}	The code macro displays a preformatted block for showing code with syntax highlighting. Example: // Some comments here public String getFoo() { return foo; }
bq. Block Quote	To make an entire paragraph into a block quotation, place "bq. " before it. Example: Block Quote
{quote} here is quoteable content to be quoted {quote}	Quote a block of text that's longer than one paragraph. Example: here is quoteable content to be quoted
{color:red} look ma, red text!{color}	Changes the color of a block of text. Example: look ma, red text!
* A list with bullets * Second item ** Indented item	Example: A list with bullets Second item Indented item
# A list with numbers # Second item ## Indented item	Example: A list with numbers Second item Indented item

FEOLMIS-4243

TZUP-156 : Backend to store reason for R&R been rejected

FEOLMIS-4243 11

Details

Objectives

Branches in review

Issues Raised From Comments

General Comments

Elias

Ian

Log time

TZUP-156 : Backend to store reason for R&R been rejected

FEOLMIS-4243 11

Summarize the review outcomes (optional)

Details

Objectives

Branches in review

Issues Raised From Comments

General Comments

Elias

Ian

Log time