FEOLMIS-4229 OLMIS-7165: Added test for saving data to local database with docId param

closed on 11 Jan 21

Author

Reviewers

OLMIS-7165: Added test for saving data to local database with docId param

Activity

Details
Objectives
General Comments 0
Unresolved
Resolved
Number of files included: 26

openlmis-stockmanagement-ui 0
- Folder src 0
  - Folder stock-adjustment-creation 0
    - File destination-cache.run.js 0 Remove
    - File source-cache.run.js 0 Remove
    - File source-destination.service.js 0 Remove
    - File source-destination.service.spec.js 0 Remove
  - Folder stock-card-summary 0
    - File stock-card-summary-repository-impl.js 0 Remove
    - File stock-card-summary-repository-impl.spec.js 0 Remove
    - File stock-card-summary-resource.js 0 Remove
    - File stock-card-summary-resource.spec.js 0 Remove
  - Folder stock-products 0
    - File full-stock-card-summary-cache.run.js 0 Remove
    - File full-stock-card-summary-cache.run.spec.js 0 Remove
    - File full-stock-card-summary-repository-impl.js 1 Remove
    - File full-stock-card-summary-repository-impl.spec.js 2 Remove
  - Folder stock-reason 0
    - File stock-reason-cache.run.js 0 Remove
    - File stock-reason-cache.run.spec.js 1 Remove
    - File stock-reason.module.js 0 Remove
    - File stock-reasons.factory.js 0 Remove
  - Folder stock-valid-destinations 0
    - File destination-cache.run.js 0 Remove
    - File destination-cache.run.spec.js 0 Remove
    - File stock-valid-destinations.module.js 0 Remove
  - Folder stock-valid-sources 0
    - File source-cache.run.js 0 Remove
    - File source-cache.run.spec.js 0 Remove
    - File stock-valid-sources.module.js 0 Remove
- File CHANGELOG.md 0 Remove
openlmis-ui-components 0
- Folder src/openlmis-cached-repository 0
  - File openlmis-cached-resource.js 0 Remove
  - File openlmis-cached-resource.spec.js 0 Remove
- File CHANGELOG.md 0 Remove

#permalink

Details

Warning: no files are visible, they have all been filtered.

Participant	Role	Time Spent	Comments	Latest Comment
Paulina Buzderewicz	Author	26m	1	Actually we shouldn't, because the query method in this r...
Klaudia Pałkowska	Reviewer - Complete	19m	1	Can't we use ReasonDataBuilder here?
Aleksandra Sołtys	Reviewer - Complete	38m	2	We probably should also add the docId parameter
Total		1h 24m	4

#permalink

Objectives

There are no specific objectives for this review.

Branches in review

#permalink

Issues Raised From Comments

Key	Summary	State	Assignee

Notation	Description
[Crucible Review CR-1\|CR-1]	Creates a link to a Crucible review or FishEye artifact using the internal key reference for the item. Example: Crucible Review CR-1
[Atlassian Crucible\|http://atlassian.com/crucible]	Creates a link to an external resource, special characters that come after the URL and are not part of it must be separated with a space. External links are denoted with an arrow icon. Example: Atlassian Crucible
{cs:id=1\|rep=repository-key}	Render a link to the changeset Example: 1
bold	Makes text appear bold.
_italic_	Makes text appear in italics.
+underline+	Makes text appear underlined.
??citation??	Makes text appear in citation form.
-strikethrough-	Makes text appear ~~struck through~~.
^superscript^	Makes text appear in ^superscript.
~subscript~	Makes text appear in _subscript.
{{ monospaced }}	Placing double curly-brackets around text makes it appear `monospaced`.
{code} // Some comments here public String getFoo() { return foo; } {code}	The code macro displays a preformatted block for showing code with syntax highlighting. Example: // Some comments here public String getFoo() { return foo; }
bq. Block Quote	To make an entire paragraph into a block quotation, place "bq. " before it. Example: Block Quote
{quote} here is quoteable content to be quoted {quote}	Quote a block of text that's longer than one paragraph. Example: here is quoteable content to be quoted
{color:red} look ma, red text!{color}	Changes the color of a block of text. Example: look ma, red text!
* A list with bullets * Second item ** Indented item	Example: A list with bullets Second item Indented item
# A list with numbers # Second item ## Indented item	Example: A list with numbers Second item Indented item

FEOLMIS-4229

OLMIS-7165: Added test for saving data to local database with docId param

FEOLMIS-4229 4

Details

Objectives

Branches in review

Issues Raised From Comments

General Comments

Log time

OLMIS-7165: Added test for saving data to local database with docId param

FEOLMIS-4229 4

Summarize the review outcomes (optional)

Details

Objectives

Branches in review

Issues Raised From Comments

General Comments

Log time