OLMIS-6957: Added Contract test for Stock Management extension validators

Activity

FEOLMIS-4179 13

Keyboard shortcuts  
  • Summarize the review outcomes (optional)
     
    #permalink

    Details

    Warning: no files are visible, they have all been filtered.
    Participant Role Time Spent Comments Latest Comment
    Author 22m 4 I was considering having only the messages which are used...
    Reviewer - Complete 26m 7 Looks good to me! I only noticed one typo - left a comment
    Reviewer - Complete 36m 2 Good job https://review.openlmis.org/static/ql0uca/2stati...
    Reviewer - 0% reviewed 5m    
    Total   1h 30m 13  
    #permalink

    Objectives

    There are no specific objectives for this review.

    Branches in review

    #permalink

    Issues Raised From Comments

    Key Summary State Assignee
    #permalink

    General Comments

    Klaudia Pałkowska

    Good job https://review.openlmis.org/static/ql0uca/2static/images/wiki/icons/...

    Good job

    Paulina Buzderewicz

    Thank you!

    Thank you!

    Sebastian Brudziński

    General thought - looking at those tests, at the validators, and at this exam...

    General thought - looking at those tests, at the validators, and at this examplar in general, it's very difficult to find what's the difference between the original version and the extended version. We should go ahead and completely change those 3 validators and their names.

    Some ideas:
    NoneValidator - an extension that demonstrates how to switch off one validator completely (it always passes)
    OnlyLoggingValidator - an extension to a validator that only prints warning but doesn't fail validation - perhaps difficult to test
    NoKitsValidator - a validator that prevents the use of kits - it always fails when kits are used

    In general - avoid subtle changes, but demonstrate that you can completely alter the validator

    Sebastian Brudziński

    Looks good to me! I only noticed one typo - left a comment

    Looks good to me! I only noticed one typo - left a comment

    /src/.../stockmanagementextension/ValidatorsStepDefs.java Added
    /src/.../stockmanagementextension_tests/StockEventsTests.feature Deleted 2
    Open in IDE #permalink
    /src/.../stockmanagementextension_tests/ValidatorsTests.feature Added 1
    /.env Changed
    /docker-compose.stockmanagementextension.yml Added
    Open in IDE #permalink
    /extensions.properties Changed
    Open in IDE #permalink
    /Jenkinsfile Changed
    /src/main/.../i18n/MessageKeys.java Deleted 3
    Open in IDE #permalink
    /src/.../validators/ExtensionAdjustmentReasonValidator.java Deleted
    Open in IDE #permalink
    /src/.../validators/ExtensionFreeTextValidator.java Deleted
    Open in IDE #permalink
    /src/.../validators/ExtensionUnpackKitValidator.java Deleted
    Open in IDE #permalink
    /src/main/.../validators/NoKitsValidator.java Added
    Open in IDE #permalink
    /src/main/.../validators/NoneValidator.java Added
    Open in IDE #permalink
    /src/.../validators/ReasonFreeTextValidator.java Added
    Open in IDE #permalink
    /src/main/resources/messages_en.properties Deleted 3
    Open in IDE #permalink

    Review updated: Reload | Ignore | Collapse

    You cannot reload the review while writing a comment.

    Log time