TZUP-136: Created an interface api to manage budgets

Activity

FEOLMIS-4166 11

Keyboard shortcuts  
  • Summarize the review outcomes (optional)
     
    #permalink

    Details

    Warning: no files are visible, they have all been filtered.
    Participant Role Time Spent Comments Latest Comment
    Author 34m 5 I have added more integration tests for budget and requis...
    Reviewer - 1% reviewed 5m    
    Reviewer - 0% reviewed      
    Reviewer - 54% reviewed 16m 6 Replaced by http://review.openlmis.org/cru/FEOLMIS-4184.
    Total   55m 11  
    #permalink

    Objectives

    There are no specific objectives for this review.

    Branches in review

    #permalink

    Issues Raised From Comments

    Key Summary State Assignee
    #permalink

    General Comments

    Chongsun Ahn

    Can you give some context to all these changes? This looks too much for one r...

    Can you give some context to all these changes? This looks too much for one review.

    hassan

    Actually is the budget API codes including other files to communicate with re...

    Actually is the budget API codes including other files to communicate with reference data service eg. we need to get facilities by code and program as well.Chongsun Ahn

    Chongsun Ahn

    I am wondering where are the integration tests for the budget repository and ...

    I am wondering where are the integration tests for the budget repository and budget APIs?

    hassan

    I have added more integration tests for budget and requisition budget APIs Ch...

    I have added more integration tests for budget and requisition budget APIs Chongsun Ahn

    Chongsun Ahn

    Also, I don't see that you have added the APIs to the RAML.

    Also, I don't see that you have added the APIs to the RAML.

    hassan

    Chongsun Ahn I have included them in RAML

    Chongsun Ahn I have included them in RAML

    Chongsun Ahn

    Replaced by http://review.openlmis.org/cru/FEOLMIS-4184.

    Replaced by http://review.openlmis.org/cru/FEOLMIS-4184.

    /src/.../repository/BudgetRepositoryIntegrationTest.java Added
    Open in IDE #permalink
    /src/.../repository/RequisitionBudgetRepositoryTest.java Added
    /src/.../repository/SourceOfFundRepositoryIntegrationTest.java Added
    /src/.../web/BaseWebIntegrationTest.java Changed
    /src/.../web/BudgetControllerIntegrationTest.java Added
    /src/.../web/RequisitionBudgetControllerIntegrationTest.java Added
    /src/.../web/SourceOfFundControllerIntegrationTest.java Added
    /src/main/.../budget/domain/BaseEntity.java Changed
    Open in IDE #permalink
    /src/main/java/.../budget/domain/Budget.java Added
    Open in IDE #permalink
    /src/main/.../budget/dto/BasicProgramDto.java Added
    Open in IDE #permalink
    /src/main/java/.../budget/dto/FacilityDto.java Added
    Open in IDE #permalink
    /src/main/.../dto/MinimalFacilityDto.java Added
    Open in IDE #permalink
    /src/main/.../dto/ObjectReferenceDto.java Added
    Open in IDE #permalink
    /src/main/java/.../budget/dto/ProgramDto.java Added
    Open in IDE #permalink
    /src/main/java/.../budget/dto/ResultDto.java Added
    Open in IDE #permalink
    /src/main/.../dto/UserObjectReferenceDto.java Added
    Open in IDE #permalink
    /src/main/.../exception/NotFoundException.java Changed
    Open in IDE #permalink
    /src/main/.../budget/i18n/MessageKeys.java Changed
    /src/main/.../repository/BudgetRepository.java Added
    Open in IDE #permalink
    /src/.../repository/RequisitionBudgetRepository.java Changed
    /src/.../repository/SourceOfFundRepository.java Changed
    /src/.../referencedata/BaseReferenceDataService.java Added
    Open in IDE #permalink
    /src/.../referencedata/FacilityReferenceDataService.java Added
    Open in IDE #permalink
    /src/.../referencedata/ProgramReferenceDataService.java Added
    Open in IDE #permalink
    /src/main/.../budget/service/AuthService.java Added
    Open in IDE #permalink
    /src/.../service/BaseCommunicationService.java Added
    Open in IDE #permalink
    /src/main/.../service/BudgetService.java Added
    Open in IDE #permalink
    /src/.../service/DataRetrievalException.java Added
    Open in IDE #permalink
    /src/main/java/.../budget/service/PageDto.java Added
    Open in IDE #permalink
    /src/main/.../service/RequestHeaders.java Added
    Open in IDE #permalink
    /src/main/.../service/RequestParameters.java Added
    Open in IDE #permalink
    /src/main/.../service/ServiceResponse.java Added
    Open in IDE #permalink
    /src/.../util/BaseParameterizedTypeReference.java Added
    Open in IDE #permalink
    /src/main/.../util/CustomSortDeserializer.java Added
    Open in IDE #permalink
    /src/main/.../util/CustomSortSerializer.java Added
    Open in IDE #permalink
    /src/main/java/.../budget/util/DateHelper.java Added
    Open in IDE #permalink
    /src/.../util/DynamicPageTypeReference.java Added
    Open in IDE #permalink
    /src/.../util/DynamicResultDtoTypeReference.java Added
    Open in IDE #permalink
    /src/main/java/.../budget/util/Merger.java Added
    Open in IDE #permalink
    /src/main/.../budget/util/RequestHelper.java Added
    Open in IDE #permalink
    /src/main/.../budget/BaseBudgetController.java Deleted 2
    Open in IDE #permalink
    /src/main/.../web/budget/BudgetController.java Added
    /src/main/java/.../web/budget/BudgetDto.java Added
    Open in IDE #permalink
    /src/.../budget/RequisitionBudgetController.java Changed
    /src/.../budget/SourceOfFundController.java Changed
    /src/main/java/.../budget/web/BaseDto.java Changed
    /src/.../migration/20201021110644049__update_budgets_change_lastupdated_column_type.sql Added
    Open in IDE #permalink
    /src/main/resources/schemas/budgetDto.json Added
    Open in IDE #permalink
    /src/main/.../schemas/budgetPage.json Added
    Open in IDE #permalink
    /src/.../schemas/requisitionBudgetDto.json Added
    Open in IDE #permalink
    /src/.../schemas/requisitionBudgetPage.json Added
    Open in IDE #permalink
    /src/main/.../schemas/sourceOfFund.json Added
    Open in IDE #permalink
    /src/main/.../schemas/sourceOfFundPage.json Added
    Open in IDE #permalink
    /src/main/resources/api-definition.yaml Changed 2
    /src/main/resources/application.properties Changed
    /src/main/resources/messages_en.properties Changed
    /src/test/.../domain/BudgetDataBuilder.java Added
    Open in IDE #permalink
    /src/test/.../budget/domain/BudgetTest.java Added
    Open in IDE #permalink
    /src/.../domain/RequisitionBudgetDataBuilder.java Added
    Open in IDE #permalink
    /src/test/java/.../util/api/DataBuilder.java Added
    Open in IDE #permalink
    /src/test/.../util/api/DtoDataBuilder.java Added
    Open in IDE #permalink
    /src/test/.../api/RepositoryDataBuilder.java Added
    Open in IDE #permalink
    /src/test/.../budget/util/DateHelperTest.java Added
    Open in IDE #permalink
    /src/test/.../budget/util/DtoGenerator.java Added
    Open in IDE #permalink
    /src/test/.../web/budget/BudgetDtoTest.java Added
    Open in IDE #permalink
    /src/.../budget/SourceOfFundDataBuilder.java Changed
    /CHANGELOG.MD Changed

    Review updated: Reload | Ignore | Collapse

    You cannot reload the review while writing a comment.

    Log time against