TZUP-135:created an api to manage sources of fund.

Activity

FEOLMIS-4165 28

Keyboard shortcuts  
  • Summarize the review outcomes (optional)
     
    #permalink

    Details

    Warning: no files are visible, they have all been filtered.
    Participant Role Time Spent Comments Latest Comment
    Author 1h 40m 8 Chongsun Ahn I have updated the files ..it seems like fil...
    Reviewer - 0% reviewed 0m    
    Reviewer - 0% reviewed      
    Reviewer - 65% reviewed 45m 20 Has been replaced with http://review.openlmis.org/cru/FEO...
    Total   2h 25m 28  
    #permalink

    Objectives

    There are no specific objectives for this review.

    Branches in review

    #permalink

    Issues Raised From Comments

    Key Summary State Assignee
    #permalink

    General Comments

    Chongsun Ahn

    Looks like just a modification of the widget? LGTM.

    Looks like just a modification of the widget? LGTM.

    hassan

    I have refactored this API by removing unnecessary Widgets in the controller ...

    I have refactored this API by removing unnecessary Widgets in the controller Chongsun Ahn

    Chongsun Ahn

    I don't see that you have modified the RAML to include these new APIs.

    I don't see that you have modified the RAML to include these new APIs.

    hassan

    I have included Sources of Fund APIs in RAML and also added the integration t...

    I have included Sources of Fund APIs in RAML and also added the integration tests for Sources of fund ..Chongsun Ahn

    Chongsun Ahn

    I have added some more comments.

    I have added some more comments.

    Chongsun Ahn

    Hassan, this review does not seem up-to-date. Some test classes are empty. I'...

    Hassan, this review does not seem up-to-date. Some test classes are empty. I'm afraid I cannot do a proper review until it is updated.

    hassan

    Chongsun Ahn I have updated the files ..it seems like files were outdated ..

    Chongsun Ahn I have updated the files ..it seems like files were outdated ..

    Chongsun Ahn

    Has been replaced with http://review.openlmis.org/cru/FEOLMIS-4182.

    Has been replaced with http://review.openlmis.org/cru/FEOLMIS-4182.

    /src/.../repository/BudgetRepositoryIntegrationTest.java Added 1
    Open in IDE #permalink
    /src/.../repository/RequisitionBudgetRepositoryTest.java Added 1
    /src/.../repository/SourceOfFundRepositoryIntegrationTest.java Added 2
    /src/.../web/BaseWebIntegrationTest.java Changed
    /src/.../web/BudgetControllerIntegrationTest.java Added 2
    /src/.../web/RequisitionBudgetControllerIntegrationTest.java Added 1
    /src/.../web/SourceOfFundControllerIntegrationTest.java Added 2
    /src/main/java/.../budget/domain/Budget.java Changed
    Open in IDE #permalink
    /src/main/.../dto/ObjectReferenceDto.java Added
    Open in IDE #permalink
    /src/main/.../dto/UserObjectReferenceDto.java Added
    Open in IDE #permalink
    /src/main/.../budget/i18n/MessageKeys.java Changed
    /src/main/.../budget/i18n/MessageKeys.java Changed
    /src/.../repository/RequisitionBudgetRepository.java Changed
    /src/.../repository/SourceOfFundRepository.java Changed
    /src/main/.../validate/BaseValidator.java Added
    Open in IDE #permalink
    /src/.../validate/SourceOfFundValidator.java Added 2
    /src/main/.../budget/BaseBudgetController.java Deleted
    Open in IDE #permalink
    /src/main/.../web/budget/BudgetController.java Changed
    /src/.../budget/RequisitionBudgetController.java Changed
    /src/.../budget/SourceOfFundController.java Changed
    /src/main/resources/schemas/budgetDto.json Added
    Open in IDE #permalink
    /src/main/.../schemas/budgetPage.json Added
    Open in IDE #permalink
    /src/.../schemas/requisitionBudgetDto.json Added
    Open in IDE #permalink
    /src/.../schemas/requisitionBudgetPage.json Added
    Open in IDE #permalink
    /src/main/.../schemas/sourceOfFund.json Added
    Open in IDE #permalink
    /src/main/.../schemas/sourceOfFundPage.json Added
    Open in IDE #permalink
    /src/main/resources/api-definition.yaml Changed 9
    /src/main/resources/messages_en.properties Changed
    /src/main/resources/messages_en.properties Changed
    /src/test/.../domain/BudgetDataBuilder.java Changed
    Open in IDE #permalink
    /src/.../domain/RequisitionBudgetDataBuilder.java Added
    Open in IDE #permalink
    /src/test/java/.../util/api/DataBuilder.java Added
    Open in IDE #permalink
    /src/test/.../util/api/DtoDataBuilder.java Added
    Open in IDE #permalink
    /src/test/.../api/RepositoryDataBuilder.java Added
    Open in IDE #permalink
    /src/test/.../budget/util/DtoGenerator.java Added
    Open in IDE #permalink
    /src/.../budget/SourceOfFundDataBuilder.java Changed
    /CHANGELOG.MD Changed
    /CHANGELOG.MD Changed

    Review updated: Reload | Ignore | Collapse

    You cannot reload the review while writing a comment.

    Log time against