FEOLMIS-4102 COV-23 - Create UI service to connect PCMT with OLMIS

closed on 12 May 20

Author

Reviewers

COV-23 - Create UI service to connect PCMT with OLMIS

Activity

Details
Objectives
General Comments 0
Unresolved
Resolved
Number of files included: 67

covid-ui 0
- File config.json 0 Remove
- File docker-compose.yml 0 Remove
- File yarn.lock 0 Remove
pcmt-integration-ui 0
- Folder src 0
  - Folder openlmis-home 0
    - File home-system-notifications.controller.spec.js 0 Remove
    - File home.routes.spec.js 0 Remove
  - Folder pcmt 0
    - File messages_en.json 0 Remove
    - File pcmt-controller.js 0 Remove
    - File pcmt.module.js 1 Remove
    - File pcmt.routes.js 0 Remove
  - Folder pcmt-configuration 0
    - File pcmt-configuration-data-builder.spec.js 0 Remove
    - File pcmt-configuration.js 0 Remove
    - File pcmt-configuration.module.js 0 Remove
    - File pcmt-configuration.resource.js 1 Remove
    - File pcmt-configuration.resource.spec.js 1 Remove
  - Folder pcmt-configuration-add 0
    - File messages_en.json 0 Remove
    - File pcmt-configuration-add.html 0 Remove
    - File pcmt-configuration-add.module.js 0 Remove
    - File pcmt-configuration-add.routes.js 0 Remove
  - Folder pcmt-configuration-edit 0
    - File messages_en.json 0 Remove
    - File pcmt-configuration-add-edit.controller.js 0 Remove
    - File pcmt-configuration-add-edit.controller.spec.js 0 Remove
    - File pcmt-configuration-edit.html 0 Remove
    - File pcmt-configuration-edit.module.js 0 Remove
    - File pcmt-configuration-edit.routes.js 0 Remove
    - File pcmt-configuration-form.html 0 Remove
  - Folder pcmt-configuration-list 0
    - File messages_en.json 0 Remove
    - File pcmt-configuration-list.controller.js 0 Remove
    - File pcmt-configuration-list.controller.spec.js 1 Remove
    - File pcmt-configuration-list.html 0 Remove
    - File pcmt-configuration-list.module.js 0 Remove
    - File pcmt-configuration-list.routes.js 0 Remove
  - Folder pcmt-execution 0
    - File pcmt-execution-data-builder.spec.js 1 Remove
    - File pcmt-execution.js 1 Remove
    - File pcmt-execution.module.js 0 Remove
    - File pcmt-manual-execution-data-builder.spec.js 1 Remove
    - File pcmt-manual-execution.js 1 Remove
  - Folder pcmt-execution-list 0
    - File messages_en.json 1 Remove
    - File pcmt-execution-list.controller.js 0 Remove
    - File pcmt-execution-list.controller.spec.js 0 Remove
    - File pcmt-execution-list.html 0 Remove
    - File pcmt-execution-list.routes.js 0 Remove
  - Folder pcmt-execution-request-body 0
    - File pcmt-execution-request-body-data-builder.spec.js 1 Remove
    - File pcmt-execution-request-body.js 1 Remove
  - Folder pcmt-integration 0
    - File pcmt-integration-data-builder.spec.js 0 Remove
    - File pcmt-integration.resource.js 0 Remove
    - File pcmt-integration.resource.spec.js 0 Remove
  - Folder pcmt-integration-add 0
    - File pcmt-integration-add.routes.js 0 Remove
  - Folder pcmt-integration-edit 0
    - File messages_en.json 1 Remove
    - File pcmt-integration-add-edit.controller.js 0 Remove
    - File pcmt-integration-add-edit.controller.spec.js 0 Remove
    - File pcmt-integration-edit.routes.js 0 Remove
    - File pcmt-integration-form.html 0 Remove
  - Folder pcmt-integration-execute 0
    - File messages_en.json 0 Remove
    - File pcmt-integration-execute.controller.js 0 Remove
    - File pcmt-integration-execute.controller.spec.js 1 Remove
    - File pcmt-integration-execute.html 0 Remove
    - File pcmt-integration-execute.routes.js 0 Remove
  - Folder pcmt-integration-list 0
    - File messages_en.json 2 Remove
    - File pcmt-integration-list.controller.js 0 Remove
    - File pcmt-integration-list.controller.spec.js 0 Remove
    - File pcmt-integration-list.html 0 Remove
    - File pcmt-integration-list.module.js 0 Remove
    - File pcmt-integration-list.routes.js 0 Remove
  - Folder referencedata-period 0
    - File processing-period.resource.js 0 Remove
- File config.json 0 Remove
- File docker-compose.yml 0 Remove
- File yarn.lock 0 Remove

#permalink

Details

Warning: no files are visible, they have all been filtered.

Participant	Role	Time Spent	Comments	Latest Comment
Adrian Świszcz	Author	44m
Klaudia Pałkowska	Reviewer - Complete	14m
wbulawa	Reviewer - Complete	15m	1	to remove
Jakub Jakubowski	Reviewer - Complete	32m	14	please delete allPrograms
Total		1h 47m	15

#permalink

Objectives

There are no specific objectives for this review.

Branches in review

#permalink

Issues Raised From Comments

Key	Summary	State	Assignee

#permalink

General Comments

There are no general comments on this review.

Click to load diff

/src/openlmis-home/home-system-notifications.controller.spec.js Deleted

Click to load diff

/src/pcmt-configuration/pcmt-configuration-data-builder.spec.js Deleted

Click to load diff

/src/pcmt-configuration/pcmt-configuration.js Deleted

Click to load diff

/src/pcmt-configuration/pcmt-configuration.module.js Deleted

Click to load diff

/src/pcmt-configuration/pcmt-configuration.resource.js Deleted 1 (0)

Click to load diff

/src/pcmt-configuration/pcmt-configuration.resource.spec.js Deleted 1 (0)

Click to load diff

/src/pcmt-configuration-add/messages_en.json Deleted

Click to load diff

/src/pcmt-configuration-add/pcmt-configuration-add.html Deleted

Click to load diff

/src/pcmt-configuration-add/pcmt-configuration-add.module.js Deleted

Click to load diff

/src/pcmt-configuration-add/pcmt-configuration-add.routes.js Deleted

Click to load diff

/src/pcmt-configuration-edit/messages_en.json Deleted

Click to load diff

/src/pcmt-configuration-edit/pcmt-configuration-add-edit.controller.js Deleted

Click to load diff

/src/pcmt-configuration-edit/pcmt-configuration-add-edit.controller.spec.js Deleted

Click to load diff

/src/pcmt-configuration-edit/pcmt-configuration-edit.html Deleted

Click to load diff

/src/pcmt-configuration-edit/pcmt-configuration-edit.module.js Deleted

Click to load diff

/src/pcmt-configuration-edit/pcmt-configuration-edit.routes.js Deleted

Click to load diff

/src/pcmt-configuration-edit/pcmt-configuration-form.html Deleted

Click to load diff

/src/pcmt-configuration-list/messages_en.json Deleted

Click to load diff

/src/pcmt-configuration-list/pcmt-configuration-list.controller.js Deleted

Click to load diff

/src/pcmt-configuration-list/pcmt-configuration-list.controller.spec.js Deleted 1 (0)

Click to load diff

/src/pcmt-configuration-list/pcmt-configuration-list.html Deleted

Click to load diff

/src/pcmt-configuration-list/pcmt-configuration-list.module.js Deleted

Click to load diff

/src/pcmt-configuration-list/pcmt-configuration-list.routes.js Deleted

Click to load diff

/src/referencedata-period/processing-period.resource.js Deleted

Click to load diff

Notation	Description
[Crucible Review CR-1\|CR-1]	Creates a link to a Crucible review or FishEye artifact using the internal key reference for the item. Example: Crucible Review CR-1
[Atlassian Crucible\|http://atlassian.com/crucible]	Creates a link to an external resource, special characters that come after the URL and are not part of it must be separated with a space. External links are denoted with an arrow icon. Example: Atlassian Crucible
{cs:id=1\|rep=repository-key}	Render a link to the changeset Example: 1
bold	Makes text appear bold.
_italic_	Makes text appear in italics.
+underline+	Makes text appear underlined.
??citation??	Makes text appear in citation form.
-strikethrough-	Makes text appear ~~struck through~~.
^superscript^	Makes text appear in ^superscript.
~subscript~	Makes text appear in _subscript.
{{ monospaced }}	Placing double curly-brackets around text makes it appear `monospaced`.
{code} // Some comments here public String getFoo() { return foo; } {code}	The code macro displays a preformatted block for showing code with syntax highlighting. Example: // Some comments here public String getFoo() { return foo; }
bq. Block Quote	To make an entire paragraph into a block quotation, place "bq. " before it. Example: Block Quote
{quote} here is quoteable content to be quoted {quote}	Quote a block of text that's longer than one paragraph. Example: here is quoteable content to be quoted
{color:red} look ma, red text!{color}	Changes the color of a block of text. Example: look ma, red text!
* A list with bullets * Second item ** Indented item	Example: A list with bullets Second item Indented item
# A list with numbers # Second item ## Indented item	Example: A list with numbers Second item Indented item

FEOLMIS-4102

COV-23 - Create UI service to connect PCMT with OLMIS

FEOLMIS-4102 15

Details

Objectives

Branches in review

Issues Raised From Comments

General Comments

Log time

COV-23 - Create UI service to connect PCMT with OLMIS

FEOLMIS-4102 15

Summarize the review outcomes (optional)

Details

Objectives

Branches in review

Issues Raised From Comments

General Comments

Log time