OLMIS-1111 : Contract test for initiate a Requisition, create test and demo-data...

Activity

FEOLMIS-405 4

Keyboard shortcuts  
  • Summarize the review outcomes (optional)
     
    #permalink

    Details

    Warning: no files are visible, they have all been filtered.
    Participant Role Time Spent Comments Latest Comment
    Author 35m 1 I used given annotation, because the first test was creat...
    Reviewer - Complete 2m    
    Reviewer - Complete 11m 2 In test classes I see you use @Given annotation when in *...
    Reviewer - Complete 15m 1 Łukasz Lewczyński I moved the exception and changed the a...
    Total   1h 4m 4  
    #permalink

    Objectives

    There are no specific objectives for this review.

    Branches in review

    #permalink

    Issues Raised From Comments

    Key Summary State Assignee
    #permalink

    General Comments

    Łukasz Lewczyński

    In test classes I see you use @Given annotation when in *.feature files you h...

    In test classes I see you use @Given annotation when in *.feature files you have when and then. Is it correct?

    Przemysław Studziński

    I used given annotation, because the first test was created the same but I th...

    I used given annotation, because the first test was created the same but I think "when" and "then" are better.

    Paweł Muchowski

    Łukasz Lewczyński I moved the exception and changed the annotations

    Łukasz Lewczyński I moved the exception and changed the annotations

    /classes/.../admin/administration.feature Added
    Open in IDE #permalink
    /classes/.../admin/facilityType.feature Added
    Open in IDE #permalink
    /classes/production/.../sanity/sanity.feature Added
    Open in IDE #permalink
    /classes/.../openlmis-contract-tests2/test_variables.properties Added
    Open in IDE #permalink
    /src/cucumber/.../admin/AdminStepDefs.java Changed
    Open in IDE #permalink
    /src/.../admin/CreateFacilityType.java Deleted
    Open in IDE #permalink
    /src/.../admin/CreateFacilityTypeStepDefs.java Added
    Open in IDE #permalink
    /src/.../common/InitialDataException.java Added
    Open in IDE #permalink
    /src/cucumber/.../common/LoginStepDefs.java Changed
    Open in IDE #permalink
    /src/.../common/TestDatabaseConnection.java Added
    Open in IDE #permalink
    /src/.../exception/InitialDataExeption.java Deleted 1
    Open in IDE #permalink
    /src/.../requisition/InitiateRequisitionStepDefs.java Added
    Open in IDE #permalink
    /src/cucumber/.../demo-data/input.sql Added
    Open in IDE #permalink
    /src/cucumber/.../admin/Administration.feature Added
    Open in IDE #permalink
    /src/cucumber/.../admin/FacilityType.feature Added
    Open in IDE #permalink
    /src/cucumber/.../admin/administration.feature Deleted
    Open in IDE #permalink
    /src/cucumber/.../admin/facilityType.feature Deleted
    Open in IDE #permalink
    /src/cucumber/.../sanity/Sanity.feature Added
    Open in IDE #permalink
    /src/cucumber/.../sanity/sanity.feature Deleted
    Open in IDE #permalink
    /src/.../storeroom_manager/StoreroomManager.feature Added
    Open in IDE #permalink
    /build.gradle Changed
    Open in IDE #permalink
    /docker-compose.override.yml Changed
    Open in IDE #permalink

    Review updated: Reload | Ignore | Collapse

    You cannot reload the review while writing a comment.

    Log time against