FEOLMIS-4031 OLMIS-6728 Fixed incorrect calculation of Stock On Hand

closed on 29 Jan 20

Author

Reviewers

OLMIS-6728 Fixed incorrect calculation of Stock On Hand

Activity

Details
Objectives
General Comments 2
Unresolved
Resolved
Number of files included: 4

openlmis-stockmanagement 0
- Folder src 0
  - Folder integration-test/java/org/openlmis/stockmanagement/service 0
    - File CalculatedStockOnHandServiceIntegrationTest.java 1 Remove
  - Folder main/java/org/openlmis/stockmanagement 0
    - Folder repository 0
      - File CalculatedStockOnHandRepository.java 0 Remove
    - Folder service 0
      - File CalculatedStockOnHandService.java 15 Remove
- File CHANGELOG.md 0 Remove

#permalink

Details

Warning: no files are visible, they have all been filtered.

Participant	Role	Time Spent	Comments	Latest Comment
Paulina Buzderewicz	Author	1h 12m	3	It would also require some additional changes, because we...
Paweł Pinker	Reviewer - 63% reviewed	17m
Sebastian Brudziński	Reviewer - Complete	1h 8m	15	Looks good to me!
Klaudia Pałkowska	Reviewer - Complete	42m
Mateusz Kwiatkowski	Reviewer - 5% reviewed	14m
Total		3h 35m	18

#permalink

Objectives

There are no specific objectives for this review.

Branches in review

#permalink

Issues Raised From Comments

Key	Summary	State	Assignee

#permalink

General Comments

Paulina Buzderewicz

Changelog reminder

23 Jan 20

Paulina Buzderewicz

Resolved

25 Jan 20

Sebastian Brudziński

Looks good to me!

29 Jan 20

Click to load diff

Notation	Description
[Crucible Review CR-1\|CR-1]	Creates a link to a Crucible review or FishEye artifact using the internal key reference for the item. Example: Crucible Review CR-1
[Atlassian Crucible\|http://atlassian.com/crucible]	Creates a link to an external resource, special characters that come after the URL and are not part of it must be separated with a space. External links are denoted with an arrow icon. Example: Atlassian Crucible
{cs:id=1\|rep=repository-key}	Render a link to the changeset Example: 1
bold	Makes text appear bold.
_italic_	Makes text appear in italics.
+underline+	Makes text appear underlined.
??citation??	Makes text appear in citation form.
-strikethrough-	Makes text appear ~~struck through~~.
^superscript^	Makes text appear in ^superscript.
~subscript~	Makes text appear in _subscript.
{{ monospaced }}	Placing double curly-brackets around text makes it appear `monospaced`.
{code} // Some comments here public String getFoo() { return foo; } {code}	The code macro displays a preformatted block for showing code with syntax highlighting. Example: // Some comments here public String getFoo() { return foo; }
bq. Block Quote	To make an entire paragraph into a block quotation, place "bq. " before it. Example: Block Quote
{quote} here is quoteable content to be quoted {quote}	Quote a block of text that's longer than one paragraph. Example: here is quoteable content to be quoted
{color:red} look ma, red text!{color}	Changes the color of a block of text. Example: look ma, red text!
* A list with bullets * Second item ** Indented item	Example: A list with bullets Second item Indented item
# A list with numbers # Second item ## Indented item	Example: A list with numbers Second item Indented item

FEOLMIS-4031

OLMIS-6728 Fixed incorrect calculation of Stock On Hand

FEOLMIS-4031 18

Details

Objectives

Branches in review

Issues Raised From Comments

General Comments

Paulina Buzderewicz

Sebastian Brudziński

Log time

OLMIS-6728 Fixed incorrect calculation of Stock On Hand

FEOLMIS-4031 18

Summarize the review outcomes (optional)

Details

Objectives

Branches in review

Issues Raised From Comments

General Comments

Paulina Buzderewicz

Sebastian Brudziński

Log time