FEOLMIS-4029 OLMIS-6679: Added a new method to fix Internal Server Errors.

closed on 28 Jan 20

Author

Reviewers

OLMIS-6679: Added a new method to fix Internal Server Errors.

Activity

Details
Objectives
General Comments 2
Unresolved
Resolved
Number of files included: 6

openlmis-stockmanagement 0
- Folder src 0
  - Folder integration-test/java/org/openlmis/stockmanagement/repository 0
    - File CalculatedStockOnHandRepositoryIntegrationTest.java 0 Remove
  - Folder main/java/org/openlmis/stockmanagement 0
    - Folder repository 0
      - File CalculatedStockOnHandRepository.java 3 Remove
    - Folder service 0
      - File StockCardSummariesService.java 0 Remove
  - Folder test/java/org/openlmis/stockmanagement 0
    - Folder service 0
      - File StockCardSummariesServiceTest.java 3 Remove
    - Folder web/stockcardrangesummaries 0
      - File StockCardRangeSummaryParamsTest.java 0 Remove
- File CHANGELOG.md 0 Remove

#permalink

Details

Warning: no files are visible, they have all been filtered.

Participant	Role	Time Spent	Comments	Latest Comment
Paweł Pinker	Author	51m	3	In StockCardRangeSummaryParamsTest.java class there are s...
Klaudia Pałkowska	Reviewer - Complete	15m	1	Why did we decide to enable searching for stock card summ...
Mateusz Kwiatkowski	Reviewer - Complete	19m	4	I see that if a statement is located in StockCardSummarie...
Paulina Buzderewicz	Reviewer - Complete	7m
Total		1h 34m	8

Linked issues
- OLMIS-6679

#permalink

Objectives

There are no specific objectives for this review.

Branches in review

#permalink

Issues Raised From Comments

Key	Summary	State	Assignee

#permalink

General Comments

Klaudia Pałkowska

Why did we decide to enable searching for stock card summaries only by the en...

Why did we decide to enable searching for stock card summaries only by the end date?

22 Jan 20

Paweł Pinker

To follow the documentation, which says "The date to start including stock da...

To follow the documentation, which says "The date to start including stock data for the summaries. If not provided summaries will be retrieved starting with the earliest". https://uat.openlmis.org/stockmanagement/docs/

22 Jan 20

Paweł Pinker

Resolved

28 Jan 20

Click to load diff

Notation	Description
[Crucible Review CR-1\|CR-1]	Creates a link to a Crucible review or FishEye artifact using the internal key reference for the item. Example: Crucible Review CR-1
[Atlassian Crucible\|http://atlassian.com/crucible]	Creates a link to an external resource, special characters that come after the URL and are not part of it must be separated with a space. External links are denoted with an arrow icon. Example: Atlassian Crucible
{cs:id=1\|rep=repository-key}	Render a link to the changeset Example: 1
bold	Makes text appear bold.
_italic_	Makes text appear in italics.
+underline+	Makes text appear underlined.
??citation??	Makes text appear in citation form.
-strikethrough-	Makes text appear ~~struck through~~.
^superscript^	Makes text appear in ^superscript.
~subscript~	Makes text appear in _subscript.
{{ monospaced }}	Placing double curly-brackets around text makes it appear `monospaced`.
{code} // Some comments here public String getFoo() { return foo; } {code}	The code macro displays a preformatted block for showing code with syntax highlighting. Example: // Some comments here public String getFoo() { return foo; }
bq. Block Quote	To make an entire paragraph into a block quotation, place "bq. " before it. Example: Block Quote
{quote} here is quoteable content to be quoted {quote}	Quote a block of text that's longer than one paragraph. Example: here is quoteable content to be quoted
{color:red} look ma, red text!{color}	Changes the color of a block of text. Example: look ma, red text!
* A list with bullets * Second item ** Indented item	Example: A list with bullets Second item Indented item
# A list with numbers # Second item ## Indented item	Example: A list with numbers Second item Indented item

FEOLMIS-4029

OLMIS-6679: Added a new method to fix Internal Server Errors.

FEOLMIS-4029 8

Details

Linked issues

Objectives

Branches in review

Issues Raised From Comments

General Comments

Klaudia Pałkowska

Paweł Pinker

Log time

OLMIS-6679: Added a new method to fix Internal Server Errors.

FEOLMIS-4029 8

Summarize the review outcomes (optional)

Details

Linked issues

Objectives

Branches in review

Issues Raised From Comments

General Comments

Klaudia Pałkowska

Paweł Pinker

Log time