OLMIS-6564: Fixed responses compression in the referencedata service

Activity

FEOLMIS-3991 6

Keyboard shortcuts  
  • Summarize the review outcomes (optional)
     
    #permalink

    Details

    Warning: no files are visible, they have all been filtered.
    Participant Role Time Spent Comments Latest Comment
    Author 25m 3 Done.
    Reviewer - Complete 1m    
    Reviewer - Complete 5m 3 Yes
    Reviewer - 88% reviewed 7m    
    Total   39m 6  
    #permalink

    Objectives

    There are no specific objectives for this review.

    Branches in review

    #permalink

    Issues Raised From Comments

    Key Summary State Assignee
    #permalink

    General Comments

    Sebastian Brudziński

    Good catch. Did you manage to check whether the same problem exists in other ...

    Good catch. Did you manage to check whether the same problem exists in other services too?

    Klaudia Pałkowska

    Referencedata was the only service which has used wire mock in the version 2....

    Referencedata was the only service which has used wire mock in the version 2.22.0. In 1.58 the problem doesn't occur. The only thing that we could do is to move the wire mock to the testCompile section in dependencies (in fulfillment, stockmanagement, and report).

    Sebastian Brudziński

    That would probably make sense, in case someone updates the wiremock version ...

    That would probably make sense, in case someone updates the wiremock version in the future

    Klaudia Pałkowska

    Should I do this?

    Should I do this?

    /CHANGELOG.md Changed
    /build.gradle Changed
    Open in IDE #permalink
    /src/main/.../dto/OrderableChildDto.java Changed
    /CHANGELOG.md Changed
    /build.gradle Changed
    Open in IDE #permalink
    /CHANGELOG.md Changed
    /dependency.gradle Changed
    Open in IDE #permalink
    /CHANGELOG.md Changed
    /build.gradle Changed

    Review updated: Reload | Ignore | Collapse

    You cannot reload the review while writing a comment.

    Log time against