OLMIS-6416: Fixed issues after switching to v2 requisition endpoints

Activity

FEOLMIS-3978 0

Keyboard shortcuts  
  • Summarize the review outcomes (optional)
     
    #permalink

    Details

    Warning: no files are visible, they have all been filtered.
    Participant Role Time Spent Comments Latest Comment
    Author 7m    
    Reviewer - Complete 35m    
    Reviewer - 7% reviewed 0m    
    Reviewer - Complete 21m    
    Total   1h 3m 0  
    #permalink

    Objectives

    • fixed displaying reference data on offline View Requisition screen
    • added clearing periods and facilities cache on logout
    • fixed methods to get period and facility if missed in cache
    • fixed calculating total cost on batch approval screen
    • fixed saving status messages

    Branches in review

    #permalink

    Issues Raised From Comments

    Key Summary State Assignee
    #permalink

    General Comments

    There are no general comments on this review.
    /src/referencedata-facility/facility.service.js Changed
    Open in IDE #permalink
    /src/referencedata-facility/referencedata-facility.run.js Added
    Open in IDE #permalink
    /src/referencedata-facility/referencedata-facility.run.spec.js Added
    Open in IDE #permalink
    /src/referencedata-facility-type-approved-product/facility-type-approved-product.resource.js Changed
    Open in IDE #permalink
    /src/referencedata-facility-type-approved-product/facility-type-approved-product.resource.spec.js Changed
    Open in IDE #permalink
    /src/referencedata-facility-type-approved-product/messages_en.json Added
    Open in IDE #permalink
    /src/referencedata-orderable/messages_en.json Added
    Open in IDE #permalink
    /src/referencedata-orderable/orderable-resource.js Changed
    Open in IDE #permalink
    /src/referencedata-orderable/orderable-resource.spec.js Changed
    Open in IDE #permalink
    /src/referencedata-period/period.resource.js Changed
    Open in IDE #permalink
    /src/referencedata-period/period.service.js Changed
    Open in IDE #permalink
    /src/referencedata-period/referencedata-period.run.js Added
    Open in IDE #permalink
    /src/referencedata-period/referencedata-period.run.spec.js Added
    Open in IDE #permalink
    /src/referencedata-program/program.service.js Changed
    /src/referencedata-program/program.service.spec.js Changed
    /src/referencedata-program/referencedata-program.module.js Changed
    Open in IDE #permalink
    /src/referencedata-program/referencedata-program.run.js Added
    Open in IDE #permalink
    /src/referencedata-program/referencedata-program.run.spec.js Added
    Open in IDE #permalink
    /CHANGELOG.md Changed
    /src/requisition/line-item.spec.js Changed
    Open in IDE #permalink
    /src/requisition/requisition-cache.service.js Changed
    /src/requisition/requisition-cache.service.spec.js Changed
    /src/requisition/requisition-data-builder.spec.js Changed
    /src/requisition/requisitions.service.js Changed
    /src/requisition-calculations/calculation.factory.js Changed
    Open in IDE #permalink
    /src/requisition-calculations/calculation.factory.spec.js Changed
    Open in IDE #permalink
    /src/requisition-view/full-supply.routes.spec.js Changed
    Open in IDE #permalink
    /src/requisition-view/non-full-supply.routes.spec.js Changed
    Open in IDE #permalink
    /src/requisition-view/requisition-view.routes.js Changed
    /src/requisition-view/requisition-view.routes.spec.js Changed
    /src/requisition-view/requisition-watcher.factory.js Changed
    /src/requisition-view/requisition-watcher.factory.spec.js Changed
    /src/openlmis-cached-repository/messages_en.json Added
    Open in IDE #permalink
    /src/openlmis-cached-repository/openlmis-cached-resource.js Changed
    /src/openlmis-cached-repository/openlmis-cached-resource.spec.js Changed
    /CHANGELOG.md Changed

    Review updated: Reload | Ignore | Collapse

    You cannot reload the review while writing a comment.

    Log time against