FEOLMIS-3977 OLMIS-6416 Modified caching facilities and processing periods on get and added VersionObjectReferenceDataBuilder...

closed on 09 Sep 19

Author

Reviewers

OLMIS-6416 Modified caching facilities and processing periods on get and added...

Activity

Details
Objectives
General Comments 1
Unresolved
Resolved
Number of files included: 29

openlmis-reference-ui 0
- File docker-compose.yml 0 Remove
openlmis-referencedata-ui 0
- Folder src 0
  - Folder referencedata 0
    - File version-object-reference-data-builder.spec.js 0 Remove
  - Folder referencedata-facility 0
    - File facility.service.js 0 Remove
    - File facility.service.spec.js 0 Remove
  - Folder referencedata-period 0
    - File period.resource.js 0 Remove
    - File period.service.js 0 Remove
    - File period.service.spec.js 0 Remove
- File CHANGELOG.md 0 Remove
openlmis-requisition-ui 0
- Folder src 0
  - Folder requisition 0
    - File line-item.js 0 Remove
    - File requisition-data-builder.spec.js 0 Remove
    - File requisition-line-item-v2-data-builder.spec.js 0 Remove
    - File requisition.js 0 Remove
    - File requisition.module.js 0 Remove
    - File requisition.spec.js 0 Remove
    - File requisitions.service.js 0 Remove
    - File requisitions.service.spec.js 0 Remove
  - Folder requisition-batch-approval 0
    - File requisition-batch-approval.controller.spec.js 0 Remove
  - Folder requisition-calculations 0
    - File calculation.factory.js 0 Remove
    - File calculation.factory.spec.js 0 Remove
  - Folder requisition-view 0
    - File full-supply.routes.spec.js 0 Remove
    - File header.html 0 Remove
    - File non-full-supply.routes.spec.js 0 Remove
    - File requisition-view.controller.js 0 Remove
    - File requisition-view.controller.spec.js 0 Remove
    - File requisition-view.html 0 Remove
    - File requisition-view.routes.js 0 Remove
    - File requisition-view.routes.spec.js 0 Remove
- File CHANGELOG.md 0 Remove
- File project.properties 0 Remove

#permalink

Details

Warning: no files are visible, they have all been filtered.

Participant	Role	Time Spent	Comments	Latest Comment
Paulina Buzderewicz	Author	1m	1	Changelog reminder.
Klaudia Pałkowska	Reviewer - Complete	7m
Aleksandra Sołtys	Reviewer - Complete	31m
Total		40m	1

#permalink

Objectives

There are no specific objectives for this review.

Branches in review

#permalink

Issues Raised From Comments

Key	Summary	State	Assignee

#permalink

General Comments

Paulina Buzderewicz

Changelog reminder.

06 Sep 19

Paulina Buzderewicz

Resolved

09 Sep 19

Click to load diff

Notation	Description
[Crucible Review CR-1\|CR-1]	Creates a link to a Crucible review or FishEye artifact using the internal key reference for the item. Example: Crucible Review CR-1
[Atlassian Crucible\|http://atlassian.com/crucible]	Creates a link to an external resource, special characters that come after the URL and are not part of it must be separated with a space. External links are denoted with an arrow icon. Example: Atlassian Crucible
{cs:id=1\|rep=repository-key}	Render a link to the changeset Example: 1
bold	Makes text appear bold.
_italic_	Makes text appear in italics.
+underline+	Makes text appear underlined.
??citation??	Makes text appear in citation form.
-strikethrough-	Makes text appear ~~struck through~~.
^superscript^	Makes text appear in ^superscript.
~subscript~	Makes text appear in _subscript.
{{ monospaced }}	Placing double curly-brackets around text makes it appear `monospaced`.
{code} // Some comments here public String getFoo() { return foo; } {code}	The code macro displays a preformatted block for showing code with syntax highlighting. Example: // Some comments here public String getFoo() { return foo; }
bq. Block Quote	To make an entire paragraph into a block quotation, place "bq. " before it. Example: Block Quote
{quote} here is quoteable content to be quoted {quote}	Quote a block of text that's longer than one paragraph. Example: here is quoteable content to be quoted
{color:red} look ma, red text!{color}	Changes the color of a block of text. Example: look ma, red text!
* A list with bullets * Second item ** Indented item	Example: A list with bullets Second item Indented item
# A list with numbers # Second item ## Indented item	Example: A list with numbers Second item Indented item

FEOLMIS-3977

OLMIS-6416 Modified caching facilities and processing periods on get and added...

FEOLMIS-3977 1

Details

Objectives

Branches in review

Issues Raised From Comments

General Comments

Paulina Buzderewicz

Log time

OLMIS-6416 Modified caching facilities and processing periods on get and added...

FEOLMIS-3977 1

Summarize the review outcomes (optional)

Details

Objectives

Branches in review

Issues Raised From Comments

General Comments

Paulina Buzderewicz

Log time