OLMIS-6470: Fixed updating Supervisory Node via PUT api/requisitionGroups/{id}

Activity

FEOLMIS-3973 4

Keyboard shortcuts  
  • Summarize the review outcomes (optional)
     
    #permalink

    Details

    Warning: no files are visible, they have all been filtered.
    Participant Role Time Spent Comments Latest Comment
    Author 42m 1 It's not checking whether SN exists in update request, bu...
    Reviewer - 93% reviewed 15m 1 Could we merge those calls? I think we don't need the sec...
    Reviewer - Complete 49m 2 Ok, throwing exception here is not desired indeed. If we ...
    Reviewer - Complete 12m    
    Total   1h 58m 4  
    #permalink

    Objectives

    There are no specific objectives for this review.

    Branches in review

    #permalink

    Issues Raised From Comments

    Key Summary State Assignee
    #permalink

    General Comments

    There are no general comments on this review.
    /src/.../repository/RequisitionGroupRepositoryIntegrationTest.java Changed
    Open in IDE #permalink
    /src/.../web/RequisitionGroupControllerIntegrationTest.java Changed
    Open in IDE #permalink
    /src/.../web/SupervisoryNodeControllerIntegrationTest.java Changed
    /src/.../validate/SupervisoryNodeValidator.java Changed
    /src/.../web/RequisitionGroupController.java Changed 4
    Open in IDE #permalink
    /src/.../web/RequisitionGroupController.java Changed
    Open in IDE #permalink
    /src/.../testbuilder/SupervisoryNodeDataBuilder.java Changed
    Open in IDE #permalink
    /src/.../validate/SupervisoryNodeValidatorTest.java Changed
    /CHANGELOG.md Changed

    Review updated: Reload | Ignore | Collapse

    You cannot reload the review while writing a comment.

    Log time against