OLMIS-6392: Added orderable versioning to ShipmentLineItem

Activity

FEOLMIS-3931 6

Keyboard shortcuts  
  • Summarize the review outcomes (optional)
     
    #permalink

    Details

    Warning: no files are visible, they have all been filtered.
    Participant Role Time Spent Comments Latest Comment
    Author 25m 3 Thanks for being vigilant, I changed this for debugging p...
    Reviewer - 96% reviewed 1m 1 I saw this migration in another review. I hope there is o...
    Reviewer - Complete 19m 2 Probably we can remove this comment.
    Reviewer - 0% reviewed      
    Total   45m 6  
    #permalink

    Objectives

    There are no specific objectives for this review.

    Branches in review

    #permalink

    Issues Raised From Comments

    Key Summary State Assignee
    #permalink

    General Comments

    There are no general comments on this review.
    /src/.../web/ShipmentControllerIntegrationTest.java Changed
    Open in IDE #permalink
    /src/.../web/ShipmentDraftControllerIntegrationTest.java Changed
    Open in IDE #permalink
    /src/.../domain/ShipmentDraftLineItem.java Changed
    Open in IDE #permalink
    /src/main/.../domain/ShipmentLineItem.java Changed
    Open in IDE #permalink
    /src/.../shipment/ShipmentLineItemBuilder.java Changed
    Open in IDE #permalink
    /src/main/.../shipment/ShipmentDtoBuilder.java Changed
    Open in IDE #permalink
    /src/.../shipment/ShipmentLineItemDto.java Changed
    Open in IDE #permalink
    /src/.../shipmentdraft/ShipmentDraftController.java Changed 2
    Open in IDE #permalink
    /src/.../shipmentdraft/ShipmentDraftDtoBuilder.java Changed
    Open in IDE #permalink
    /src/.../stockmanagement/StockEventLineItemDto.java Changed
    Open in IDE #permalink
    /src/.../demo-data/fulfillment.shipment_line_items.csv Changed
    Open in IDE #permalink
    /src/.../migration/20190724122922782__support_orderable_versioning_in_fulfillment.sql Added 2
    Open in IDE #permalink
    /src/main/.../schemas/shipmentLineItem.json Changed
    Open in IDE #permalink
    /src/.../domain/DummyShipmentLineItemDto.java Changed
    Open in IDE #permalink
    /src/.../domain/ShipmentDraftLineItemTest.java Changed
    Open in IDE #permalink
    /src/test/.../domain/ShipmentDraftTest.java Changed
    Open in IDE #permalink
    /src/test/.../domain/ShipmentLineItemTest.java Changed
    Open in IDE #permalink
    /src/test/.../domain/ShipmentTest.java Changed
    Open in IDE #permalink
    /src/.../shipment/ShipmentLineItemBuilderTest.java Changed
    Open in IDE #permalink
    /src/test/.../service/ShipmentServiceTest.java Changed
    /src/.../testutils/ShipmentDraftLineItemDataBuilder.java Changed 2
    Open in IDE #permalink
    /src/.../testutils/ShipmentLineItemDataBuilder.java Changed
    Open in IDE #permalink
    /src/.../shipment/ShipmentLineItemDtoDataBuilder.java Changed
    Open in IDE #permalink
    /src/.../shipment/ShipmentLineItemDtoTest.java Changed
    Open in IDE #permalink

    Review updated: Reload | Ignore | Collapse

    You cannot reload the review while writing a comment.

    Log time against