OLMIS-6392: Added orderable versioning to OrderLineItem

Activity

FEOLMIS-3930 4

Keyboard shortcuts  
  • Summarize the review outcomes (optional)
     
    #permalink

    Details

    Warning: no files are visible, they have all been filtered.
    Participant Role Time Spent Comments Latest Comment
    Author 17m    
    Reviewer - Complete 7m 3 number
    Reviewer - Complete 12m 1 Probably we can use a static variable ORDERABLE here.
    Reviewer - 0% reviewed      
    Total   36m 4  
    #permalink

    Objectives

    There are no specific objectives for this review.

    Branches in review

    #permalink

    Issues Raised From Comments

    Key Summary State Assignee
    #permalink

    General Comments

    There are no general comments on this review.
    /src/.../web/BaseWebIntegrationTest.java Changed
    Open in IDE #permalink
    /src/.../web/OrderControllerIntegrationTest.java Changed
    Open in IDE #permalink
    /src/main/.../domain/OrderLineItem.java Changed
    Open in IDE #permalink
    /src/.../domain/VersionEntityReference.java Added
    Open in IDE #permalink
    /src/main/.../referencedata/OrderableDto.java Changed 1
    Open in IDE #permalink
    /src/.../referencedata/OrderableReferenceDataService.java Changed
    Open in IDE #permalink
    /src/.../referencedata/OrderableSearchParams.java Added
    Open in IDE #permalink
    /src/main/.../service/ExporterBuilder.java Changed
    Open in IDE #permalink
    /src/main/.../service/OrderCsvHelper.java Changed
    Open in IDE #permalink
    /src/main/.../util/FileColumnKeyPath.java Changed
    Open in IDE #permalink
    /src/.../stockmanagement/StockEventLineItemDto.java Changed
    Open in IDE #permalink
    /src/main/java/.../web/util/MetadataDto.java Added 1
    Open in IDE #permalink
    /src/main/.../web/util/OrderDtoBuilder.java Changed
    Open in IDE #permalink
    /src/main/.../web/util/OrderExportHelper.java Changed
    Open in IDE #permalink
    /src/main/.../web/util/OrderLineItemDto.java Changed
    Open in IDE #permalink
    /src/main/.../web/util/StockEventBuilder.java Changed
    /src/main/.../web/util/VersionIdentityDto.java Added
    Open in IDE #permalink
    /src/.../util/VersionObjectReferenceDto.java Added
    Open in IDE #permalink
    /src/main/.../web/OrderController.java Changed
    Open in IDE #permalink
    /src/.../demo-data/fulfillment.order_line_items.csv Changed
    Open in IDE #permalink
    /src/.../migration/20190724122922782__support_orderable_versioning_in_fulfillment.sql Added
    Open in IDE #permalink
    /src/main/resources/schemas/metadata.json Added 1
    Open in IDE #permalink
    /src/main/.../schemas/orderableDto.json Changed
    Open in IDE #permalink
    /src/.../schemas/versionObjectReference.json Added
    Open in IDE #permalink
    /src/test/.../domain/OrderLineItemTest.java Changed
    Open in IDE #permalink
    /src/.../domain/VersionEntityReferenceTest.java Added
    Open in IDE #permalink
    /src/.../referencedata/OrderableReferenceDataServiceTest.java Changed
    Open in IDE #permalink
    /src/.../referencedata/OrderableSearchParamsTest.java Added
    Open in IDE #permalink
    /src/test/.../service/ExporterBuilderTest.java Changed
    Open in IDE #permalink
    /src/test/.../service/OrderCsvHelperTest.java Changed 1
    Open in IDE #permalink
    /src/test/.../service/OrderServiceTest.java Changed
    Open in IDE #permalink
    /src/.../service/VersionIdentityDtoTest.java Added
    Open in IDE #permalink
    /src/.../testutils/OrderableDataBuilder.java Changed
    Open in IDE #permalink
    /src/test/.../web/util/MetadataDtoTest.java Added
    Open in IDE #permalink
    /src/test/.../util/OrderDtoBuilderTest.java Changed
    Open in IDE #permalink
    /src/test/.../util/OrderExportHelperTest.java Changed
    Open in IDE #permalink
    /src/test/.../util/StockEventBuilderTest.java Changed
    /src/.../util/VersionObjectReferenceDtoTest.java Added
    Open in IDE #permalink
    /src/.../fulfillment/OrderLineItemDataBuilder.java Changed
    Open in IDE #permalink
    /CHANGELOG.md Changed

    Review updated: Reload | Ignore | Collapse

    You cannot reload the review while writing a comment.

    Log time against