OLMIS-6442: Added UI for FTAPs

Activity

FEOLMIS-3926 15

Keyboard shortcuts  
  • Summarize the review outcomes (optional)
     
    #permalink

    Details

    Warning: no files are visible, they have all been filtered.
    Participant Role Time Spent Comments Latest Comment
    Author 30m 1 Fixed
    Reviewer - 83% reviewed 30m 13 Missing unit tests.
    Reviewer - 75% reviewed 40m 1 the same 'confirmService' is in 27 line
    Reviewer - 75% reviewed 15m    
    Total   1h 55m 15  
    #permalink

    Objectives

    There are no specific objectives for this review.

    Branches in review

    #permalink

    Issues Raised From Comments

    Key Summary State Assignee
    #permalink

    General Comments

    There are no general comments on this review.
    /src/admin-orderable-edit/admin-orderable-edit.module.js Changed
    Open in IDE #permalink
    /src/admin-orderable-edit/admin-orderable-edit.routes.js Changed 1
    /src/admin-orderable-edit/admin-orderable-edit.routes.spec.js Changed 1
    /src/admin-orderable-edit/facility-type-approved-product-form.html Added
    Open in IDE #permalink
    /src/admin-orderable-edit/messages_en.json Changed
    /src/admin-orderable-edit/orderable-add-edit-ftaps.controller.js Added 3
    /src/admin-orderable-edit/orderable-add-edit-ftaps.controller.spec.js Added
    /src/admin-orderable-edit/orderable-edit-ftap.html Added 2
    Open in IDE #permalink
    /src/admin-orderable-edit/orderable-edit-ftaps-list.controller.js Added 2
    Open in IDE #permalink
    /src/admin-orderable-edit/orderable-edit-ftaps-list.controller.spec.js Added 2
    Open in IDE #permalink
    /src/admin-orderable-edit/orderable-edit-ftaps-list.html Added
    Open in IDE #permalink
    /src/admin-orderable-edit/orderable-edit-kit-unpack-list.html Changed
    /src/admin-orderable-edit/orderable-edit.controller.js Changed
    /src/admin-orderable-ftap-add/admin-orderable-ftap-add.module.js Added 1
    Open in IDE #permalink
    /src/admin-orderable-ftap-add/admin-orderable-ftap-add.routes.js Added 1
    /src/admin-orderable-ftap-add/messages_en.json Added
    Open in IDE #permalink
    /src/admin-orderable-ftap-add/orderable-ftap-add.html Added
    Open in IDE #permalink
    /src/admin-orderable-ftap-edit/admin-orderable-ftap-edit.module.js Added 1
    Open in IDE #permalink
    /src/admin-orderable-ftap-edit/admin-orderable-ftap-edit.routes.js Added
    /src/admin-orderable-ftap-edit/messages_en.json Added
    /src/admin-orderable-ftap-edit/orderable-ftap-edit.html Added
    Open in IDE #permalink
    /src/admin-orderable-list/admin-orderable-list.routes.js Changed
    /src/openlmis-rights/administration-rights.constant.js Changed
    Open in IDE #permalink
    /src/referencedata-facility-type/facility-type.resource.js Added 1
    Open in IDE #permalink
    /src/referencedata-facility-type/facility-type.resource.spec.js Added
    Open in IDE #permalink
    /src/referencedata-facility-type-approved-product/facility-type-approved-product-data-builder.spec.js Changed
    Open in IDE #permalink
    /src/referencedata-facility-type-approved-product/facility-type-approved-product.js Changed
    Open in IDE #permalink
    /src/referencedata-facility-type-approved-product/facility-type-approved-product.spec.js Changed
    Open in IDE #permalink
    /CHANGELOG.md Changed
    /src/openlmis-function-decorator/openlmis-function-decorator.js Changed
    Open in IDE #permalink
    /src/openlmis-function-decorator/openlmis-function-decorator.spec.js Changed
    Open in IDE #permalink
    /CHANGELOG.md Changed

    Review updated: Reload | Ignore | Collapse

    You cannot reload the review while writing a comment.

    Log time against