OLMIS-6443: Reworked orderable view into multiple tabs

Activity

FEOLMIS-3913 7

Keyboard shortcuts  
  • Summarize the review outcomes (optional)
     
    #permalink

    Details

    Warning: no files are visible, they have all been filtered.
    Participant Role Time Spent Comments Latest Comment
    Author 27m 5 Added in https://review.openlmis.org/cru/FEOLMIS-3923
    Reviewer - Complete 15m 2 I'm not sure if those states should have .edit before tab...
    Reviewer - Complete 11m    
    Total   52m 7  
    #permalink

    Objectives

    There are no specific objectives for this review.

    Branches in review

    #permalink

    Issues Raised From Comments

    Key Summary State Assignee
    #permalink

    General Comments

    Klaudia Pałkowska

    Didn't we miss part of adding a new orderable? I mean button above the ordera...

    Didn't we miss part of adding a new orderable? I mean button above the orderable list which opens the modal and allows a user to add a new orderable.

    Nikodem Graczewski

    Added in https://review.openlmis.org/cru/FEOLMIS-3923

    Added in https://review.openlmis.org/cru/FEOLMIS-3923

    /src/admin-orderable-edit/admin-orderable-edit.module.js Changed
    /src/admin-orderable-edit/admin-orderable-edit.routes.js Changed 1
    /src/admin-orderable-edit/admin-orderable-edit.routes.spec.js Changed
    /src/admin-orderable-edit/messages_en.json Changed
    /src/admin-orderable-edit/orderable-edit-general.controller.js Added
    Open in IDE #permalink
    /src/admin-orderable-edit/orderable-edit-general.controller.spec.js Added
    Open in IDE #permalink
    /src/admin-orderable-edit/orderable-edit-general.html Added
    Open in IDE #permalink
    /src/admin-orderable-edit/orderable-edit-kit-unpack-list.controller.js Added
    Open in IDE #permalink
    /src/admin-orderable-edit/orderable-edit-kit-unpack-list.controller.spec.js Added
    Open in IDE #permalink
    /src/admin-orderable-edit/orderable-edit-kit-unpack-list.html Added
    Open in IDE #permalink
    /src/admin-orderable-edit/orderable-edit-programs.controller.js Added
    Open in IDE #permalink
    /src/admin-orderable-edit/orderable-edit-programs.controller.spec.js Added
    Open in IDE #permalink
    /src/admin-orderable-edit/orderable-edit-programs.html Added
    Open in IDE #permalink
    /src/admin-orderable-edit/orderable-edit.controller.js Changed 2
    /src/admin-orderable-edit/orderable-edit.controller.spec.js Changed
    Open in IDE #permalink
    /src/admin-orderable-edit/orderable-edit.html Changed
    Open in IDE #permalink
    /src/admin-orderable-list/admin-orderable-list.module.js Changed
    Open in IDE #permalink
    /src/admin-orderable-list/admin-orderable-list.routes.js Changed
    /src/admin-orderable-list/messages_en.json Changed
    /src/admin-orderable-list/orderable-list.html Changed
    /src/referencedata-orderable/orderable-data-builder.spec.js Changed 1
    /src/referencedata-orderable/orderable.js Changed
    Open in IDE #permalink
    /src/referencedata-program/program-resource.js Added 1
    Open in IDE #permalink
    /src/referencedata-program/program-resource.spec.js Added
    Open in IDE #permalink
    /src/referencedata-program/programs-resource.spec.js Deleted
    Open in IDE #permalink
    /src/referencedata-program/referencedata-program.module.js Changed
    /CHANGELOG.md Changed

    Review updated: Reload | Ignore | Collapse

    You cannot reload the review while writing a comment.

    Log time against