OLMIS-682: Unpack kit into stock

Activity

FEOLMIS-3744 12

Keyboard shortcuts  
  • Summarize the review outcomes (optional)
     
    #permalink

    Details

    Warning: no files are visible, they have all been filtered.
    Participant Role Time Spent Comments Latest Comment
    Author 58m 4 Thanks Josh Zamor I appreciate the feedbacks.
    Reviewer - Complete 7m 2 I agree that introducing enum values now is too dangerous...
    Reviewer - Complete 10m    
    Reviewer - Complete 18m 6 Looks good, thanks!
    Total   1h 33m 12  
    #permalink

    Objectives

    There are no specific objectives for this review.

    Branches in review

    #permalink

    Issues Raised From Comments

    Key Summary State Assignee
    OLMIS-6191
    #permalink

    General Comments

    Josh Zamor

    Left a couple comments. Thanks Elias.

    Left a couple comments. Thanks Elias.

    Elias

    Thanks Josh Zamor I appreciate the feedbacks.

    Thanks Josh Zamor I appreciate the feedbacks.

    Josh Zamor

    Looks good, thanks!

    Looks good, thanks!

    /settings-sample.env Changed 1
    /src/main/.../reason/ReasonCategory.java Changed
    Open in IDE #permalink
    /src/.../referencedata/OrderableChildDto.java Added
    Open in IDE #permalink
    /src/main/.../referencedata/OrderableDto.java Changed
    Open in IDE #permalink
    /src/main/.../dto/StockEventDto.java Changed 4
    Open in IDE #permalink
    /src/main/.../i18n/MessageKeys.java Changed
    /src/.../service/StockEventProcessContextBuilder.java Changed
    Open in IDE #permalink
    /src/.../util/StockEventProcessContext.java Changed
    Open in IDE #permalink
    /src/.../validators/UnpackKitValidator.java Added 2
    Open in IDE #permalink
    /src/.../migration/20190325160137376__add_kit_unpacking_reason.sql Added
    Open in IDE #permalink
    /src/main/resources/application.properties Changed 2
    Open in IDE #permalink
    /src/main/resources/messages_en.properties Changed
    /src/test/.../dto/StockEventDtoTest.java Changed
    Open in IDE #permalink
    /src/.../service/StockEventValidationsServiceTest.java Changed
    Open in IDE #permalink
    /src/.../testutils/OrderableDtoDataBuilder.java Changed
    Open in IDE #permalink
    /src/.../testutils/StockEventDtoDataBuilder.java Changed
    Open in IDE #permalink
    /src/.../testutils/StockEventLineItemDtoDataBuilder.java Changed
    Open in IDE #permalink
    /src/.../validators/UnpackKitValidatorTest.java Added
    Open in IDE #permalink
    /CHANGELOG.md Changed
    /README.md Changed
    Open in IDE #permalink

    Review updated: Reload | Ignore | Collapse

    You cannot reload the review while writing a comment.

    Log time against