OLMIS-6040 Add SMS integration

Activity

FEOLMIS-3694 4

Keyboard shortcuts  
  • Summarize the review outcomes (optional)
     
    #permalink

    Details

    Warning: no files are visible, they have all been filtered.
    Participant Role Time Spent Comments Latest Comment
    Author 10m    
    Reviewer - Complete 11m 1 Shouldn't that be checked somewhere up the stream?
    Reviewer - Complete 5m 3 okay, my bad. We do this for email (only the important fl...
    Total   27m 4  
    #permalink

    Objectives

    • Review additional option in router
    • Review SMS handler
    • Review SMS sending logic to TextIt
    • Review new config settings

    Branches in review

    #permalink

    Issues Raised From Comments

    Key Summary State Assignee
    #permalink

    General Comments

    There are no general comments on this review.
    /src/main/.../i18n/MessageKeys.java Changed
    /src/.../service/NotificationChannelRouter.java Changed
    Open in IDE #permalink
    /src/.../service/SmsNotificationChannelHandler.java Added 3
    Open in IDE #permalink
    /src/main/.../service/SmsRequestDto.java Added
    Open in IDE #permalink
    /src/main/.../service/SmsSender.java Added
    Open in IDE #permalink
    /src/main/.../notification/Application.java Changed
    Open in IDE #permalink
    /src/main/resources/application.properties Changed
    /src/main/resources/messages_en.properties Changed
    /src/.../service/NotificationChannelRouterTest.java Changed
    Open in IDE #permalink
    /src/.../service/SmsNotificationChannelHandlerTest.java Added
    Open in IDE #permalink
    /src/test/.../service/SmsRequestDtoTest.java Added 1
    Open in IDE #permalink
    /src/test/.../service/SmsSenderTest.java Added
    Open in IDE #permalink
    /CHANGELOG.md Changed
    /settings-sample.env Changed

    Review updated: Reload | Ignore | Collapse

    You cannot reload the review while writing a comment.

    Log time against